[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Large Messages and the JMS Bridge
by clebert.suconic@jboss.com
We had a relevant conversation about this today on the IRC, and I wanted to keep a record of it here:
"Clebert, Andy and Jeff on IRC" wrote :
| (10:15:18 AM) clebert: Cache on LargeMessage
| (10:15:24 AM) clebert: the way I implemented is...
| (10:15:34 AM) clebert: I added a new attribute on the SessionFactory and ConnectionFactory
| (10:15:42 AM) clebert: cacheLargeMessageClient
| (10:15:45 AM) clebert: with default = false
| (10:16:07 AM) clebert: if that is set, the LargeMessageBuffer will use a temporary file (on the TempDir) to hold on the large message content
| (10:16:19 AM) clebert: tempDir = File.createTempFile()
| (10:16:29 AM) clebert: the file is marked to be deleted after exit
| (10:16:36 AM) clebert: and finalize will also delete the temp file
| (10:16:48 AM) clebert: that will be probably used only on the bridge... or if the user needs it
| (10:16:58 AM) clebert: I only need to document it now
| (10:17:07 AM) AndyTaylor: clebert: so the message will stay in temp for the user to obtain
| (10:17:30 AM) clebert: AndyTaylor: LargeMessages are usually a stream of packets...
| (10:17:35 AM) clebert: if that property is true...
| (10:17:39 AM) clebert: there will be a file on the client...
| (10:17:48 AM) clebert: so if the user moves the buffer back, it will recover the content from the file
| (10:18:05 AM) clebert: otherwise it' s not possible to move a largemessage buffer back, since it would be a streaming otherwise
| (10:18:12 AM) AndyTaylor: clebert: ok i see.
| (10:18:22 AM) jmesnil: clebert: do you think it is worth to have a example with a cached large message?
| (10:19:05 AM) clebert: jmesnil: I' m not sure... I would prefer users not using that feature... only letting it for cases where you need to cache the message (i.e., the Bridge)
| (10:19:16 AM) AndyTaylor: clebert: +1, i agree
| (10:19:17 AM) clebert: jmesnil: I' m not 100% sure
| (10:19:25 AM) AndyTaylor: clebert: internal use only
| (10:19:26 AM) jmesnil: clebert: ok, it's more an "internal" feature
| (10:19:54 AM) clebert: jmesnil: allthough I would need to set the attribute for the Bridge
| (10:19:59 AM) clebert: on the CF used by the Bridge
| (10:20:10 AM) clebert: maybe I would only set it on the JMSBridge
| (10:20:38 AM) jmesnil: clebert: on the core bridge too?
| (10:21:05 AM) clebert: jmesnil: no... the core bridge deals with ServerMessage which has the File on it already
| (10:21:17 AM) jmesnil: clebert: ah, ok
| (10:21:26 AM) clebert: jmesnil: I will double check it though
|
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4246501#4246501
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4246501
16 years, 8 months
[Design the new POJO MicroContainer] - Re: VFS3 - missing features and other issues
by david.lloyd@jboss.com
"alesj" wrote : "david.lloyd(a)jboss.com" wrote :
| | AssembledDirectory shouldn't be needed anymore with the new design (there is only one view of the VFS and that's the fully assembled view).
| |
| | MemoryFileFactory should be replaced with an alternative API... right now it all needs to be explicit (make a temp dir, mount the temp dir in the real VFS, and use getPhysicalFile() to make modifications). I think a static method might be a good idea to do this automatically though.
| |
| I only need this API for back-compatibility.
| How it's implemented in the back, I don't care.
| But not having this would mean huge changes to MC testing,
| as a lot CL, Deployers, WB, ... tests depends on it.
|
| You can definitely deprecate it, and write better suited API to the new VFS API.
If you want to add it back in, be my guest - it just means putting off the same work until later though. Except then it will probably be even more difficult since more time will pass allowing the API to become even more entrenched. We intended to change or remove the tests (some of the tests seem to exist only to test this feature; it would be strange to add the feature just to make those tests work). As for the other stuff, the temp file API needs to be fixed up a bit to allow for those components to be ported (remember that this is an unfinished prototype). I think the quick/easy fix would be a mistake here.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4246497#4246497
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4246497
16 years, 8 months