Dimitris Andreadis [http://community.jboss.org/people/dimitris%40jboss.org] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/561298#561298 -------------------------------------------------------------- My git bash shell on Windoze doesn't seem to support --whitepace=fix. $ git --version git version 1.7.0.2.msysgit.0 -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/561298#561298] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]

Brian Stansberry [http://community.jboss.org/people/bstansberry%40jboss.com] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/561617#561617 -------------------------------------------------------------- BTW, the "git --whitespace=fix rebase upstream/master" instruction should only be relevant if you have outstanding development work on a topic branch that you created before David fixed the whitespace and now you want to rebase the topic branch to the master branch before integrating your development work. If you only have a local repo that you use to follow upstream you shouldn't need to do that, you can just "git pull upstream". -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/561617#561617] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]

David Lloyd [http://community.jboss.org/people/david.lloyd%40jboss.com] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/561156#561156 -------------------------------------------------------------- I know we do have some eclipse users here, but I'm not one of them.  Can someone with some good settings volunteer this information? -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/561156#561156] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]

Jason Greene [http://community.jboss.org/people/jason.greene%40jboss.com] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/561198#561198 -------------------------------------------------------------- Done see ide-configs/eclipse -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/561198#561198] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]

jaikiran pai [http://community.jboss.org/people/jaikiran] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/578662#578662 -------------------------------------------------------------- Is there some ready to use IntelliJ IDEA templates for AS7? -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/578662#578662] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]

Dimitris Andreadis [http://community.jboss.org/people/dimitris%40jboss.org] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/562024#562024 -------------------------------------------------------------- I get many "File does not end with a newline." checkstyle errors on Windoze, which makes me think it's something to do with the line endings maybe. Any idea what is the correct/preferred git 'core.autocrlf' option? -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/562024#562024] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]

Jonathan Pearlin [http://community.jboss.org/people/jpearlin] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/589933#589933 -------------------------------------------------------------- I am seeing an issue between the templates in Eclipse and the checkstyle performed by Maven (and maybe I am configuring something wrong).  The provided templates for Eclipse cause a space to be placed before the carriage return for any Javadoc comments on a class or method: /** * Some description * <-- space here * @param foo ... ... */ If you manually remove the space, but leave the suggested save actions on (the auto-formatting), the space gets added back by Eclipse (I could not find how to prevent the space from being added...if you look at the Comments section under the Formatter, there is no check box to prevent that line with the space...maybe the template just needs to be edited?).  The end result is that checkstyle check in Maven fails because that line contains a trailing whitespace and therefore cannot build AS.  I got around this by disabling the Format Source Save Action, which is obviously not what we want to do.  Do I just have out-dated templates imported or should I go ahead and look into modifying the template to make the Eclipse save actions consistent with the checkstyle check? -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/589933#589933] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]

David Bosschaert [http://community.jboss.org/people/bosschaert] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/590069#590069 -------------------------------------------------------------- I always have this done in Eclipse as a Save Action. In the Preferences menu you go to Java -> Editor -> Save Actions and there you can add 'Remove trailing white space on all lines' in the 'Additional Actions' section to get them removed automatically whenever you save a Java file... -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/590069#590069] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]

Jason Greene [http://community.jboss.org/people/jason.greene%40jboss.com] created the discussion "Re: Checkstyle" To view the discussion, visit: http://community.jboss.org/message/590095#590095 -------------------------------------------------------------- Ah ok that makes sense. Reformat on save should definitely be turned off, so our configs need to be fixed (I'll look at that). The feature is coun ter productive not just because of the bug you found, but also because constant reformatting increases the odds of a source conflict, and it makes cone review and history harder to read. Trailing ws on the other hand is an exception because check style won't allow it, so we never have to worry about a conflict -------------------------------------------------------------- Reply to this message by going to Community [http://community.jboss.org/message/590095#590095] Start a new discussion in JBoss AS7 Development at Community [http://community.jboss.org/choose-container!input.jspa?contentType=1&...]