Set/get methods implemented :-) Will put @Dynamic. Even if I put this tag, do I need to still test immutability in the setter? Galder Zamarreño Sr. Software Maintenance Engineer JBoss, a division of Red Hat IT executives: Red Hat still #1 for value http://www.redhat.com/promo/vendor/ -----Original Message----- From: Brian Stansberry Sent: 23 November 2006 16:17 To: Galder Zamarreno Cc: 'jbosscache-dev(a)lists.jboss.org' Subject: RE: Valdiations in FileCacheLoader Be sure to use get/setCheckCharacterPortability() in FileCacheLoaderConfig as the primary mechanism for storing/retrieving this property. Make the field @Dynamic, as there is no reason this can't be changed on a running cache. Galder Zamarreno wrote: > 1) I'm adding a switch in the properties section. I think default > value should be true having the possibility to switch it off by > setting "check.character.portability" property to false. > > 2) done > > Galder Zamarreño > Sr. Software Maintenance Engineer > JBoss, a division of Red Hat > > IT executives: Red Hat still #1 for value > http://www.redhat.com/promo/vendor/ > > -----Original Message----- > From: Brian Stansberry > Sent: 20 November 2006 20:58 > To: Galder Zamarreno > Cc: jbosscache-dev(a)lists.jboss.org > Subject: Valdiations in FileCacheLoader > > Hey Galder, > > Couple thoughts on the validation stuff in FileCacheLoader: > > 1) How about adding an on/off switch to FileCacheLoaderConfig? If I > know my stuff conforms, I don't want to pay the performance penalty > to check it. 2) I believe Pattern is thread safe, so you should be > able to cache your compiled patterns in a static field. >