Re: [jbosscache-dev] Optimize use of CacheLoader.exists() with passivation

Manik Surtani wrote: > On 26 Nov 2008, at 04:28, Brian Stansberry wrote: >> I'm not sure exactly what that logic is doing, so I won't try to >> comment on whether tracking whether nodes were loaded in the >> TransactionContext makes sense. :) > The purpose of this visitor is to build a List<Modification> from a > List<WriteCommand> of commands that have happened in the > transaction, which then gets passed to the CacheLoader.prepare() > call. > It does make sense to track load information in the transaction > context as well, so let me re-open the JIRA. >> I'm working to eliminate the biggest hotspot in the attached >> graphic; once I do I'll test w/ CR1 vs CR2 to get a feel for how >> much JBCACHE-1446 improved things. >> >> ...done... >> >> w/ 3.0.1.CR1: 3677 req/sec >> w/ 3.0.1.CR2: 3955 req/sec >> no CL at all: 4930 req/sec (w/ CR2; CL config is commented out) w/ latest snapshot: 4476 req/sec

:-) No time today to look at profiler to see if there's any obvious explanation for the diff vs. no CL at all. > Not bad. So a 7.5% increase in throughput when moving to CR2. > Cheers > Manik -- Brian Stansberry Lead, AS Clustering JBoss, a division of Red Hat brian.stansberry(a)redhat.com