Please review 2 classes
by Pete Royle
Hi,
Speaking of code reviews. I've just made @Asynchronous portable using an
adaptation of Stuart Douglas' ThreadLocal idea, plus some
InvocationContext fiddling. I tried to understand the Interceptor Spec
and how it related to what I was trying to do, but I still wasn't sure
exactly what was expected of me to keep the spec happy. In the end I
managed to get it working by watching the behavior of the threads in the
debugger and pandering to that. It seemed consistent between OWB and
Weld at least, and the resulting solution works in both containers.
Anyway, I'm clearly not 100% trustworthy of this code, particularly wrt
being within the spec, so would appreciate some experts giving it the
once-over.
https://github.com/seam/cron/tree/master/spi/src/main/java/org/jboss/seam...
Cheers,
Pete R.
13 years, 8 months
- 3
- 3
seamfaces UIInputContainer problems
by José Rodolfo Carrijo de Freitas
Hello guys,
Im working on the issue https://issues.jboss.org/browse/SEAMFACES-93.
I did some tests and it seems to be a problem with mojarra implementation,
theres a registered issue about that:
http://java.net/jira/browse/JAVASERVERFACES-1991 which is linked to
http://java.net/jira/browse/JAVASERVERFACES-2040 that has a patch
but was not applied yet.
Brian suggested to use a workaround with facets as suggested in 1991 JSF
issue, at least until we have an applied patch for that.
I made a preliminary test and it seems to work but it changes (big change
I'd say) the way one uses the component
>From this:
<sc:inputContainer label="Name" required="true">
<h:inputText id="name" required="true" size="50" maxlength="50"
value="#{testBean.name}" label="Name"/>
</sc:inputContainer>
To this:
<sc:inputContainer label="Name" required="true">
<f:facet name="inputContainerFacet">
<h:inputText id="name" required="true" size="50" maxlength="50"
value="#{testBean.name}" label="Name"/>
</f:facet>
</sc:inputContainer>
Do you have any others suggestions or if you don´t have a suggestion, what
do you think about changing the component usage?
Best Regards,
José Freitas
13 years, 8 months
- 3
- 2