Great work again Sanjay! thanks. This project is starting to take shape. I will take it for a test drive today. Sumanth, did you have any updates from the properties dialog box we have discussed? This seems to be next logical step towards integrating this with what Sanjay has done. Sanjay, may be as next step you can work on the property replacement framework on the source files. Thanks. Ramesh.. On Mon, 2009-11-30 at 17:02 -0600, Sanjay Chaudhuri wrote: > Hi Ramesh, > > I have uploaded the changes to take care of the functionality. > > What's New: > - Connector can be exported as RAR to any directory. Application > remembers the exported directory > - Projects with errors are not exported; users are notified using an > error dialog. > - Cdk nature has been added which will give a custom icon to any Cdk > Connector projects. > - Temporary files are deleted. > - Runtime errors had been notified using dialog box, > > Let me know if you would like to me change something or you come > across any bug. > > Thanks > > Sanjay _______________________________________________ teiid-dev mailing list teiid-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/teiid-dev

Hi Ramesh, Absolutely. Let me know how to go ahead with the wiki; I mean location, existing templates to look at, etc. I have looked at the eclipse core sources for the templates; it's in line with what I did. The other template frameworks are more elaborate substitutions;conditions, etc, which I do not think will be necessary. You can refer to Eclipse templates here: http://www.ibm.com/developerworks/library/os-eclipse-pde/ and JET templates here: http://www.ibm.com/developerworks/opensource/library/os-ecl-jet/. Let me know what you think, and possible use-cases incase you want to move forward with either one. There are few things left to be done, which I am planning to take up: 1. Preference Page with installed cdk plugin location or be able to custom it with no plugins. 2. Wizard for output directory which will keep last few directories.

Hi Michael, Using loopback classes was just a start to get the ball rolling in terms of having something. I picked that up to get started on with. It will be replaced later with more generic template which Ramesh is working on. I am not too technical with Teiid-Cdk connector internals, so will move forward with whatever serves the best use-cases from you guys. And then probably we need to use the Eclipse/JET templates engines. I remember having the same problem with compilation because could not get hold off FakeMetadataFactory. Ramesh had sent it to me; I guess I missed checking in that; will do it soon. Thanks Sanjay On Tue, Dec 1, 2009 at 2:54 PM, Michael Walker <mwalker(a)redhat.com&gt;wrote: > Cool stuff guys! > > I just caught up on this thread, downloaded the CDK and gave it a spin. I > was able to build the basic project and produce the RAR, neat! This will be > a great way to encourage custom connector development, and I intend to use > it for future work. > > I have a few questions and thoughts about it. > > 1. Using the loopback connector code as the template may have some > drawbacks, namely: > a. If the API changes, we have to update (or re-copy) the template code > (perhaps this is automated already?). > b. The developer will have to remove most of the code specific to > loopback, since it wouldn't be useful in any other legitimate connector. > These changes will, of course, break the loopback-specific tests as well, > which will also require effort to fix. This adds up to extra, unnecessary > work for the developer. > c. It includes lots of coding assumptions that the developer probably > wouldn't want initially. For example, the developer is probably going to > want all capabilities set to false initially, and will add support for > capabilities and functions over time. > d. It doesn't use connection pooling, which should arguably be something > included in the boilerplate code (via @ConnectionPooling annotation). > e. As Ramesh mentioned earlier in the thread, it generates classes called > "LoopbackConnection", etc., when the developer really wants > "MyCustomConnection", where MyCustom is the name of their project. > > As an alternative, did we consider using Eclipse's built-in mechanism for > building boilerplate classes based on the interfaces of the API, which we > could then modify as needed to create a more generic template? > > This would allow forward-compatibility with any future changes to the API. > It would produce a simpler set of classes without all the loopback stuff in > there. We could still define a good set of tests based on the API, not > specific to loopback and the results it returns. This might add up to a more > straightforward developer experience. > > 2. I wasn't able to run the JUnit tests against the newly-produced > connector; does this work for others? It looks like we are missing > com.metamatrix.query.unittest.FakeMetadataFactory. Presumably this should be > brought in as part of teiid-engine-6.2.0-SNAPSHOT.jar, but I don't see it > there. Did anyone else run into this problem? > > 3. Will we make the CDK a Maven project? This seems like a standard for > all other projects in the Teiid trunk (perhaps an undocumented one). > > All in all, this is very cool stuff and I'm looking forward to using it, > thanks all! > > --Mike > > > Ramesh Reddy wrote: > > Here is the place holder I created. > http://www.jboss.org/community/wiki/TeiidConnectorDevelopmentEclipsePlugin > > You can login using the Jboss.org credentials and edit this page. Also, > if anybody else edits the page you will get notification if you > subscribe to the page. > > I have no experience with these template engines, but seems both are up > to the task. I hoping anybody else with more knowledge will chime in. > > I agree that with current requirement we may not need to go to extent of > using a template engine, where we can just get the job done using simple > token replacement on the files > > Thanks > > Ramesh.. > > On Tue, 2009-12-01 at 10:59 -0600, Sanjay Chaudhuri wrote: > > > Hi Ramesh, > > Absolutely. Let me know how to go ahead with the wiki; I mean > location, existing templates to look at, etc. > > I have looked at the eclipse core sources for the templates; it's in > line with what I did. The other template frameworks are more elaborate > substitutions;conditions, etc, which I do not think will be necessary. > You can refer to Eclipse templates here:http://www.ibm.com/developerworks/library/os-eclipse-pde/ and JET > templates here:http://www.ibm.com/developerworks/opensource/library/os-ecl-jet/. Let > me know what you think, and possible use-cases incase you want to move > forward with either one. > > There are few things left to be done, which I am planning to take up: > 1. Preference Page with installed cdk plugin location or be able to > custom it with no plugins. > 2. Wizard for output directory which will keep last few directories. > > > _______________________________________________ > teiid-dev mailing list > teiid-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/teiid-dev > > >

On Tue, 2009-12-01 at 13:49 -0800, Michael Walker wrote: > Ramesh, what's your take on providing template code vs. > auto-generating code using the standard Eclipse mechanisms, and > augmenting it as needed? As I understand even the standard Eclipse mechanisms use some kind of templates as a starting point to generate the "targets", like the ones that Sanjay mentioned earlier in the thread. When we say template code, we will put in something like public class ${name}Connector extends Connector{ public Connection getConnection(){ return new ${name}Connection(); } } which will generate code like (assumed that name of my connector is "Google") public class GoogleConnector extends Connector{ public Connection getConnection(){ return new GoogleConnection(); } } obviously, there is big task of keeping the template code in-line with Connector API/Base classes. However, if there is alternative way to keep them in sync always, I would prefer that. Do you think there is way in eclipse to accomplish this? If so, can you please share your experience. Thanks Ramesh..

I'm just referring to the "New Class" Wizard in Eclipse, which simply takes the interface in the connector API from which to start, and builds you skeleton code (screenshot below). I'm guessing there's a way to leverage this programmatically when building an Eclipse plugin? Ramesh Reddy wrote: On Tue, 2009-12-01 at 13:49 -0800, Michael Walker wrote: Ramesh, what's your take on providing template code vs. auto-generating code using the standard Eclipse mechanisms, and augmenting it as needed? As I understand even the standard Eclipse mechanisms use some kind of templates as a starting point to generate the "targets", like the ones that Sanjay mentioned earlier in the thread. When we say template code, we will put in something like public class ${name}Connector extends Connector{ public Connection getConnection(){ return new ${name}Connection(); } } which will generate code like (assumed that name of my connector is "Google") public class GoogleConnector extends Connector{ public Connection getConnection(){ return new GoogleConnection(); } } obviously, there is big task of keeping the template code in-line with Connector API/Base classes. However, if there is alternative way to keep them in sync always, I would prefer that. Do you think there is way in eclipse to accomplish this? If so, can you please share your experience. Thanks Ramesh..

On Tue, 2009-12-01 at 15:12 -0800, Michael Walker wrote: > I'm just referring to the "New Class" Wizard in Eclipse, which simply > takes the interface in the connector API from which to start, and > builds you skeleton code (screenshot below). > > I'm guessing there's a way to leverage this programmatically when > building an Eclipse plugin? But the idea here is to give user some basic required code automatically akin to "hello world". Also, this way we can make them use of some of the base classes we have written on top of the Connector API. Using like new class wizard can be done in any standard JAVA project, since this is extension plugin is a of a JAVA project you can do this anyways, at-least that is my understanding, right Sanjay? May be we can provide check box to "generate sources" on the initial wizard that will either generate from template or provide clean slate for them to start. What do you think? Ramesh..

OK, sounds good. FWIW the missing jar is teiid-engine-6.2.0-SNAPSHOT-tests.jar. Ramesh, what's your take on providing template code vs. auto-generating code using the standard Eclipse mechanisms, and augmenting it as needed? Ramesh Reddy wrote: Sanjay, Mike Currently these tests are meaningless, so I would not spend any cycles to fix it, as all of previous logic of CDK environment will go away, i.e "connector-sdk" project will be gone (possibly), and we will provide an alternate way to deploy in the real Teiid server for testing. For unit tests user can always use mock frameworks. Previously "connector-sdk" provided a sandbox environment for testing for users, which we no longer want to do. Mike: as per making this as Maven project, we will eventually get this into the JBoss Tools project if not independently serve as eclipse plugin from Teiid download site. Eclipse plugins have different build mechanisms so it would not be a good candidate. As per the generated project as Maven capable that this left out to the user as preference and their exercise for now. Ramesh.. On Tue, 2009-12-01 at 15:27 -0600, Sanjay Chaudhuri wrote: Hi Michael, Okay I verified that I had checked it and is in classpath, so there are no compilation errors. I do see JUnit fails with a java.lang.NoClassDefFoundError. I do not have the sources to figure out why it's blowing out. Let me know if you have pointers, while I try to find a reason too. Thanks Sanjay On Tue, Dec 1, 2009 at 3:08 PM, Sanjay Chaudhuri&lt;email2sanjayc(a)gmail.com&gt; <email2sanjayc(a)gmail.com&gt; wrote: Hi Michael, Using loopback classes was just a start to get the ball rolling in terms of having something. I picked that up to get started on with. It will be replaced later with more generic template which Ramesh is working on. I am not too technical with Teiid-Cdk connector internals, so will move forward with whatever serves the best use-cases from you guys. And then probably we need to use the Eclipse/JET templates engines. I remember having the same problem with compilation because could not get hold off FakeMetadataFactory. Ramesh had sent it to me; I guess I missed checking in that; will do it soon. Thanks Sanjay On Tue, Dec 1, 2009 at 2:54 PM, Michael Walker <mwalker(a)redhat.com&gt; <mwalker(a)redhat.com&gt; wrote: Cool stuff guys! I just caught up on this thread, downloaded the CDK and gave it a spin. I was able to build the basic project and produce the RAR, neat! This will be a great way to encourage custom connector development, and I intend to use it for future work. I have a few questions and thoughts about it. 1. Using the loopback connector code as the template may have some drawbacks, namely: a. If the API changes, we have to update (or re-copy) the template code (perhaps this is automated already?). b. The developer will have to remove most of the code specific to loopback, since it wouldn't be useful in any other legitimate connector. These changes will, of course, break the loopback-specific tests as well, which will also require effort to fix. This adds up to extra, unnecessary work for the developer. c. It includes lots of coding assumptions that the developer probably wouldn't want initially. For example, the developer is probably going to want all capabilities set to false initially, and will add support for capabilities and functions over time. d. It doesn't use connection pooling, which should arguably be something included in the boilerplate code (via @ConnectionPooling annotation). e. As Ramesh mentioned earlier in the thread, it generates classes called "LoopbackConnection", etc., when the developer really wants "MyCustomConnection", where MyCustom is the name of their project. As an alternative, did we consider using Eclipse's built-in mechanism for building boilerplate classes based on the interfaces of the API, which we could then modify as needed to create a more generic template? This would allow forward-compatibility with any future changes to the API. It would produce a simpler set of classes without all the loopback stuff in there. We could still define a good set of tests based on the API, not specific to loopback and the results it returns. This might add up to a more straightforward developer experience. 2. I wasn't able to run the JUnit tests against the newly-produced connector; does this work for others? It looks like we are missing com.metamatrix.query.unittest.FakeMetadataFactory. Presumably this should be brought in as part of teiid-engine-6.2.0-SNAPSHOT.jar, but I don't see it there. Did anyone else run into this problem? 3. Will we make the CDK a Maven project? This seems like a standard for all other projects in the Teiid trunk (perhaps an undocumented one). All in all, this is very cool stuff and I'm looking forward to using it, thanks all! --Mike Ramesh Reddy wrote: > > Here is the place holder I created. > > http://www.jboss.org/community/wiki/TeiidConnectorDevelopmentEclipsePlugin > > You can login using the Jboss.org credentials and edit this page. Also, > if anybody else edits the page you will get notification if you > subscribe to the page. > > I have no experience with these template engines, but seems both are up > to the task. I hoping anybody else with more knowledge will chime in. > > I agree that with current requirement we may not need to go to extent of > using a template engine, where we can just get the job done using simple > token replacement on the files > > Thanks > > Ramesh.. > > On Tue, 2009-12-01 at 10:59 -0600, Sanjay Chaudhuri wrote: > > > Hi Ramesh, > > > > Absolutely. Let me know how to go ahead with the wiki; I mean > > location, existing templates to look at, etc. > > > > I have looked at the eclipse core sources for the templates; it's in > > line with what I did. The other template frameworks are more elaborate > > substitutions;conditions, etc, which I do not think will be necessary. > > You can refer to Eclipse templates here: > > http://www.ibm.com/developerworks/library/os-eclipse-pde/ and JET > > templates here: > > http://www.ibm.com/developerworks/opensource/library/os-ecl-jet/. Let > > me know what you think, and possible use-cases incase you want to move > > forward with either one. > > > > There are few things left to be done, which I am planning to take up: > > 1. Preference Page with installed cdk plugin location or be able to > > custom it with no plugins. > > 2. Wizard for output directory which will keep last few directories. > > > _______________________________________________ > teiid-dev mailing list > teiid-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/teiid-dev