[Design of JBoss Portal] - Persistent producer registration impl
by julien@jboss.com
I am starting to implementation of the producer registration in the core module based on hibernate.
I don't understand the logic in RegistrationManagerImpl#createConsumer(String name) and RegistrationManagerImpl #addConsumerToGroupNamed(String consumerName, String groupName, ...)
In createConsumer:
1/ a consumer is created
2/ its name is used to to retrieve a group
then the created consumer is never used anymore.
I see that the method is calling public Consumer addConsumerToGroupNamed(String consumerName, String groupName, boolean createGroupIfNeeded, boolean createConsumerIfNeeded) with
addConsumerToGroupNamed(groupName, groupName, true, false);
I have a few comments on that :
1/ perhaps it should be consumer.getName() as first argument
2/ is the method addConsumerToGroupNamed able to retrieve the same consumer from only its name and not its id, or do we have an effective dual creation of a consumer ?
| String identity = policy.getConsumerIdFrom(consumerName, Collections.EMPTY_MAP));
|
I would have rather simply seen :
addConsumerToGroupNamed(consumer, groupName, true, false);
I would go even further by adding that constraint in the persistence manager and instead of having the sequence :
1/ create consumer
2/ associate it with a consumer group
change Consumer createConsumer(String id, String name) throws RegistrationException;
to Consumer createConsumer(ConsumerGroup consumerGroup, String id, String name) throws RegistrationException; to enforce by construction the fact that a consumer is attached to a group.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3992545#3992545
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3992545
18 years, 1 month
[Design of Clustering on JBoss (Clusters/JBoss)] - Re: JBAS-3864 Discussion Thread
by bstansberry@jboss.com
We accept breaking compatibility at a major release. We don't want to go crazy introducing incompatible stuff, because that does make upgrading harder. But, on the other hand, it's good to be able to use a major release to clean out old ways of doing things.
With snaphsot mode, it's borderline. The benefit of removing it from the Tomcat SAR config is not that great; mostly it just removes from the xml a bunch of complicated explanation of a feature people don't use. It also reduces coupling between the depployer and the webapp (less data needs to get passed into the webapp.) But some data (useJK) still needs to get passed, so the decoupling benefit isn't that great.
I'm inclined to remove it from the sar mostly because I don't think it's used. For example, I've never seen a forum post related to the behavior of "interval" snapshot mode.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3992540#3992540
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3992540
18 years, 1 month