December 2009 - jboss-dev-forums - Jboss List Archives

[JBoss ESB Development] - Re: Performance Improvement Prop: Cache PortReference.extend

by dward

Once again, the Subject of this post was chopped. It was supposed to read "Performance Improvement Prop: Cache PortReference.extendedToString()" View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269372#4269372 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269372

16 years, 1 month

1
0
0 / 0

[JBoss Microcontainer Development] - Re: Adding getAnnotationsAnnotatedWith() to MDR

by kabir.khan＠jboss.com

"alesj" wrote : Why would you need this? | I don't see anything similar in CachingMDC for other retrieveX methods. | The problem is that I want to only iterate over everything once, which means I have to create the annotations item myself, e.g.: | @SuppressWarnings("unchecked") | Cache<Class, AnnotationsItem> cached = cachedMetaAnnotations; | if (cached == null) | { | AnnotationsItem item = retrieveAnnotations(); | if (item.getAnnotations().length > 0) | { | Map<Class<? extends Annotation>, List<AnnotationItem<?>>> annotations = new HashMap<Class<? extends Annotation>, List<AnnotationItem<?>>>(); | for (AnnotationItem<?> annotation : item.getAnnotations()) | { | for (Annotation current : annotation.getAnnotation().annotationType().getAnnotations()) | { | List<AnnotationItem<?>> annotationsForMeta = annotations.get(current.annotationType()); | if (annotationsForMeta == null) | { | annotationsForMeta = new ArrayList<AnnotationItem<?>>(); | annotations.put(current.annotationType(), annotationsForMeta); | } | annotationsForMeta.add(annotation); | } | } | | cached = factory.createCache(Class.class, AnnotationsItem.class, getFqn()); | for (Map.Entry<Class<? extends Annotation>, List<AnnotationItem<?>>> entry : annotations.entrySet()) | { | | AnnotationsItem basic = new BasicAnnotationsItem(null, entry.getValue().toArray(new AnnotationItem<?>[entry.getValue().size()] )); | cached.put(entry.getKey(), basic); | } | } | cachedMetaAnnotations = cached; | } | return cached.get(meta); | So, I need to create the annotations item myself. If I don't pass in a loader, the BasicAnnotationsItem will fail on isCachable() since that calls the loader. This problem will also occur if when I move the pre-indexing logic into AbstractMetaDataContext. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269371#4269371 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269371

16 years, 1 month

1
0
0 / 0

[JBoss ESB Development] - Performance Improvement Prop: Cache PortReference.extendedTo

by dward

As part of the work in ActionProcessingPipeline.processPipeline(), ...esb.message.format.xml.HeaderImpl.toString() is called, which calls ...esb.addressing.Call.toString(), which calls ...esb.addressing.eprs.InVMEpr.toString(), which calls ...esb.addressing.PortReference.extendedToString(). PortReference.extendedToString() does a substantial amount of StringBuilder appending, which surprisingly accounted for 10% of the total testing time [1]. The proposed fix is to cache the extendedToString() value, being very careful to clear the cached value if any of the fields which build that value get mutated. So change this: public void setAddress(String address) { | _address = address; | } | public void addExtension(PortReference.Extension extension) { | _extensions.add(extension); | } | public void removeExtension (String tag, String value) { | _extensions.remove(new Extension(tag, XMLUtil.JBOSSESB_PREFIX, XMLUtil.JBOSSESB_NAMESPACE_URI, value)); | } | public void addExtension(String tag, String prefix, String uri, String value) { | _extensions.add(new Extension(tag, prefix, uri, value, Extension.REFERENCE_PROPERTIES)); | } | public void addExtension(String tag, String prefix, String uri, String value, int parent) { | _extensions.add(new Extension(tag, prefix, uri, value, parent)); | } | public void addExtensions(final List<Extension> extensions) { | _extensions.addAll(extensions); | } | public List<Extension> getAllExtensions() { | return _extensions; | } | public void clearExtensions() { | _extensions.clear(); | } | public String extendedToString() { | StringBuilder addr = new StringBuilder("PortReference < ").append("<").append(XMLUtil.WSA_PREFIX).append(":Address ").append(_address + "/>"); | Iterator extensions = getExtensions(); | while (extensions.hasNext()) { | Extension ext = (Extension) extensions.next(); | addr.append(", <").append(XMLUtil.WSA_PREFIX).append(":") | .append(XMLUtil.REFERENCE_PROPERTIES_TAG).append(" ").append(ext.getPrefix()) | .append(":").append(ext.getTag()).append(" : ").append(ext.getValue()).append("/>"); | } | return addr.append(" >").toString(); | } to this: public void setAddress(String address) { | synchronized (_extendedToString_LOCK) { | _address = address; | _extendedToString_CACHE = null; | } | } | public void addExtension(PortReference.Extension extension) { | synchronized (_extendedToString_LOCK) { | _extensions.add(extension); | _extendedToString_CACHE = null; | } | } | public void removeExtension (String tag, String value) { | synchronized (_extendedToString_LOCK) { | _extensions.remove(new Extension(tag, XMLUtil.JBOSSESB_PREFIX, XMLUtil.JBOSSESB_NAMESPACE_URI, value)); | _extendedToString_CACHE = null; | } | } | public void addExtension(String tag, String prefix, String uri, String value) { | synchronized (_extendedToString_LOCK) { | _extensions.add(new Extension(tag, prefix, uri, value, Extension.REFERENCE_PROPERTIES)); | _extendedToString_CACHE = null; | } | } | public void addExtension(String tag, String prefix, String uri, String value, int parent) { | synchronized (_extendedToString_LOCK) { | _extensions.add(new Extension(tag, prefix, uri, value, parent)); | _extendedToString_CACHE = null; | } | } | public void addExtensions(final List<Extension> extensions) { | synchronized (_extendedToString_LOCK) { | _extensions.addAll(extensions); | _extendedToString_CACHE = null; | } | } | public List<Extension> getAllExtensions() { | return Collections.unmodifiableList(_extensions); | } | public void clearExtensions() { | synchronized (_extendedToString_LOCK) { | _extensions.clear(); | _extendedToString_CACHE = null; | } | } | public String extendedToString() { | synchronized (_extendedToString_LOCK) { | if (_extendedToString_CACHE == null) { | StringBuilder addr = new StringBuilder("PortReference < ").append("<").append(XMLUtil.WSA_PREFIX).append(":Address ").append(_address + "/>"); | Iterator extensions = getExtensions(); | while (extensions.hasNext()) { | Extension ext = (Extension) extensions.next(); | addr.append(", <").append(XMLUtil.WSA_PREFIX).append(":") | .append(XMLUtil.REFERENCE_PROPERTIES_TAG).append(" ").append(ext.getPrefix()) | .append(":").append(ext.getTag()).append(" : ").append(ext.getValue()).append("/>"); | } | _extendedToString_CACHE = addr.append(" >").toString(); | } | return _extendedToString_CACHE; | } | } | private final Object _extendedToString_LOCK = new Object(); | private String _extendedToString_CACHE = null; Two things worth nothing: 1. We don't have to keep track of changes to each Extension object, as the only fields used in PortReference's extendedToString method are immutable. 2. synchronizing on a monitor object (_extendedToString_LOCK) is done rather than synchronizing the methods so we can be selective rather than locking the entire PortReference object. 3. Notice how getAllExtensions() protects changes to the _extensions list by now returning an unmodifiableList. I checked to make sure callers of this method never try to change the list. JProfiler proved this hotspot was reduced from 10% of the total testing time to 1.4% of the total testing time once the fix was applied. [1] Test Details: - Web Service requests through new HttpGateway to a single-action chain calling the XsltAction. - 50 client threads - each Message size is <1k Server Environment: - Sun JDK 1.5.0_22 - Fedora 11 (Linux 2.6.30.9-99.fc11.i686.PAE) - 4 gigs RAM, dual-core CPU - JBoss ESB 4.7 Client Environment: - Sun JDK 1.6.0_17 - Fedora 11 (Linux 2.6.30.9-99.fc11.i686.PAE) - 2 gigs RAM, dual-core CPU - soapUI 3.0.1 View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269370#4269370 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269370

16 years, 1 month

1
0
0 / 0

[JBoss ESB Development] - Re: Performance Improvement Proposal: Cache result of HttpSe

by Kevin.Conner＠jboss.com

The code as posted in not thread safe though, could you fix that up at the same time? Thanks, Kev View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269368#4269368 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269368

16 years, 1 month

1
0
0 / 0

[JBoss ESB Development] - Re: Performance Improvement Proposal: Cache result of HttpSe

by Kevin.Conner＠jboss.com

Good catch David. I have created https://jira.jboss.org/jira/browse/JBESB-3043 and set the fix revision to 4.7 CP1. Could you commit this into the CP branch? I'm about to create a tag on that branch, so hold off for a while. Will ping you when I am done. Thanks Kev View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269367#4269367 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269367

16 years, 1 month

1
0
0 / 0

[JBoss Microcontainer Development] - Re: Adding getAnnotationsAnnotatedWith() to MDR

by kabir.khan＠jboss.com

Actually, I see BasicAnnotationsItem already does 2b) so I'll go with that bypassing the loader: | public class CachedAnnotationsItem extends BasicAnnotationsItem | { | public CachedAnnotationsItem(AnnotationItem<? extends Annotation>[] annotationItems) | { | super(null, annotationItems); | } | | @Override | public boolean isCachable() | { | for (AnnotationItem<? extends Annotation> item : getAnnotations()) | { | if (item.isCachable() == false) | return false; | } | return true; | } | View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269366#4269366 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269366

16 years, 1 month

1
0
0 / 0

[JBoss Microcontainer Development] - Re: Adding getAnnotationsAnnotatedWith() to MDR

by alesj

Why would you need this? I don't see anything similar in CachingMDC for other retrieveX methods. All you need to do is cache the value from super. Where is super you just calculate the result every time. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269365#4269365 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269365

16 years, 1 month

1
0
0 / 0

[JBoss Microcontainer Development] - Re: Adding getAnnotationsAnnotatedWith() to MDR

by kabir.khan＠jboss.com

So the choices should be 1)Make MDR implement isCachable() as described before 2Pass in null for the loader and create a subclass of BasicAnnotationsItem that overrides isCachable() and returns a) true/false depending on if all the AnnotationItems were cachable b) true always I'll go with 2b) for now View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269364#4269364 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269364

16 years, 1 month

1
0
0 / 0

[JBoss Microcontainer Development] - Re: Adding getAnnotationsAnnotatedWith() to MDR

by kabir.khan＠jboss.com

This is the code I meant to post in my previous post, the loader is used from BasicItem | public BasicItem(MetaDataLoader loader) | { | this.loader = loader; | } | | public boolean isCachable() | { | return loader.isCachable(this); | } | | View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269362#4269362 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269362

16 years, 1 month

1
0
0 / 0

[JBoss Microcontainer Development] - Re: Adding getAnnotationsAnnotatedWith() to MDR

by kabir.khan＠jboss.com

When creating the BasicAnnotationsItem for the cache from the CachingMDC I need a reference to a MetaDataLoader which is used to determine if it is cachable: | public BasicAnnotationItem(MetaDataLoader loader, T annotation) | { | super(loader, annotation.annotationType().getName(), annotation); | } | | public T getAnnotation() | { | return getValue(); | } | CachingMDC does not implement MetaDataLoader so I can't pass in 'this'. My current ideas are either: -make CachingMDC implement MDL and always return true from isCachable() -create a MDL implementation that returns true if all the AnnotationItems are cachable, otherwise return false. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4269360#4269360 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4269360

16 years, 1 month

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums December 2009