August 2006 - jboss-dev-forums - Jboss List Archives

[Design the new POJO MicroContainer] - Re: Bean property inspection and actual injection

by alesj

"adrian(a)jboss.org" wrote : What were you trying to fix here? | | This breaks the validate() method and makes it impossible | to retrieve the error that occurred since the installed context | no longer exists. (The controller has lost all reference to it). When I was running my tests - when my bean threw a throwable - due to multiple matching beans - which was my expected exception. Even after I undeployed this 'multiple matching beans' test deployment that 'failed', my next deployment threw an exception saying that context with this name already existed. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965223#3965223 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965223

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean property inspection and actual injection

by adrian＠jboss.org

What were you trying to fix here? | Author: alesj | Date: 2006-08-13 12:26:29 -0400 (Sun, 13 Aug 2006) | New Revision: 55853 | | Modified: | projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins/AbstractController.java | projects/microcontainer/trunk/kernel/src/tests/org/jboss/test/kernel/inject/test/PropertyContextualInjectionTestCase.java | Log: | AbstractController.allContexts.remove after failure in confiruration phase. | Added NullName expected throwable. | | Modified: projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins/AbstractController.java | =================================================================== | --- projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins/AbstractController.java 2006-08-13 15:45:00 UTC (rev 55852) | +++ projects/microcontainer/trunk/dependency/src/main/org/jboss/dependency/plugins/AbstractController.java 2006-08-13 16:26:29 UTC (rev 55853) | @@ -443,6 +443,7 @@ | { | log.error("Error installing to " + toState.getStateString() + ": " + context.toShortString(), error); | uninstallContext(context, ControllerState.NOT_INSTALLED, trace); | + allContexts.remove(context.getName()); //missing if contexts failes during configuration phase | errorContexts.add(context); | context.setError(error); | return false; | This breaks the validate() method and makes it impossible to retrieve the error that occurred since the installed context no longer exists. (The controller has lost all reference to it). View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965221#3965221 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965221

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean property inspection and actual injection

by adrian＠jboss.org

"alesj" wrote : | I'm about to write bean class inspection for property @Inject - which will take place in DescribeAction - and will add PropertyMetaData to existing BeanMetaData (as discused). | | Should I wait for 'I do intend in future to define a proper contract'? | No since I've got no idea what that contract is, except that it is a generalization of all the inject/depends/demands such that a specific dependency type can be "plugged in" without having to modify the kernel. e.g. pseudo idea | <register dependency="JNDI"> | <.../> <!-- description of dependency mechanism> | </register> | | <inject bean="Blah" type="JNDI"/> | anonymous wrote : | How to make this more general - handling all kinds of annotations, different injections (not just property, also constructor, collections, ...)? Again, I haven't given any thought to it. You can certainly use parameter annotations to describe parameter injections. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965219#3965219 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965219

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean instantiate order with contextual injection

by adrian＠jboss.org

"alesj" wrote : | Crawl back all to the constructorMD / parameterMD for some info which will help me in 'placeholder' dependency item? These should be available in the MetaDataVisitor. i.e. create a "stack" of previously visited objects in the branch, so in the case above you would have: BeanMetaData ConstructorMetaData ParameterMetaData ArrayMetaData in the "stack". View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965217#3965217 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965217

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean instantiate order with contextual injection

by adrian＠jboss.org

"alesj" wrote : | How to get to class in different parameter injection cases: | | | | <bean name="parameterObject1" class="org.jboss.test.kernel.inject.support.ParameterTestObject"> | | <constructor> | | <parameter><array><inject/></array></parameter> | | </constructor> | | </bean> | | | | Crawl back all to the constructorMD / parameterMD for some info which will help me in 'placeholder' dependency item? That is more difficult. The current way it works is based on the injected type deciding which method/constructor gets used (by matching the passed types to the parameter types). What you are trying to do is the reverse which currently has no infrastructure to support it. It is also an unsolvable problem in general: e.g. | public class MyClass | { | public MyClass(Type1 type1) {} | public MyClass(Type2 type2) {} | } | Which type should I use Type1 or Type2? The only way to resolve it would be: | <parameter class="Type1"><inject/></parameter> | View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965216#3965216 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965216

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean property inspection and actual injection

by alesj

"alesj" wrote : | How to make this more general - handling all kinds of annotations, different injections (not just property, also constructor, collections, ...)? Sort of BeanAnnotationBinding? Stumbling upon annotation - get the right AnnotationHandler, which can handle property MD creation, constructor MD creation, parameter MD, .... ? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965214#3965214 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965214

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean instantiate order with contextual injection

by adrian＠jboss.org

Nope. It is still broken. You should not modify the BeanMetaData inside the Kernel. This is a representation of what the user wants. What you have done is added a reference to the class in the SuppliesMetaData which once the bean gets uninstalled will cause a memory leak. UninstalledBeanMetaData (waiting to get reinstalled) -> SuppliesMetaData -> Class -> ClassLoader (that is supposed to be garbage collected). I don't even see why you are doing this? All you need to do is to modify the kernel registry plugin entry point getEntry() to use your contextsByClass. http://docs.jboss.org/nightly/microkernel/docs/reference/en/html/registry... Did you try running the full testsuite? org.jboss.test.KernelAllTestSuite. or from the command line ./build.sh -f build-test.xml tests There are currently 38 failures and 1 error. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965213#3965213 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965213

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean property inspection and actual injection

by alesj

"adrian(a)jboss.org" wrote : | With the annotation approach it is your job to create/add an ADVM to the metadata. | | I do intend in future to define a proper contract | such that you can more easily "write your own dependency". | See other threads in this forum. | I'm about to write bean class inspection for property @Inject - which will take place in DescribeAction - and will add PropertyMetaData to existing BeanMetaData (as discused). Should I wait for 'I do intend in future to define a proper contract'? How to make this more general - handling all kinds of annotations, different injections (not just property, also constructor, collections, ...)? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965211#3965211 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965211

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean instantiate order with contextual injection

by alesj

"adrian(a)jboss.org" wrote : I don't understand? | | It should fail if the inject cannot find a target. | | When it works, it should look like this: | (C1) Context1: Your bean above | (C2) Context2: Implements the class | | C1: preprocess/Describe - we need somebody to implement the parameter class | C2: .../Instantiate/etc. - I implement it | C1: Can now proceed to instantiation using C2 as the iDependOn | | If there is no C2, then it is an error. Ok, this is written for property case - and is already commited. In property case I can later (still in describe state) get the actual property class type. How to get to class in different parameter injection cases: | <bean name="parameterObject1" class="org.jboss.test.kernel.inject.support.ParameterTestObject"> | <constructor> | <parameter><array><inject/></array></parameter> | </constructor> | </bean> | Crawl back all to the constructorMD / parameterMD for some info which will help me in 'placeholder' dependency item? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965208#3965208 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965208

19 years, 7 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Bean instantiate order with contextual injection

by adrian＠jboss.org

I don't understand? It should fail if the inject cannot find a target. When it works, it should look like this: (C1) Context1: Your bean above (C2) Context2: Implements the class C1: preprocess/Describe - we need somebody to implement the parameter class C2: .../Instantiate/etc. - I implement it C1: Can now proceed to instantiation using C2 as the iDependOn If there is no C2, then it is an error. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3965205#3965205 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3965205

19 years, 7 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums August 2006