[Design of POJO Server] - Re: JavaEE Deployers need redoing again
by scott.stark@jboss.org
"adrian(a)jboss.org" wrote :
| I don't know why standardjboss.xml has to be an attachment. A single
| deployer that does both the parsing (during bootstrap) and merge
| would suffice.
| It should be after all the other mechanisms to create ejb deployment metadata
| including the annotation build.
|
It could be moved into the MergedJBossMetaDataDeployer.
"adrian(a)jboss.org" wrote :
| 2) MISUSE OF createMetaData()
|
| JBossAppParsingDeployer does ...
|
| This processing should be in a seperate deployer it is not parsing work.
|
| I want to kill the allowReparse() option once we have the parsing
| deployers that can parse multiple metadata files.
|
"adrian(a)jboss.org" wrote :
| 3) AbstractVFSRealDeployer is deprecated
|
| Anything that is not following the deployer model and is accessing the
| VFS/ deployer structure in undefined ways should extend this deprecated deployer.
|
| It means we haven't thought hard enough about how to include what is
| going on in the deployer model and we need to come up with some abstraction
| such that it can be done safely and others can share the working code.
|
| AnnotationMetaDataDeployer does not extend the class, ...
|
Obtaining the annotations that affect deployment is a basic feature of deployment that needs to be supported.
"adrian(a)jboss.org" wrote :
| 4) Scalability and error proneness
|
| AnnotationMetaDataDeployer has this horrible code:
| ...
| a) There is no way to add new deployment types.
| e.g. Where do I include aop checking for isMetadataComplete()
| and looking at the classes as they are visited?
|
| b) Where I do add/modify the processors either for my own custom
| annotations that create metadata or to replace a buggy processor
| to fix a problem?
|
Currently the annotation to metadata processors require the root classes to build the associated metadata structure. It cannot be integrated into a visitor pattern. Whether this becomes an extensible annotation based deployer, or deployers for each deployment type is added is the question. We need better support for annotations in the base deployment layers.
"adrian(a)jboss.org" wrote :
| 6) PostClassLoader
|
| If we need a seperate stage before the REAL deployers to analyse the whole
| deployment, we should define a new stage, e.g. PRE-REAL or something.
| This would also be the point where add dependencies to the REAL
| stage of a deployment for things like ejb-ref dependencies.
|
Yes, we need this stage.
"adrian(a)jboss.org" wrote :
| GOING FORWARD:
| I'd like to fix all this, but I guess it is too close to Beta3.
| Instead this is something I'm going to work on for RC1 once Beta3 is out.
|
| One thing this does show is that we really need some tests that
| simulate what the profile service is going to do when it is fully up and running.
| i.e. programmatic deployments from the modifications of the attachments
| created from an initial deployment.
| I'm pretty sure this is all broken with the current state of the deployers. :-(
|
Yes, the current deployment tests in the mc are way too simple. We need tests that exercise deployers at every stage.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4110292#4110292
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4110292
18 years, 1 month
[Design of AOP on JBoss (Aspects/JBoss)] - Security errors with maven tests
by pgier
I'm working on completing the maven migration for aop and I'm getting some errors when running the unit tests. I thought I would ask here before spending too much time trying to figure it out.
| Testcase: testSubSuperOnlyMetadata took 0.458 sec
| Testcase: testSubSubSuperOnlyMetadata took 0.008 sec
| Caused an ERROR
| null
| java.lang.reflect.InvocationTargetException
| at org.jboss.test.AbstractTestDelegate.getDelegate(AbstractTestDelegate.java:73)
| at org.jboss.test.AbstractTestSetup.setUp(AbstractTestSetup.java:62)
| at org.jboss.test.AbstractTestCaseWithSetup.setUp(AbstractTestCaseWithSetup.java:103)
| Caused by: java.security.AccessControlException: access denied (java.util.PropertyPermission * read,write)
| at java.security.AccessControlContext.checkPermission(AccessControlContext.java:264)
| at java.security.AccessController.checkPermission(AccessController.java:427)
| at java.lang.SecurityManager.checkPermission(SecurityManager.java:532)
| at java.lang.SecurityManager.checkPropertiesAccess(SecurityManager.java:1252)
| at java.lang.System.getProperties(System.java:561)
| at org.jboss.test.aop.AOPTestDelegate$1.run(AOPTestDelegate.java:51)
| at org.jboss.test.aop.AOPTestDelegate$1.run(AOPTestDelegate.java:49)
| at java.security.AccessController.doPrivileged(Native Method)
| at org.jboss.test.aop.AOPTestDelegate.<init>(AOPTestDelegate.java:47)
| at org.jboss.test.aop.AOPTestWithSetup.getDelegate(AOPTestWithSetup.java:53)
| ... 19 more
|
Any ideas why I'm getting these security errors running the tests with maven but not with ant?
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4110271#4110271
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4110271
18 years, 1 month
[Design of Messaging on JBoss (Messaging/JBoss)] - Re: NPEs are not acceptable error messages
by adrian@jboss.org
"adrian(a)jboss.org" wrote : Then when you shutdown the server you get all sorts of NPEs.
|
Although it looks like I just fixed this problem by fixing the test to undeploy
the test queues/topics. Try reverting my fix to see the issue,
since there is obviously some problem here:
| [ejort@warjort testsuite]$ svn diff
| Index: src/main/org/jboss/test/mdb/test/MDBUnitTestCase.java
| ===================================================================
| --- src/main/org/jboss/test/mdb/test/MDBUnitTestCase.java (revision 67850)
| +++ src/main/org/jboss/test/mdb/test/MDBUnitTestCase.java (working copy)
| @@ -291,27 +291,53 @@
| "jboss.messaging.destination:service=Queue,name=DLQ"),
| "removeAllMessages", new Object[0], new String[0]);
| }
| - catch (Exception e)
| + catch (Exception ignored)
| {
| - e.printStackTrace();
| + getLog().warn("unable to clear dlq", ignored);
| }
|
| ClassLoader loader = Thread.currentThread().getContextClassLoader();
| - undeploy("mdb.jar");
| + try
| + {
| + undeploy("mdb.jar");
| + }
| + catch (Exception ignored)
| + {
| + getLog().warn("Unable to undeploy mdb.jar", ignored);
| + }
|
| - // Remove the durable subscription
| - TopicConnectionFactory topicFactory = (TopicConnectionFactory) getInitialContext()
| - .lookup(TOPIC_FACTORY);
| - TopicConnection topicConnection = topicFactory
| - .createTopicConnection("john", "needle");
| - TopicSession session = topicConnection.createTopicSession(false,
| - Session.AUTO_ACKNOWLEDGE);
| - session.unsubscribe("DurableSubscriberExample");
| - topicConnection.close();
| + try
| + {
| + // Remove the durable subscription
| + TopicConnectionFactory topicFactory = (TopicConnectionFactory) getInitialContext()
| + .lookup(TOPIC_FACTORY);
| + TopicConnection topicConnection = topicFactory
| + .createTopicConnection("john", "needle");
| + try
| + {
| + TopicSession session = topicConnection.createTopicSession(false,
| + Session.AUTO_ACKNOWLEDGE);
| + session.unsubscribe("DurableSubscriberExample");
| + }
| + finally
| + {
| + topicConnection.close();
| + }
| + }
| + catch (Exception ignored)
| + {
| + getLog().warn("Unable to unsubscribe", ignored);
| + }
|
| - undeploy(loader.getResource(
| + try
| + {
| + undeploy(loader.getResource(
| "messaging/test-destinations-full-service.xml").toString());
| -
| + }
| + catch (Exception ignored)
| + {
| + getLog().warn("Unable to remove destinations", ignored);
| + }
| }
| };
|
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4110270#4110270
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4110270
18 years, 1 month
[Design of Messaging on JBoss (Messaging/JBoss)] - Re: NPEs are not acceptable error messages
by adrian@jboss.org
Then when you shutdown the server you get all sorts of NPEs.
anonymous wrote :
| 17:55:49,665 INFO [ServerImpl] Runtime shutdown hook called, forceHalt: true
| 17:55:49,695 INFO [QueueService] Queue[/queue/ExpiryQueue] stopped
| 17:55:49,697 INFO [QueueService] Queue[/queue/DLQ] stopped
| 17:55:49,701 INFO [TomcatDeployment] undeploy, ctxPath=/invoker, vfsUrl=http-invoker.sar/invoker.war
| 17:55:49,962 INFO [ConnectionFactoryBindingService] Unbound ConnectionManager 'jboss.jca:service=ConnectionFactoryBinding,name=JmsXA' from JNDI name 'java:JmsXA'
| 17:55:49,963 INFO [ConnectionFactory] org.jboss.jms.server.connectionfactory.ConnectionFactory@1e54e00 undeployed
| 17:55:49,963 INFO [ConnectionFactory] org.jboss.jms.server.connectionfactory.ConnectionFactory@14c71b1 undeployed
| 17:55:49,964 INFO [ConnectionFactory] org.jboss.jms.server.connectionfactory.ConnectionFactory@13f7cd2 undeployed
| 17:55:49,965 ERROR [ExceptionUtil] Topic[/topic/testTopic] stopService
| java.lang.NullPointerException
| at org.jboss.messaging.core.impl.postoffice.MessagingPostOffice.getQueuesForCondition(MessagingPostOffice.java:510)
| at org.jboss.jms.server.destination.TopicService.stopService(TopicService.java:138)
|
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4110267#4110267
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4110267
18 years, 1 month