February 2008 - jboss-dev-forums - Jboss List Archives

[Design of Messaging on JBoss (Messaging/JBoss)] - Problem in shutdown of JBoss AS 'all' config

by bstansberry＠jboss.com

There's a problem in the JBM shutdown in the AS 'all' config. Basically, the shutdown calls *synchronized* MessagingPostOffice.stop(). That calls channel.close(), which results in a callback from a JGroups thread on the viewAccepted() callback. That tries to call into *synchronized* MessagingPostOffice.calculateFailoverMap(). This basically "deadlocks" until the shutdown thread times out waiting for the view dissemination process to complete: 2008-02-05 11:49:30,201 WARN [org.jgroups.mux.Multiplexer] failed to collect all service ACKs (1) for [dst: , src: 10.18.86.175:39649 (4 headers), size=0 bytes] after 2000ms, missing ACKs from [10.18.86.175:39649] (received=[]), local_addr=10.18.86.175:39649 At that point the shutdown thread is free to continue executing stop(), and ends up setting MessagingPostOffice.failoverMap to null. It then returns from stop(), freeing the JGroups thread to enter calculateFailoverMap(). NPE due to failoverMap being null: 2008-02-05 11:49:41,515 ERROR [org.jboss.messaging.core.impl.postoffice.GroupMember] Caught Exception in MembershipListener java.lang.NullPointerException at org.jboss.messaging.core.impl.postoffice.MessagingPostOffice.calculateFailoverMap(MessagingPostOffice.java:1939) at org.jboss.messaging.core.impl.postoffice.MessagingPostOffice.nodesLeft(MessagingPostOffice.java:899) at org.jboss.messaging.core.impl.postoffice.GroupMember$ControlMembershipListener.viewAccepted(GroupMember.java:498) at org.jgroups.blocks.MessageDispatcher$ProtocolAdapter.handleUpEvent(MessageDispatcher.java:704) at org.jgroups.blocks.MessageDispatcher$ProtocolAdapter.up(MessageDispatcher.java:747) at org.jgroups.JChannel.up(JChannel.java:1151) at org.jgroups.mux.Multiplexer.passToMuxChannel(Multiplexer.java:990) at org.jgroups.mux.Multiplexer.handleServiceDown(Multiplexer.java:783) at org.jgroups.mux.Multiplexer.handleServiceMessage(Multiplexer.java:715) at org.jgroups.mux.Multiplexer.up(Multiplexer.java:267) at org.jgroups.JChannel.up(JChannel.java:1151) Bela/Vladimir, I thought you'd fixed things so a MuxChannel user wouldn't get a viewAccepted() callback when closing its channel. You don't get one when closing a regular JChannel. Perhaps my memory is faulty. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126874#4126874 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126874

18 years, 2 months

1
0
0 / 0

[Design of JBossCache] - Re: Amazon S3 cache loader

by genman

I committed. I'm not sure on the package/artifact naming, as it's really JBoss's version of the Amazon access classes. I'm pretty sure, though, it doesn't belong under com.amazon as I changed the "free" library quite a bit. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126856#4126856 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126856

18 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Using a CompositeMetaType for a Map with String keys?

by scott.stark＠jboss.org

Our metatype/values initially mirrored the jmx opentype stuff, so that is where the CompositeMetaType, TableMetaType come from. A map of string keys with metavalues is no different than a javabean of property names to values, so that type of map should have a CompositeMetaType representation. I'm testing a MapCompositeValueSupport impl as part of the ds property fixing. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126854#4126854 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126854

18 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Using a CompositeMetaType for a Map with String keys?

by alesj

"bytor99999" wrote : Sure, just blame Adrian, that always works. ;) | Yeah, the easy way out. :-) But I could also blame it on you guys, for 'sleeping' for so long. ;-) "bytor99999" wrote : | I think a TableMetaType/TableValue would be overkill for such a simple Map. I think the Table type/value is more for when you have rows of "records" where each row can be a totally different set of "columns". Now where that would come into play and be used is beyond me. OK, I have no problem supporting something simpler, e.g. Scott's MapValueSupport . But let the initial implementor speak. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126851#4126851 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126851

18 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Using a CompositeMetaType for a Map with String keys?

by bytor99999

Sure, just blame Adrian, that always works. ;) I think a TableMetaType/TableValue would be overkill for such a simple Map. I think the Table type/value is more for when you have rows of "records" where each row can be a totally different set of "columns". Now where that would come into play and be used is beyond me. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126845#4126845 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126845

18 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: FileStructure and FileMatcher

by alesj

I can make this happen for CR1. Integrating this with deployers tests that've already promised. ;-) Can you create a JIRA issue? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126843#4126843 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126843

18 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Using a CompositeMetaType for a Map with String keys?

by alesj

I was just following Adrian's previous work. Previous as in MC and AS5 trunk on mbeans module. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126839#4126839 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126839

18 years, 2 months

1
0
0 / 0

[Design of POJO Server] - Re: Datasource Connection Properties using CollectionMetaTyp

by bytor99999

I understand what you mean. Because the only way to actually get the KeySet of the underlying Map is through the Type object, which can't be done with an open ended type property Unless you add the key via MutableCompositeMetaType.addItem(String itemName, String itemDescription, MetaType itemType) I am not so against having to do that process. If that is what it takes to make it general purpose. I can also see how you can get the basic information you need for addItem (except for the itemDescription) from the set(String key, MetaValue value) I would like to avoid the Table types. They seem overkill for configuration properties. They could probably hold the entire set of DS properties within that one Value type object. :) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126837#4126837 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126837

18 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Using a CompositeMetaType for a Map with String keys?

by scott.stark＠jboss.org

Right now MetaTypeFactory.resolve(Map[String,?].class) returns a TableMetaType. It seems more natural for this to be a CompositeMetaType that does not restrict the item names when the Map has String keys, for example: | MutableCompositeMetaType expected = new MutableCompositeMetaType(HashMap.class.getName(), "HashMap<String,String>"); | expected.addItem("key1", "key1", SimpleMetaType.STRING); | expected.addItem("key2", "key2", SimpleMetaType.STRING); | expected.addItem("key3", "key3", SimpleMetaType.STRING); | expected.freeze(); | | String[] itemNames = {"key1", "key2", "key3"}; | MetaValue[] itemValues = {SimpleValueSupport.wrap("value1"), SimpleValueSupport.wrap("value3"), SimpleValueSupport.wrap("value3")}; | CompositeValueSupport mapValue = new CompositeValueSupport(expected, itemNames, itemValues); | MetaValue value1 = mapValue.get("key1"); | A new MapValueSupport could implement this type of CompositeValue. The TableMetaType/TableValue seem very awkward for this type of map. Is there a reason not to support this and require all Maps to be TableMetaType/TableValue? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126829#4126829 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126829

18 years, 2 months

1
0
0 / 0

[Design of POJO Server] - Re: Datasource Connection Properties using CollectionMetaTyp

by scott.stark＠jboss.org

There should be open ended versions of CompositeMetaType/CompositeValue, but currently it looks a little cumbersome. You would have to use a MutableCompositeMetaType implementation of CompositeMetaType, and use MutableCompositeMetaType.addItem(String itemName, String itemDescription, MetaType itemType) before calling CompositeValueSupport.set(String key, MetaValue value). This should really be internalized in the CompositeValueSupport.set method for MutableCompositeMetaTypes I believe. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4126789#4126789 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4126789

18 years, 2 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums February 2008