[Design of POJO Server] - Re: @JMX on a bootstrap service
by adrian@jboss.org
I've fixed this and also removed the potential memory leak
by adding a CachingAnnotationMetaData interface.
It's not as optimal as I would like because of the property annotations.
In that case the annotation gets added to both the getter and setter,
so when we remove the annoation for the getter we loose track of the
annotation when we want to remove the setter, so we have to reconstruct it.
If this was a way to optimize that case, the code in KernelScopeInfo could be
| Annotation annotationInstance = null;
| if (annotation instanceof CachingAnnotationMetaData)
| annotationInstance = ((CachingAnnotationMetaData) annotation).removeAnnotation();
| - if (annotationInstance == null)
| + else
| annotationInstance = annotation.getAnnotationInstance(classloader);
| // Null means we never constructed it in the first place
| if (annotationInstance != null)
| mutable.removeAnnotation(annotationInstance.annotationType());
|
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4170555#4170555
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4170555
17 years, 7 months
[Design of JBossCache] - Re: Eviction redesign
by manik.surtani@jboss.com
"mircea.markus" wrote : anonymous wrote : Perhaps a different name for "EvictionPolicy", maybe "EvictionActionPolicy" or something. Using the same term for a different thing will be confusing.
| I think that the Policy and Algorithm are a not very meaningful terms for describing the responsibility of these classes; also the terms overlap. What about some other names?
| anonymous wrote : EvictionAlgorithm - how are nodes selected for eviction
| EvictionOrderingPolicy
| anonymous wrote : EvictionPolicy - what happens when nodes are evicted
| +1 for EvictionActionPolicy
I agree that EvictionPolicy is too abstract/too much of a catch-all to be meaningful, but I think EvictionAlgorithm is pretty clear and makes sense. EvictionOrderingPolicy isn't quite right either since the algo doesn't exactly order stuff, but selects stuff for eviction. Perhaps EvictionSelectionAlgorithm if you think EvictionAlgorithm is too general.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4170494#4170494
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4170494
17 years, 7 months