[Design of AOP on JBoss (Aspects/JBoss)] - Re: Reimplementing AspectManager/Domains to understand jboss
by adrian@jboss.org
I'm not following what problem you are trying to solve?
If a class isn't visible using the classloader rules then you shouldn't be able
to use AOP to change that.
e.g. In your final comment where you want a "global" aspect definition then
the deployments that want to use it would need to "import" the classloader
where those aspects are deployed.
I thought the issue for you was just how you attach the aop domains to the
shared classloader spaces (either the old import-all rules or imports).
Doesn't the getClassLoaderFor() stuff solve this?
if the issue is mainly an ease-of-use thing, i.e. allowing people to share
config where part of the config contains classes that are not visible but are
irrelevant then that's really your choice.
e.g. Do you still allow this to work where pkg.a is invisible.
You could ignore the fact that PojoA cannot be loaded from a deployment because
it is not relevant to an application using pkg.b?
| <bind pointcut="all(pkg.a.PojoA) OR all(pkg.b.PojoB)">
| <interceptor name="pkg.b.MyInterceptor"/>
| </bind>
|
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4220274#4220274
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4220274
17 years
[Design of AOP on JBoss (Aspects/JBoss)] - Re: Reimplementing AspectManager/Domains to understand jboss
by kabir.khan@jboss.com
Coming back to this IV is not a good solution. As far as I can tell it means that you can never have "external" aspects (aspects in packages not declared in the loaders import or the loader itself) applied to classes in classloaders using importAll=false. I think we need a way to make it possible to have aspects deployed globally and applied to loaders using importAll=false, but maybe in reality it isn't as important as I think?
I'm just thinking loud, hopefully that will help me organise my thoughts later...
A simple solution would be to include the packages of aspects that might be applied in the target classloader's optional imports. But that might be a step in the wrong direction, limiting the scope of dynamic aop?
For II and III we need some way to identify classloaders that contain aspects. That could be done if we make it a requirement that aspects which should apply to more than one deployment are deployed in a top-level .aop archive. Nested .aop archives could only apply to that deployment if import/export is used, but again the bindings contained in its jboss-aop.xml might be referencing aspects from outside that loader?
If we have a way to identify aspect deployments something needs doing to make the classes globally visible within the domain. A few initial ideas:
-Have "special" classloaders within the domain for aspects which are checked even by classloaders using importAll=false
-Have AOP stuff deployed in a parent domain (if this is actually checked when importAll=false) of the real domain, something like:
| AOPDefaultDomain
| DefaultDomain
| AOPChildDomain1
| ChildDomain1
| AOPChildDomain2
| ChildDomain2
|
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4220270#4220270
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4220270
17 years
[Design of Messaging on JBoss (Messaging/JBoss)] - Remaining EasyMock tests
by ataylor
The following EasyMock tests are remaining. Before I just delete these ones i thought we should double check them. there are.
Deployer tests. I'm refactoring these into proper unit tests.
Journal/paging/persistence tests. Clebert, could you verify that these tests are now covered in the integration tests or elsewhere? Also PagingStoreTestBase is extended by an integration test which is probably wrong.
PostOffice tests, these are mainly routing tests. I'll make sure that these are covered in the integration tests and add if not.
Remoting/netty tests. Remoting is covered by default by any of the integration tests. Netty has some basic core client tests whcih should be enough, so I'll delete..
Server. There is a QueueFActoryTest that I'll convert. Theres also a QueueImplTest and a MessageReferenceImplTest that I'm not sure are covered or not??
After that there are some timing tests that I'll deal with separately.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4220238#4220238
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4220238
17 years
[Design of JBoss Portal] - Re: Where to put images ?
by apemberton
When it comes to packaging images, css, and other static resources for portal development, you basically have two choices: a) package the resources inside your portlet WAR or b) package the resources inside your theme.
It looks like you want to use option a above and the problem you're having is that you're not referencing the context path of your portlet to retrieve the resources you've placed there. Using your example, you'd want to reference:
<img src="${renderRequest.contextPath}/images/iconCalendar.gif" />
Option b, placing resources in your theme, may make better sense in your scenario; it should be used when the resources you need to access may be used across portlets. I typically place all CSS inside my theme, to promote reuse of styles.
Good luck!
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4220232#4220232
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4220232
17 years