[Design of Messaging on JBoss (Messaging/JBoss)] - Re: SecurityChecks on Sends (AsyncSend & createProducer)
by ataylor
anonymous wrote : First: createProducer doesn't do any security checks, as there is nothing being created on Server for a producer, but shouldn't we do a round-trip just to validate security?
I don't think so, firstly the producer may be anonymous and since the checks are done by address you couldn't do it anyway. secondly, If you did do security checks there would be no point in checking on send. Lastly,
anonymous wrote : Say you are sending messages (Asynchronously), and you don't have sending permissions... (or you lost permissions after the createProducer). The serverSide will ignore the sends and will only log those errors.
I think thats ok, as long as its logged and if the user wants they can send blocking.
anonymous wrote : Shouldn't we save exceptions on Async operations, so the next time a Sync operation come (commit, prepare, close) we throw the pending exceptions?
i'm not sure that is a good idea. what if the next sync call was creating a consumer, it wouldn't make sense to throw an exception for a previous send. We probably should mark a tx as rollback only tho', which I'm not sure we do.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4222230#4222230
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4222230
15 years
[Design of Messaging on JBoss (Messaging/JBoss)] - Re: JBM 2.0 examples
by timfox
Howard - good start...
Some initial comments:
1) Can you add them to the eclipse project (I assume you use eclipse) so we can browse them?
2) Each example needs a readme, structured in a standard way. We should create a template for this.
Each readme.html should be formatted and written as simply and clearly as possible on a single page if possible.
I suggest the following sections:
a) Name of example
b) Short description of example, e.g. This example demonstrates usage of a JMS durable subscription. Durable subscriptions are used when you wish to persist... blah blah blah. In this example you will create a durable subscription, send some messages to, consume some mesages, then close the subscriber, more messages will be sent when the subscriber is not connected, demonstrating the durable subscription's ability to collect messages when there is no subscriber. Then we demonstrate the subscriber reconnecting, and finally deleting the durable subscription. etc
(btw don't copy the above it was just an illustration)
c) Step by step of example
step 1, first we create the durable subscription, blah blah
step 2, now we send some messages
etc
each step should correspond to comments in the source code with the same step numbers.
There should also be more comments in the source.
Also the transactional example doesn't really demonstrate transactions - it just sends and consumes a single message so transactions are of no use. For a transaction example you should be sending multiple messages and stressing the point that the unit is atomic, also demonstrating rollback and how redelivery occurs on rollback.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4222226#4222226
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4222226
15 years
[Design of Messaging on JBoss (Messaging/JBoss)] - Excluded failover tests
by timfox
I was puzzled that the failover tests weren't running on Hudson. On investigation I found this, committed about a week ago:
| Modified: trunk/build-messaging.xml
| ===================================================================
| --- trunk/build-messaging.xml 2009-03-23 16:02:12 UTC (rev 6142)
| +++ trunk/build-messaging.xml 2009-03-23 16:10:07 UTC (rev 6143)
| @@ -1145,7 +1145,7 @@
| <antcall inheritall="true" inheritrefs="true" target="tests">
| <param name="tests.param" value="**/org/jboss/messaging/tests/unit/**/*${test-mask}.class"/>
| <!-- if tests.validate.error is defined, it will fail the build in case of any test failure -->
| - <param name="tests.validate.error" value="Defined!"/>
| + <!-- <param name="tests.validate.error" value="Defined!"/> -->
| </antcall>
| </target>
|
| @@ -1191,7 +1191,7 @@
| <formatter type="plain" usefile="${junit.formatter.usefile}"/>
| <fileset dir="${test.classes.dir}">
| <include name="${tests.param}"/>
| - <exclude name="**/LargeMessageMultiThreadFailoverTest.class" />
| + <exclude name="**/*Failover*.class" />
| </fileset>
| </batchtest>
| </junit>
|
:(
Please guys, be more careful. We have had too many cases of comment out tests/exclusions/other stuff making it into svn from your local workspaces.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4222219#4222219
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4222219
15 years