[Design of Management Features on JBoss] - Re: Applying persisted changes.
by emuckenhuber
"scott.stark(a)jboss.org" wrote :
| I don't understand why the ManagedObjectBuilder for the destination class is not seen. I'll try to look into why that is.
|
Looks like the MODefinitions are getting installed too late (as they are in deploy/messaging).
Moving those definitions to deployers/ seems to work, although in the end this should not be needed?
"scott.stark(a)jboss.org" wrote :
| Ok, I see. We need to move the managed object factory extension behavior out of the deployers. I'll start looking at that.
|
I think that will simplify things for the attachment persistence.
Last week i was briefly looking into something similar. It's basically not that obvious, as IMHO parts of what ServiceMetaDataICF and BeanMetaDataICF are doing should be moved out.
On the other hand looking at the connection factory ICFs - those actually only do operations on the ConnectionFactoryMetaData itself, which should be fine.
So i think that one of the goals should be to have a clearer separation between the metaData operations and the extension behavior.
Although refactoring ICFs totally out of this process could be quite hard. Maybe creating something new but similar for the extension behavior could be easier?
Leaving the meta data operations in the responsablitly of the ICFs (setValue, getValue). On top of that the extension behavior like overriding the moClass, getting the values from the MBeanServer or the MCBean... Also adding and creating a new attribute to the meta data e.g. ServiceAttributeMD could be done by the extensions.
Is similar to what you have in mind?
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4225602#4225602
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4225602
16 years, 11 months
[Design of Management Features on JBoss] - Re: Applying persisted changes.
by scott.stark@jboss.org
"emuckenhuber" wrote : One of the failures i mentioned was about restoring JMS destinations. The updates does not work
| when the ManagedObjectClass(..) is not present in the deployment descriptor.
| So the tests with this annotation element are passing, the one without is failing.
|
I don't understand why the ManagedObjectBuilder for the destination class is not seen. I'll try to look into why that is.
"emuckenhuber" wrote :
| One other problem i think we could have is that ManagedObjectFactory.initMO does not create the same output, as ManagementView (as this would require e.g. KernelDeploymentManagedObjectCreator)
|
| Additionally the failures which can be seen during the bootstrap (https://jira.jboss.org/jira/browse/JBAS-6524)
| seem also somehow related to this - as when processing the collection in the ManagedObjectFactory,
| does not have access to the ComponentDeploymentContext.getMetaData() for each bean.
| Not really sure about this, as it's been a while since i last looked into this.
|
| So the main issue with that is when restoring the persisted information it is (of course) relying on the same ManagedObject structure as it was persisted before. Only the values are getting persisted and restored (which makes sense, as the metaType should not change)
|
| Therefore i think that this kind of 'override' done by the InstanceClassFactories (getManagedObjectClass),
| should be done outside the deployers - e.g. in ManagementView when creating the ManagedComponents.
| So that it always creates the same MO for the attachment persistence.
| Maybe a related topic Scott created: http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4222668
|
| This does not not cover partial persistence and removing components, but i think we can discuss that later.
|
Ok, I see. We need to move the managed object factory extension behavior out of the deployers. I'll start looking at that.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4225491#4225491
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4225491
16 years, 12 months