[JBoss AS7 Development] - Please javadoc concurrency semantics
by Jason Greene
Jason Greene [http://community.jboss.org/people/jason.greene%40jboss.com] created the discussion
"Please javadoc concurrency semantics"
To view the discussion, visit: http://community.jboss.org/message/570830#570830
--------------------------------------------------------------
Since more and more people are starting to work on the code base, we really need to be clear about what the concurrency semantics are for every class. It just takes a few extra minutes and will likely save hours of time by preventing unintentional breakage, and preventing others from having to infer it.
All I ask, is that on every new class you do just add a simple Thread-Safety like section, and explain how you intend the class to be used. Also if you modify a class please make sure your modification either fits the previously documented semantics, or carefully explore the consequences when you change them. This will also help tip-off reviewers that such a change is happening.
In many cases this could be just one sentence:
"Thread-Safety: This class is not thread safe, and is intended to have an instance per thread"
"Thread-Safety: This class is not thread safe, and is intended to have all interactions guarded by a lock"
"Thread-Safety: This class allows concurrent access to any method, but needs a happens-before event between construction and usage"
Of course more complex designs would need additional information, however typing that out will probably make you think through it a little more, and you may catch flaws you didn't originally think of. I know I have before.
Thanks!
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/570830#570830]
Start a new discussion in JBoss AS7 Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]
13 years, 4 months
[JBoss AS7 Development] - Thoughts on ws integration
by Alessio Soldano
Alessio Soldano [http://community.jboss.org/people/alessio.soldano%40jboss.com] created the discussion
"Thoughts on ws integration"
To view the discussion, visit: http://community.jboss.org/message/570759#570759
--------------------------------------------------------------
Hi,
I've been reasoning a bit on what will need to be done to add ws functionalities to AS 7. While the final work will need to wait for the ejb3 subsystem to be available, the current web subsystem should be enough for a limited support (POJO endpoints only), hence for starting looking at the integration.
The domain model additions due to the ws subsystem should be quite trivial; first questions/doubts come when dealing with the deployment instead. As far as I can see, other subsystems define activators that create deployment chains; each of them come with its chain selector and given set of processors that actually deal with the deployment. Selectors seems to trigger the chain processing depending on the kind of the deployment (a war, jar, sar, etc.), or more generally speaking on basic reasoning over the deployment package (name of the virtual file, manifest contents, etc.).
A selector can't be easily defined for detecting "ws deployments" as of course a webservice endpoint could be part of a web deployment or of an ejb deployment.
In AS 5/6 the ws deployers (let's talk about the REAL ones only here) were basically running in between the ejb/web ones, properly modifying (or creating in the case of ejb3 ws deployments) the JBossWebMetaData that was later consumed by the TomcatDeployer.
With the current AS7 architecture, we'd probably need integration hooks for interleaving the ws processors with the web ones. Of course having the web subsystem directly depend on anything in the ws one is not acceptable.
The alternative -defining a new chain for the ws deployment and calling the required web processors in there- is most probably not going to work.
What options do you see here?
--------------------------------------------------------------
Reply to this message by going to Community
[http://community.jboss.org/message/570759#570759]
Start a new discussion in JBoss AS7 Development at Community
[http://community.jboss.org/choose-container!input.jspa?contentType=1&cont...]
13 years, 4 months