[jboss-dev-forums] [Design the new POJO MicroContainer] - Wrong check in DeployersImpl.checkControllerContext()

This check looks wrong to me | protected final void checkControllerContext( | ControllerContext context, | Map<String, Throwable> contextsInError, | Map<String, Set<MissingDependency>> contextsMissingDependencies, | ControllerStateModel states) | { | ,,, | for (DependencyItem item : dependsInfo.getUnresolvedDependencies(nextState)) | { | if (item.isResolved() == false) | { | ... | //Wrong? | ControllerState requiredState = item.getWhenRequired(); | String requiredStateString = requiredState.getStateString(); | if (actualState == null || states.isAfterState(requiredState, actualState)) | { | MissingDependency missing = new MissingDependency(name, dependency, requiredStateString, actualStateString); | dependencies.add(missing); | } | } | } | } | contextsMissingDependencies.put(name, dependencies); | } | } | Should we not be using the following instead | ControllerState dependentState = item.getWhenDependentState(); | String dependentStateString = dependentState.getStateString(); | if (actualState == null || states.isAfterState(dependentState, actualState)) | View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4242865#... Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&a...