"mstruk" wrote :
| In UnpackTestCase I changed some assertions since the previous ones test some
implementation details that are different when it comes to ZipEntryContext. Ales, have a
look, maybe we can put some more sensible tests there.
|
OK, I'll have a look once full merge is done, e.g. NoCopy is included, ...
I suspect it's an issue with trunk having NoCopy by default, and when we read the
nested jars, your impl already copies the file, where in our trunk case we don't - and
that's what the test expects - hence assertEqual.
"mstruk" wrote :
| I also commited an optimization of the way file handles are released. I mentioned that
it was too aggressive and causing a slight performance penalty. The slow down was not big,
but was still noticable so I added an automatic asynchronous mechanism that releases files
when they haven't been used for a few seconds. Currently this period is 5 seconds -
hardcoded at the moment - can be made configurable. This fixes maybe about 80% of
performance degradation which now looks to be ~1-2% jboss startup time relative to current
vfs trunk.
|
I don't see why this asynch behavior is necessary.
OK, I guess there must be a good reason for it, otherwise you wouldn't include it.
Just couldn't find any good explanation of it in this tread. ;-)
View the original post :
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4153520#...
Reply to the post :
http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...