[jboss-dev-forums] [Design of Messaging on JBoss (Messaging/JBoss)] - Re: Replay transaction on XA

I have gone through and reviewed the journal as promised. I have just committed some changes, please can you look through, I have left various comments in the code. Most of the changes were minor or cosmetic - there are still some unresolved questions (see comments), also more code comments are needed in places - e.g. record formats. There are also some methods that are only used by tests (append methods taking byte[]) the tests should use the public interface methods which use encodingsupport. I also removed a few remaining references to xids. Now, regarding the issue at hand: I prefer option 1). currently add and update records can take an arbitrary encoding support for data, we should just extend this for delete too. So for delete, we write the queue id, as we currently do for updates. This is the most symmetrical solution imho. Regarding adding extra data for xids in the prepare. After thought I think this is acceptable as long as no reference to xids in the code (I have removed them all now) - it's just extra data. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4175523#... Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...