Here are the results of the large message code review:
1. Need some tests that show pre-commit acks working with large messages
2. Need some tests show in large messages failover.
3. We should use SessionSendMessage for sending both large and normal messages. We should
then have a new packet called SessionSendMessageContinuation for sending extra chunks.
4. We should use SessionReceiveMessage for receiving both large and normal messages, with
continuations in a different packet.
5. Chunk messages are currently always sent blocking. Instead only the last chunk should
be sent blocking, and then, only if sendBlocking = true
6. Replication for large messages needs to be implemented
7. ClientConsumeImpl::handleChunk should be synchronized and have closing check like
handleMessage()
8.ClientConsumerImpl shouldn't use instanceof to determine FileMessage, instead use
isFileConsiumer()
9.Flow control - for large message flow control should be called before adding adding to
buffer APART from last chunk which should have flow control called before consumption,
otherwise could flood the buffer.
View the original post :
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4191362#...
Reply to the post :
http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...