"alesj" wrote : Why does it have to be on a MutableX in the first place? because
this is basically an advanced method/field/constructor editor so it only makes sense that
its on a Mutable object imo.
"alesj" wrote :
| I guess having a custom interface is OK,
| but then you need to separate your AOP code as well,
| to have this part in configurable (depending on the actuall Reflect impl) class.
yes this is true, but as i mentioned i felt that this was very javassist specific. but i
can add it to the spi package if you want.
atm ive added it to org.jboss.reflect.plugins.javassist.expr and yes this means we need to
have javassist specific code in aop, but this is something we think we'll have anyway
since aop uses a lot of methods we have decided to keep out of the org.jboss.reflect.spi
package.
eg methods like: CtNewMethod.getter/abstract/etc are all methods that aop uses, but after
discussing it with kabir we felt that this would clutter up the api. so we decided that we
would rather make some sort of util classes that support this.
The very best thing(tm) imo, would be that we dont implement anything too javassist
specific in jboss-reflect, but aop is an advanced user of javassist so this would require
a lot of rewrites to aop.
- do you have any input on this kabir?
View the original post :
http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4215259#...
Reply to the post :
http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&a...