"ALRubinger" wrote : | Great code in general. I appreciated your commitment to documentation and cleanup/centralization as you go along. | | In ripping jboss-bootstrap out of the Application Server, I've been especially sensitive to violation of scope and extending a component's concerns outside its domain. In this case, startup/shutdown of bootstraps is provided by impl-base, and the attached patch addresses test cases in impl-mc. This makes it more of a compliance/acceptance test where impl-mc validates it's getting a good impl-base. | I wasn't sure what each module was for. I just looked for a test that started up 'bootstraps' inside a 'server'. Got it... impl-mc is for the MC specific stuff like parsing XML and whatnot, impl-base is for basic lifecycle sequence. "ALRubinger" wrote : | So I've attached an alternate way of tackling the issue in "JBBOOT-56.v2.ALR.patch" on the JIRA. Have a look and let me know what you think. | Downloaded the patch, here's what I think: * I had to move the files in the patch because the patch was based on a subdirectory. I'll have to see if IDEA can make patches with a directory different from the base of the project. I'm using boostrap/trunk as the base. * Now I understand what 'a Bootstrap' is, sort of. Partial understanding of the module structure. * I'm not sure about the "package per jira issue" convention. But hey... if that's how you wanna roll. "ALRubinger" wrote : | Some misc minor notes: | | * You don't need AtomicInteger in LifecycleOrderPojo (as you hint); this is all single-threaded. | * We need to get you set up w/ JBoss licence headers and preferably with a formatter (if you're in Eclipse I have code templates). | Okay. Wasn't sure about AtomicInteger. I have multi-threading on the brain. I have eclipse, but I prefer IDEA. I've already made templates for the license and such for IDEA. "ALRubinger" wrote : | I'm impressed that you've picked up the Bootstrap Server API and MC jboss-beans.xml deployments so quickly. This was a good, working patch you've provided. So let's just address the scope issue and move forward on something else? ;) | Yes, now that I understand everything (yeah, right). ;) "ALRubinger" wrote : | Outstanding questions: | | * Do you have an account on jboss.org? This enables posting to the forums, JIRA assignments, etc. | * Have you yet signed a contributor's agreement? Once done I can commit on your behalf, and after a few patches, get you commit access. | | http://jboss.org/contributor | I'm forum/wiki/JIRA enabled. But I haven't signed a contributor agreement in a while. I pre-date the shiny new contributor sign up web application. ;) View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4238841#... Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&a...