- http://anonsvn.jboss.org/repos/jbossas/projects/jboss-mdr/trunk/src/main/... Seems to fit the main usage we have in jboss aop. Later when using the mdr in aop we can create the mdr signatures from MethodInfo etc "stale.pedersen(a)jboss.org" wrote : | mostly because then we are sure that we will get a CtClass instance within the parameter. there is also a String parameter if you would prefer to use that. it makes little sense to have a ClassInfo param since then we would just do the same work internally as with the String param. | Maybe as Ales says we should not have MutableCI as parameters. If just CI is used, we can check internally if it is of the correct type (JavassistClassInfo), otherwise fall back to the String impl and look it up from the name. It saves us having to look it up every time. "alesj" wrote : | "stale.pedersen(a)jboss.org" wrote : | | The usage of the Class parameter needs to be removed, internal methods using it will just use the CtClass object. | | | How does this effect the (weak type) cache? | That is an implementation detail that needs to be reworked internally. Having Class as the key for this won't work since we don't want the class to be loaded. Internally the weak type cache stores class names in a map of cl, so this methods can work | TypeInfoFactory.getTypeInfo(String name, ClassLoader cl) | The use of WeakClassCache by Javassist will need revisiting so that it does not try to load the class every time we try to look something up since that is not needed by the underlying implementation. "alesj" wrote : | "stale.pedersen(a)jboss.org" wrote : | | is it ok if i start commit to jboss-reflect? i can exclude the new files in the pom if needed. | | | I don't wanna sound pita, but let's finish this discussion first. | Create a wiki page with the work in progress? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4204934#... Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...