"alesj" wrote : "emuckenhuber" wrote : | | AFAIK there was a discussion last year to only keep the WarStructure in the AS codebase and have a mock implementation for the deployers tests only. Adrian then ported the WarStructure to AS. | What was the reason to do so? | | For me it makes more sense to keep the one in Deployers, | as then I don't have to fix/port any new features when I "mock" the .war deployment in Deployers. | And with .wars being mostly the only ones that have a bit diff CL policy, | we do/should use WarStructure a lot. | | Perhaps if the AS WarStructure would in the future use some of the ext metadata classes, | we should just make sure there are properly exposed hooks in Deployer's WarStructure, | and make AS's AdvancedWarStrucutre extends WarStrucutre. There was a bug in the WarStructure and it would have required a deployers release. I think that all War*Deployers should be in the same project, as they belong together - tests should go there as well. As long as it does not affect the core functionality of the deployers. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4260734#... Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&a...