"bstansberry(a)jboss.com" wrote : | 1) Should "public void registerProfile(Profile profile)" instead be "public void registerProfile(ProfileMetaData profile)"? Let the ProfileService handle creation of the Profile from metadata. To make my HASingletonProfileManager work I needed to inject a reference to the ProfileFactory bean, which smells wrong. | Well the basic idea behind that was to be able to create a Profile outside the ProfileService. The correct name for the ProfileFactory should be BootstrapProfileFactory (as this thing is just creating profiles for bootstrap). But i was also thinking about creating a real ProfileFactory, which creates a Profile based on the ProfileMetaData - as this would also go well with some other updates on the meta data model. "bstansberry(a)jboss.com" wrote : | 2) Similar thing with "public void unregisterProfile(Profile profile)". I think the argument should be a ProfileKey. | Makes sense. I was not sure if this might could get a install/uninstall callback - but i'm not convinced that this makes sense anymore. "bstansberry(a)jboss.com" wrote : | 3) This is just a nit. Why releaseProfile(ProfileKey key) instead of inactivateProfile(ProfileKey key)? | I've updated the profileservice-spi today and named it 'deactivateProfile' - although if you say that inactivateProfile is better english, i can be easily convinced ;) Still need to do a new release of the spi and commit some recent work i've been doing. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4204455#... Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...