"clebert.suconic(a)jboss.com" wrote : I have done some small changed on XID on Journal. | | The Journal should be agnostic about XID IMO, The StorageManager should be the correct place to encode and decode that. | Yes, indeed. The journal is designed to be a generic journal which just deals with byte[]. The idea here is it could be used by other projects with journalling needs in the future. So, certainly it should not be polluted with domain specific abstractions. anonymous wrote : | So, I have changed it a little bit. journal.prepare is now receiving an EncodingSupport, and TransactionHolder is aways holding a byte[] representing the XID. JournalStorageManager later will translate that after load is done. | Sounds good. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4174752#... Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...