In building upon the work done in TMPARCH-9 to make a VFS Implementation of a storage
engine (
https://jira.jboss.org/jira/browse/TMPARCH-16), I've come across the following
points for discussion/adjustment:
* Seems the only purpose of MemoryMapArchiveImpl is to implement
"getActualClass()". This returns the type MemoryMapArchive, which isn't
really implementation-specific. Can the done in the MemoryMapArchiveBase (if we even need
a base for this, probably just the impl will do).
* MemoryMapArchiveBase.toString(boolean) never checks for if "false" is
specified, in which case we should delegate to the no-arg method.
* MemoryMapArchiveBase.toString(boolean) internally does a Comparable implementation (as
TODO), though BasicPath provides this. I'll now commit as part of the Path contract
that Comparable is extended, so we can do away with this extra bit.
* MemoryMapArchiveBase should be documented as Thread-safe (it appears to be)
S,
ALR
View the original post :
http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4251042#...
Reply to the post :
http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&a...