1) Forcing depage. I don't get this. Looking at the code I can see you force a depage
if the reference isn't found in the queue
a) I notice you only force one depage - How can you be sure the required message is in the
next page? It might be in any page after that.
b) Let's say you force a depage and the message *is* in there, the message will get
depaged and routed to the queue. I can't see anywhere where the reference is then
removed from the queue. Could this lead to duplicate deliveries?
2) Address is being passed on replicate delivery mesage. This worries me for performance
reasons. Can't we do this another way?
3) Precalculation of flow control
a) if ((creditsUsed -= chunk.getRequiredBufferSize()) < 0)
Looks suspicious - this will actually decrement the creditsUsed variable
b) Can you be sure that the first large message chunk gets sent iirespective or available
credits? - we need to ensure this to avoid blocking
c) pre-calculation of credits seems very complex... looks like it could do with some
optimisation
View the original post :
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4203909#...
Reply to the post :
http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&a...