October 2008 - jboss-dev-forums - Jboss List Archives

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by adrian＠jboss.org

"adrian(a)jboss.org" wrote : | But there's probably a reason why I didn't do that in the first place | (other than I just forgot to do it? - which might actually be the real reason. :-) I think the reason why I didn't do it, is because it doesn't really work. To get close, DeploymentContext.getScope() would need a similar HACK to what is in KernelScopeInfo. i.e. use the deployment's classloader to convert the class name to a class in the CLASS scope level. But your example shows that the component/deployment's classloader isn't necessarily the correct classloader to do that. In fact, the correct classloader doesn't even exist yet. You do know whether you can use the deployment classloader bean.getClassLoader() == null but that doesn't help when it is not null. ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185157#4185157 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185157

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by alesj

"adrian(a)jboss.org" wrote : | Those sound overly complicated. | The simplest fix would be in the component visitor, something like: | | | | protected static void addBeanComponent(DeploymentUnit unit, BeanMetaData bean) | | { | | DeploymentUnit component = unit.addComponent(bean.getName()); | | component.addAttachment(BeanMetaData.class.getName(), bean); | | + String className = bean.getBean(); | | + if (className != null) | | + component.getScope().addScope(CommonLevels.CLASS, className); | | } | | This is the code + | + unit.addAttachment(ScopeBuilder.class, BeanMetaDataScopeBuilder.INSTANCE); | + | KernelControllerContext context = new AbstractKernelControllerContext(null, deployment, null); | ScopeInfo scopeInfo = context.getScopeInfo(); | - if (scopeInfo != null) | - { | - mergeScopes(scopeInfo.getScope(), unit.getScope()); | - mergeScopes(scopeInfo.getMutableScope(), unit.getMutableScope()); | - } | + scopeInfo.setScope(unit.getScope()); | + scopeInfo.setMutableScope(unit.getMutableScope()); | try | { | controller.install(context); | @@ -190,4 +194,18 @@ | return new AbstractValueMetaData(unit.getClassLoader()); | } | } | + | + private static class BeanMetaDataScopeBuilder extends DefaultScopeBuilder | + { | + private static final ScopeBuilder INSTANCE = new BeanMetaDataScopeBuilder(); | + | + public ScopeKey getComponentScope(DeploymentContext context) | + { | + BeanMetaData bmd = context.getDeploymentUnit().getAttachment(BeanMetaData.class); | + ScopeKey scopeKey = super.getComponentScope(context); | + if (bmd != null && bmd.getBean() != null) | + scopeKey.addScope(CommonLevels.CLASS, bmd.getBean()); | + return scopeKey; | + } | + } | } But you're right, yours looks easier. :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185153#4185153 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185153

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by adrian＠jboss.org

"alesj" wrote : "adrian(a)jboss.org" wrote : | | So another fix would be to somehow make the Deployer's ScopeBuilder | | somehow aware of the class scope when it creates the component scope. | | | ScopeBuilder per attachment type? | | | public static ScopeBuilder getScopeBuilder(DeploymentContext deploymentContext) | | { | | if (deploymentContext == null) | | throw new IllegalArgumentException("Null deployment context"); | | ScopeBuilder builder = deploymentContext.getTransientAttachments().getAttachment(ScopeBuilder.class); | | if (builder != null) | | return builder; | | DeploymentContext parent = deploymentContext.getParent(); | | if (parent != null) | | return getScopeBuilder(parent); | | return DefaultScopeBuilder.INSTANCE; | | } | | | Setting BeanMD aware ScopeBuilder? Those sound overly complicated. The simplest fix would be in the component visitor, something like: | protected static void addBeanComponent(DeploymentUnit unit, BeanMetaData bean) | { | DeploymentUnit component = unit.addComponent(bean.getName()); | component.addAttachment(BeanMetaData.class.getName(), bean); | + String className = bean.getBean(); | + if (className != null) | + component.getScope().addScope(CommonLevels.CLASS, className); | } | View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185152#4185152 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185152

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by alesj

"adrian(a)jboss.org" wrote : | So another fix would be to somehow make the Deployer's ScopeBuilder | somehow aware of the class scope when it creates the component scope. | ScopeBuilder per attachment type? | public static ScopeBuilder getScopeBuilder(DeploymentContext deploymentContext) | { | if (deploymentContext == null) | throw new IllegalArgumentException("Null deployment context"); | ScopeBuilder builder = deploymentContext.getTransientAttachments().getAttachment(ScopeBuilder.class); | if (builder != null) | return builder; | DeploymentContext parent = deploymentContext.getParent(); | if (parent != null) | return getScopeBuilder(parent); | return DefaultScopeBuilder.INSTANCE; | } | Setting BeanMD aware ScopeBuilder? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185150#4185150 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185150

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by adrian＠jboss.org

"alesj" wrote : "adrian(a)jboss.org" wrote : | | I guess this is because it doesn't look like DefaultScopeBuilder in the deployers knows | | anything about classes when creating component scopes? | | It just adds the INSTANCE level to the DEPLOYMENT/APPLICATION | Yup, my guess would be we're then missing this | | | public AbstractScopeInfo(Object name, String className) | | { | | if (name == null) | | throw new IllegalArgumentException("Null scope"); | | | | ScopeKey scopeKey = ScopeKey.DEFAULT_SCOPE.clone(); | | scopeKey.addScope(CommonLevels.INSTANCE, name.toString()); | | if (className != null) | | scopeKey.addScope(CommonLevels.CLASS, className); | | setScope(scopeKey); | | setMutableScope(new ScopeKey(CommonLevels.INSTANCE, name.toString())); | | } | | So another fix would be to somehow make the Deployer's ScopeBuilder somehow aware of the class scope when it creates the component scope. Then there's no need for any merge. But there's probably a reason why I didn't do that in the first place (other than I just forgot - which might actually be the real reason. :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185148#4185148 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185148

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by alesj

Mostly the CommonLevels.CLASS. :-) >From debuging BeanMDDeployer in AnnotatedBeansUnitTestCase: | contextKey = {org.jboss.metadata.spi.scope.ScopeKey@907}"[JVM=THIS, CLASS=class org.jboss.test.deployers.vfs.deployer.bean.support.SimpleAnnotatedConstructor, INSTANCE=Constructor]" | | unitKey = {org.jboss.metadata.spi.scope.ScopeKey@908}"[JVM=THIS, APPLICATION=KernelDeployerTest, DEPLOYMENT=KernelDeployerTest, INSTANCE=Constructor]" View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185144#4185144 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185144

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by alesj

"adrian(a)jboss.org" wrote : | I guess this is because it doesn't look like DefaultScopeBuilder in the deployers knows | anything about classes when creating component scopes? | It just adds the INSTANCE level to the DEPLOYMENT/APPLICATION Yup, my guess would be we're then missing this | public AbstractScopeInfo(Object name, String className) | { | if (name == null) | throw new IllegalArgumentException("Null scope"); | | ScopeKey scopeKey = ScopeKey.DEFAULT_SCOPE.clone(); | scopeKey.addScope(CommonLevels.INSTANCE, name.toString()); | if (className != null) | scopeKey.addScope(CommonLevels.CLASS, className); | setScope(scopeKey); | setMutableScope(new ScopeKey(CommonLevels.INSTANCE, name.toString())); | } | View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185143#4185143 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185143

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by alesj

"adrian(a)jboss.org" wrote : | The obvious first question is why is it merging scopes? You did this change. | No merging broke my AnnotatedBeansUnitTestCase test. Some metadata gets lost with the scope override - as we already create some info when creating AbstractKernelControllerContext. Let me try and find if we already discussed this ... View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185142#4185142 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185142

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by adrian＠jboss.org

"adrian(a)jboss.org" wrote : | Merging the scopes is broken since any deployer that wants to "play with" | the metadata will be using the wrong scope, i.e. the wrong metadata. | Especially the mutable scope! | I guess this is because it doesn't look like DefaultScopeBuilder in the deployers knows anything about classes when creating component scopes? It just adds the INSTANCE level to the DEPLOYMENT/APPLICATION View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185139#4185139 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185139

15 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: ClassLoader injection Scope issue

by adrian＠jboss.org

The obvious fix would be to add some mergeScope() methods to ScopeInfo which would know to avoid the hack that converts the class name -> class. The merging of the mutable scope shouldn't be happening. Its a recipe for all sorts of confusion if DefaultScopeBuilder and KernelScopeInfo disagree on what that should be. DefaultScopeBuilder (or some deployer that sets the mutable scope on the deployment unit) should be the only authority for that. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4185137#4185137 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4185137

15 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums October 2008