November 2008 - jboss-dev-forums - Jboss List Archives

[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Changes on the JBM stack on JBoss5

by vblagojevic＠jboss.com

Hey guys, Are you making any progress on that AS test? I have completed a fix for FLUSH and it looks very good. I have done over a hundreds of tests on both loopback off/on and all of the tests pass - not a single failure. How should we proceed? Clebert, do you want me to give you a jar file so you can give it a spin? If it looks good we can soon proceed to cut 2.6.7. Let me know, Vladimir View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188468#4188468 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188468

17 years, 5 months

1
0
0 / 0

[Design the new POJO MicroContainer] - jboss-scanning.xml

by alesj

Moving this - http://lists.jboss.org/pipermail/jboss-development/2008-November/012965.html discussion here. How would this file look like? e.g. | <scanning> | <include path="org/jboss/acme/ejbs" filter="ant:*.*Bean"/> | <include path="org/jboss/domain/hibernate" filter="regexp:<some-reg-exp>"/> | <exclude path="org/jboss/logic"/> | <exclude module="rules-impl.jar" /> | </scanning> | Or what info should we expect from ScanningMetadata? ejb-jar.xml and web.xml are mentioned in ml discussion. How would we transform them into ScanningMetaData? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188467#4188467 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188467

17 years, 5 months

1
0
0 / 0

[Design of Messaging on JBoss (Messaging/JBoss)] - Re: Behaviours of Ordering Group with scheduled delivery and

by timfox

Hopefully will get around to reviewing this some time this week :) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188434#4188434 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188434

17 years, 5 months

1
0
0 / 0

[Design of POJO Server] - Re: VFS Permissions - JBMICROCONT-149

by alesj

"adrian(a)jboss.org" wrote : "alesj" wrote : "adrian(a)jboss.org" wrote : The closest thing that doesn't need the vfs url handlers. | | How do you represent multiple nested jars in real url? | | (too lazy to read the spec ;-)) | Or the earlier posts in this thread. ;-) | I should have written "lazy in general" then. :-) "adrian(a)jboss.org" wrote : | You can't do it. That's why you've got to use the closest thing. | e.g. | vfszip:/my.ear/my.rar/my.jar | would have to use the jar url for my.rar And this is probably enough, since the permission would be on some parent? As this is also probably the best plain JDK security can offer? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188429#4188429 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188429

17 years, 5 months

1
0
0 / 0

[Design of POJO Server] - Re: VFS Permissions - JBMICROCONT-149

by adrian＠jboss.org

"alesj" wrote : "adrian(a)jboss.org" wrote : The closest thing that doesn't need the vfs url handlers. | How do you represent multiple nested jars in real url? | (too lazy to read the spec ;-)) Or the earlier posts in this thread. ;-) You can't do it. That's why you've got to use the closest thing. e.g. vfszip:/my.ear/my.rar/my.jar would have to use the jar url for my.rar View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188427#4188427 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188427

17 years, 5 months

1
0
0 / 0

[Design of POJO Server] - Re: VFS Permissions - JBMICROCONT-149

by alesj

"adrian(a)jboss.org" wrote : The closest thing that doesn't need the vfs url handlers. How do you represent multiple nested jars in real url? (too lazy to read the spec ;-)) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188425#4188425 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188425

17 years, 5 months

1
0
0 / 0

[Design of POJO Server] - Re: VFS Permissions - JBMICROCONT-149

by adrian＠jboss.org

"alesj" wrote : "adrian(a)jboss.org" wrote : I said it should be | | VFSUtils.getRealURL(vfsFile) above but Anil has done URL. | What do you consider as real url? The file: or jar: url The closest thing that doesn't need the vfs url handlers. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188423#4188423 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188423

17 years, 5 months

1
0
0 / 0

[Design of POJO Server] - Re: VFS Permissions - JBMICROCONT-149

by alesj

"adrian(a)jboss.org" wrote : I said it should be | VFSUtils.getRealURL(vfsFile) above but Anil has done URL. What do you consider as real url? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188420#4188420 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188420

17 years, 5 months

1
0
0 / 0

[Design of POJO Server] - Re: VFS Permissions - JBMICROCONT-149

by adrian＠jboss.org

"alesj" wrote : "alesj" wrote : "adrian(a)jboss.org" wrote : | | | This requires something in the VFS, my suggestion was to add | | | VFSUtils.getRealURL(vfsFile); | | | | | Should I hold off VFS 2.0.0.GA until these features get into VFS? | I see Anil already added this to VFS. | But it looks wrong. ;-) | That's the problem with quick and dirty. ;-) I said it should be VFSUtils.getRealURL(vfsFile) above but Anil has done URL. What should happen is this uses the implemented details of the VirtualFile to delegate the request to the vfs handler. Only the protocol specific handler knows how it maps its urls to a real url. Its called object orientated programming. :-) The list of if statements is the clue. if you have to write code like (which is also incredibly inefficient) | if(vfsURL.getPath().endsWith("jar")) | ... | if(vfsURL.getProtocol().startsWith("vfsfile")) | ... | if(vfsURL.getProtocol().startsWith("vfszip")) | ... | etc. | You're almost certainly doing something wrong. Correct would be something like: | public URL getRealURL(VirtualFile file) | { | // public methods should always check parameters to give useful error messages | if (file == null) | throw new IllegalArgumentException("null file); | VirtualFileHandler handler = file.getHandler(); | return handler.getRealURL(); // NEW METHOD | } | But at least its in the right project now. ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188419#4188419 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188419

17 years, 5 months

1
0
0 / 0

[Design of POJO Server] - Re: VFS Permissions - JBMICROCONT-149

by alesj

"alesj" wrote : "adrian(a)jboss.org" wrote : | | This requires something in the VFS, my suggestion was to add | | VFSUtils.getRealURL(vfsFile); | | | Should I hold off VFS 2.0.0.GA until these features get into VFS? I see Anil already added this to VFS. But it looks wrong. ;-) | /** | * Get the Real URL | * @param vfsURL | * @return | * @throws Exception | */ | public static URL getRealURL(URL vfsURL) throws Exception | { | if(vfsURL.getPath().endsWith("jar")) | { | String urlStr = "jar:" + FILE_PROTOCOL + ":" + vfsURL.getPath() + JAR_URL_SEPARATOR; | return new URL(urlStr); | } | | if(vfsURL.getProtocol().startsWith("vfsfile")) | return new URL(FILE_PROTOCOL, vfsURL.getHost(), vfsURL.getPort(), vfsURL.getFile()); | | if(vfsURL.getProtocol().startsWith("vfszip")) | { | String urlStr = vfsURL.toExternalForm(); | //nested file | int indexJar = urlStr.indexOf(".jar"); | String beforejar = urlStr.substring("vfszip:".length(), urlStr.indexOf(".jar")); | String afterjar = urlStr.substring(indexJar + 1 + ".jar".length()); | return new URL("jar:file:" + beforejar + ".jar " + JAR_URL_SEPARATOR + afterjar); | } | if(log.isTraceEnabled()) | log.trace("getRealURL did not have a match for:"+vfsURL.toExternalForm()); | return vfsURL; | } | First some simple code critique. If you add something to project you don't sustain, be fair and add javadocs as it should be done. Since this is probably gonna be called for every class we load, some more constants won't kill you. Dunno how much optimization javac puts on "vfszip."length() and repeated ".jar". Tests should be more exhaustive. As I see some extra space after last ".jar that's probably not supposed to be there. Dunno how this would work. But in general, jar/zip handling is completely broken. First, it should be the same code that handles it, since, although we currently use vfszip, user can still fall back to old vfsjar handling. And they are both the same as far as feature set goes (it's just that we have winz lock problems on vfsjar). But the biggest problem I see is how are you gonna handle multiple nested jars. Dunno what's the proper/real url for those, but I very much doubt it's how your code does it. I guess this would have to be an impl of VirtualFileHandlers, not just VFSUtils. Conclusion. Either this is done right, or it goes out. I'll leave it for now, but will check on it before I do 2.0.0.GA. If you need any help on writing this, open a new forum post. And I'll see what can be done. ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4188403#4188403 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4188403

17 years, 5 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums November 2008