[Design of JBoss Profiler] - Re: Current Web app broken due to xhtml filename case issue
by jesper.pedersen
anonymous wrote : OK, now just so I get this straight, the all-lower-case xhtml names are intentional and that's the coding convention, is that right?
Correct for all .xhtml files -- and basically all 'web' based files in the web-frontend - like CSS, Skins, ... Indentation should use spaces.
Additional things to look for
* Access to Agent/Profiler should be done the same way as client/cmd/Client
* The navigation rules are missing in faces-config.xml
* All managed beans are declared in session scope
* Place common functionality (command line / web) in the .client package - the APIs can be changed, but remember that the command line client has to work ;)
Also use the JSF/RichFaces libraries as much as possible -- e.g. <h:outputLink> instead of and so on - makes it easier to skin later on.
I would rather see a web front-end that is working before making it "fancy" -- e.g. output existing reports inside tags before using dynamic trees to display the thread reports. Of course it is up to you ;)
Feel free to post questions - I'm happy to help out where I can.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4192280#4192280
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4192280
15 years, 10 months
[Design of JBoss Profiler] - Re: Current Web app broken due to xhtml filename case issue
by rhills
Hi Jesper,
"jesper.pedersen" wrote :
| The web-console is far from being done
|
Yes, I'd seen that in other posts in this forum.
"jesper.pedersen" wrote :
| - and as I stated in the latest release notes we need people to work on it - so all your contributions in this area are most welcomed !
|
I'm happy to help where I can.
"jesper.pedersen" wrote :
| I have fixed the head.xhtml issue you listed - but there are a lot of other issues that needs to be fixed. I havn't completed my review of the initial code contribution - so the code will change.
|
OK, now just so I get this straight, the all-lower-case xhtml names are intentional and that's the coding convention, is that right? I took the approach of renaming the xhtml files themselves to restore the camel-case names that they seem to have had previously. That seemed the "path of least resistance" to get the webapp working, but if the standard is to have all-lower-case names, I'll go with that and submit some patches.
"jesper.pedersen" wrote :
| Feel free to submit patches (unified diff) through JIRA -- I'll get the 2.x project setup soon.
|
I see it's there now so as soon as you've clarified the coding standard, I'll get to work!
Cheers,
Rob Hills
Waikiki, Western Australia
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4192274#4192274
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4192274
15 years, 10 months