[Design of AOP on JBoss (Aspects/JBoss)] - Re: Privileged Blocks Issue : JBAOP-675
by anil.saldhana@jboss.com
Flavia, the fix should not go in GenericAspectFactory as you did.
Messaging is weaving their code (ClientSessionDelegate) as in:
| 3:22:07,502 ERROR [STDERR] java.lang.Exception: Stack trace
| 23:22:07,503 ERROR [STDERR] at java.lang.Thread.dumpStack(Thread.java:1158)
| 23:22:07,503 ERROR [STDERR] at java.security.AccessControlContext.checkPermission(AccessControlC
| ontext.java:253)
| 23:22:07,503 ERROR [STDERR] at java.security.AccessController.checkPermission(AccessController.j
| ava:427)
| 23:22:07,503 ERROR [STDERR] at java.lang.SecurityManager.checkPermission(SecurityManager.java:53
| 2)
| 23:22:07,503 ERROR [STDERR] at java.lang.Class.getClassLoader(Class.java:588)
| 23:22:07,503 ERROR [STDERR] at org.jboss.aop.advice.GenericAspectFactory.getClazz(GenericAspectF
| actory.java:123)
| 23:22:07,503 ERROR [STDERR] at org.jboss.aop.advice.GenericAspectFactory.createPerInstance(Gener
| icAspectFactory.java:175)
| 23:22:07,503 ERROR [STDERR] at org.jboss.aop.InstanceAdvisorDelegate.initializeAspects(InstanceA
| dvisorDelegate.java:109)
| 23:22:07,503 ERROR [STDERR] at org.jboss.aop.InstanceAdvisorDelegate.initialize(InstanceAdvisorD
| elegate.java:71)
| 23:22:07,503 ERROR [STDERR] at org.jboss.aop.ClassInstanceAdvisor.setAdvisorAndInitialise(ClassI
| nstanceAdvisor.java:84)
| 23:22:07,503 ERROR [STDERR] at org.jboss.aop.ClassInstanceAdvisor.<init>(ClassInstanceAdvisor.java:68)
| 23:22:07,503 ERROR [STDERR] at org.jboss.jms.client.delegate.ClientSessionDelegate._getInstanceA
| dvisor(ClientSessionDelegate.java)
| 23:22:07,503 ERROR [STDERR] at org.jboss.jms.client.delegate.ClientSessionDelegate.createMessage
| (ClientSessionDelegate.java)
| 23:22:07,503 ERROR [STDERR] at org.jboss.jms.client.JBossSession.createMessage(JBossSession.java
| :124)
|
Their pointcut is on createMessage of ClientSessionDelegate. At the location of the pointcut, in the aop weaved code, you should be wrapping that with a privileged block.
You are trying the priv block way up in the stack trace.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4190989#4190989
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4190989
17 years, 4 months
[Design of JBoss jBPM] - Re: Register EventListener on JbppmContext
by camunda
@Thomas: I also the events I want to listen for are more inside of the engine (so implementation detail ;-)). But the Listeners you propose also make sense, even if I don't understand the API at this part yet...
@Tom: I expected you to say that ;-) And I agree with you, but for me the situation is not putting effort in jbpm 3 or 4, but to solve the problem in the customer project either by some workarounds around jbpm (in "our" code) or to implement it correctly in the jbpm 3 core. Effort could be maybe the same. So I think it makes more sense to contribute it to jbpm and maybe even gather experiences for jbpm 4. And even jbpm 3 will be around for quite a while I think...
So if you don't vote explicitly against it I would maybe contribute it if it comes to that point in the current project (concept isn't yet fixed), ok?
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4190987#4190987
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4190987
17 years, 4 months
[Design the new POJO MicroContainer] - Re: UnwrapValueUnitTestCase.testCollectionUnwrap failure on
by adrian@jboss.org
"alesj" wrote : "adrian(a)jboss.org" wrote :
| | Let's go with that, but we need to do so extra work to see whether all this
| | caching is (still) effective.
| |
| But won't this interfere with this:
| "adrian(a)jboss.org" wrote :
| | Also I think it will cause a memory leak.
| |
| | You effectively have:
| |
| | | WeakValueHashMap<ClassInfo, BeanInfo>
| | |
| | but the ClassInfo could itself get a hard reference on the BeanInfo
| | via one of its "attachments", e.g. the caching of SchemaBindings in jbossxb
| | against the TypeInfo.
| |
|
I assume you're using a WeakHashMap<ClassInfo, Map>
not a WeakValueHashMap as originally proposed?
The ClassInfo reference is now weak.
anonymous wrote : If not, I'll change it + add some caching tests. :-)
Test the contract not the implemenation details. ;-)
Otherwise, you'll only have to rewrite the tests when you change the caching alogrithm
or some other detail in future - which kind of makes them pointless.
See my earlier printCollection code. This tests the contract and would be
a valid test with or without caching.
Without caching, it would just be that the Bean/ClassInfo instances
are different == (but equivalent .equals) at each stage.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4190981#4190981
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4190981
17 years, 4 months
[Design of JBoss jBPM] - Re: Register EventListener on JbppmContext
by tom.baeyens@jboss.com
"camunda" wrote : Hi.
|
| Yesterday I was at customer and they did an extension to jbpm where they added the possibility to add EventListener to the JbpmContext (configured via jbpm.cfg.xml).
|
| Today I face a similar problem, it would be interesting to get notified if each event fired inside the engine (basically to catch them and maybe throw the aggregated to some BAM engine).
|
| What do you guys think, include such a feature in jbpm core? I think it is an interesting one without bit complexity. Also the guys from yesterday could provide some code for it (Tom, I heard there is a pending committer status request from them), so maybe it wouldn't be that hard...
|
| Opinions?
|
| Cheers
| Bernd
all our jbpm 3 efforts are now focussed on increasing the stability and test coverage (mainly dbs).
this feature should be discussed in terms of jbpm4. in that context, it might be an option to leverage the environment for that. after a event propagated all the way up to the environment, it could be propagated further on the environment contexts. good idea, but needs some more reflection. performance might become an issue so it should be possible somehow to configure which events are propagated to the environment like that.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4190971#4190971
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4190971
17 years, 4 months