[Design of Messaging on JBoss (Messaging/JBoss)] - Re: AIO only waiting for completions on add
by timfox
A few points though on your last commit.
1) Several files were missing copyright headers and class headers showing authorship. All files must have both of these before committing! I shouldn't have to keep saying this.. ;)
2) Lots of cosmetic changes to files, code style, indentation, putting private public, static methods in their own sections of the file. Adding final to attributes and parameters. Making inner classes static. Making inner classes private. Making members private. Various other minor coding issues like the above.
3) Remoting timeout has changed from seconds to milliseconds? I agree we should change from s to ms, but has this been changed everywhere?
4) TypedProperties - the encodeSize() method traverses the entire map every time it is called. I don't like this for performance reasons. Instead the size should be maintained internally.
5) Min files was changed to 2, and file size changed from 10MB to 100 MB. 10MB was originally chosen since it seems a reasonable size to fit on a single cylinder of a disk. This allows the entire file to be accessed without moving the head. When I changed it back to 10MB and 10 files, none of the jms tests run any more reporting they can't initialise AIO (or something like that).
Apart from that, looking good! :)
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4150299#4150299
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4150299
17 years, 11 months
[Design of JBoss jBPM] - Re: organization of the enterprise module
by tom.baeyens@jboss.com
"alex.guizar(a)jboss.com" wrote : There are two entity-based implementations of the scheduler service, one in org.jbpm.scheduler.ejbtimer and the other in org.jbpm.ejb. The descriptor points to the former; the latter is probably the remains of an earlier refactoring.
|
Up to the last release 3.2.2 the ejb timer service uses an SLSB: one bean on which all the timers are registered. This can become a scalability issue.
That's why we (Me and then Fady) implemented the timer entity bean: one bean per timer.
"alex.guizar(a)jboss.com" wrote :
| The EjbSchedulerService class, introduced in earlier 3.2.x versions, invokes the entity bean, whereas the new EntitySchedulerService class invokes the timer session bean.
|
I believe the coding of the timer entity bean has been done. I don't know to what extend the timer entity work is finished:
* QA-ed
* Configurtation in the enteprise ear deployment package
* Documentation
Alejandro can you verify which of these are done ?
"alex.guizar(a)jboss.com" wrote :
| The command service interface, home interface and session bean are placed in the org.jbpm.ejb package, whereas the timer entity artifacts are located in org.jbpm.scheduler.ejbtimer.
| Any reason for this odd arrangement? If not, I want to rearrange as follows.
| Remove the timer entity in org.jbpm.ejb. Move the timer entity in org.jbpm.scheduler.ejbtimer to org.jbpm.ejb.
| For backwards compatibility, have EjbSchedulerService invoke the timer session bean. Have EntitySchedulerService invoke the timer entity bean, which better matches its name.
The only thing you can take into account is the architectural picture. The services are used inside of the JbpmContext-block. The timer entity bean is only an implementation detail of the EntitySchedulerService.
If you take that into account, you can rearrange as you want (as long as it works :-)
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4150263#4150263
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4150263
17 years, 11 months