[Embedded JBoss Development] - Re: Peer Review of Embedded, ShrinkWrap and Bootstrap
by jesper.pedersen
Check the alignment of method parameters in all factories
| ./api-as/src/main/java/org/jboss/bootstrap/api/as/server/JBossASServerFactory.java
| ./api-as/src/main/java/org/jboss/bootstrap/api/as/config/JBossASServerConfigFactory.java
| ./api-embedded/src/main/java/org/jboss/bootstrap/api/embedded/server/JBossASEmbeddedServerFactory.java
| ./api/src/main/java/org/jboss/bootstrap/api/factory/GenericFactory.java
| ./api/src/main/java/org/jboss/bootstrap/api/factory/ServerFactory.java
| ./api/src/main/java/org/jboss/bootstrap/api/factory/ServerConfigFactory.java
| ./api-mc/src/main/java/org/jboss/bootstrap/api/mc/server/MCServerFactory.java
| ./api-mc/src/main/java/org/jboss/bootstrap/api/mc/config/MCServerConfigFactory.java
|
so the order of the parameters are located in the same order
| blabla(final ClassLoader cl)
| blabla(final ClassLoader cl, final String clz)
|
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4261514#4261514
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4261514
16 years, 5 months
[Embedded JBoss Development] - Peer Review of Embedded, ShrinkWrap and Bootstrap
by ALRubinger
Jesper was kind enough to have a look at our work and give his input.
"Jesper Pedesen" wrote :
| Overall:
| ========
|
| * Good idea to add overview.html / package.html
| * Good idea to run checkstyle
| * Good idea to run findbugs (with reportLevel="low")
|
| Bootstrap:
| ==========
| * api-embedded
| * impl-embedded
|
| - Needs to be move to Embedded - as they are a specific use-case of Bootstrap
| - Refactor package names
|
| * I'm not too crazy about BootstrapMetadata being in the spi/ package
| * Also there are constants in spi/ which may not have a relevance for the actual environment
|
| * I guess it is ok to keep the MC and AS specific modules here - as many projects will use them
|
| * Missing excludes in pom.xml for MC and AS
|
| org.jboss.bootstrap.api.server.Server
| -------------------------------------
| void registerEventHandler(LifecycleState state, LifecycleEventHandler handler) throws IllegalArgumentException;
|
| arguments should be reversed to follow other registerEventHandler methods
|
| org.jboss.bootstrap.api.lifecycle.LifecycleState
| ------------------------------------------------
|
| Are we sure that there won't be any additional server states in the future ?
| Or that an implementation will define additional states ?
|
| In those cases an enum won't work - as it can't be extended.
|
| Embedded:
| =========
|
| * Missing excludes in pom.xml
|
| org.jboss.bootstrap.api.embedded.server.JBossASEmbeddedServerFactory
| --------------------------------------------------------------------
|
| "public static final ..." -> "private static final ..."
|
| ... otherwise a
|
| createServer(final ClassLoader cl, final String className)
|
| method is needed...
|
|
| ShrinkWrap:
| ===========
|
| - Check ContextClassLoader assumptions
|
| org.jboss.shrinkwrap.api.Path
| -----------------------------
|
| * Would a org.jboss.cache.Fqn style be better ?
|
| org.jboss.shrinkwrap.api.Archive
| --------------------------------
|
| T add(Path target, String name, Asset asset) throws IllegalArgumentException;
|
| switch assert and name
|
| * Remove all "String target" -- Path should be used
|
| T merge(Path path, Archive<?> source) throws IllegalArgumentException;
|
| switch path and source
|
|
| org.jboss.shrinkwrap.api.spec.FactoryUtil
| -----------------------------------------
|
| * createInstance method with ClassLoader
|
| org.jboss.shrinkwrap.api.container.ResourceContainer
| ----------------------------------------------------
|
| * Alignment of method arguments
|
| org.jboss.shrinkwrap.api.container.EnterpriseContainer
| ------------------------------------------------------
|
| * Alignment of method arguments
|
| org.jboss.shrinkwrap.api.container.WebContainer
| -----------------------------------------------
|
| * Alignment of method arguments
|
| org.jboss.shrinkwrap.api.container.ManifestContainer
| ----------------------------------------------------
|
| * Alignment of method arguments
|
| org.jboss.shrinkwrap.api.container.LibraryContainer
| ---------------------------------------------------
|
| * addLibraries()
|
| org.jboss.shrinkwrap.api.export.FactoryUtil
| -------------------------------------------
|
| * createInstance() with ClassLoader
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4261505#4261505
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4261505
16 years, 5 months
[Management Development] - management domain model
by emuckenhuber
Getting started with some initial work on the domain configuration i might just share a few thoughts.
In case of the domain model it maybe doesn't make much sense using something like JAXB, as it requires all metadata classes available on the bootstrap classpath - which somehow contradicts any modularization effort. Also having other projects built on top of AS to modify some bootstrap descriptors might not be what we want.
Since the domain configuration is the view which is going to be exposed over the managemend domain - we thought of a direct mapping between elements in the xml and the exposed ManagedObjects. So we should be able to use this mapping to populate ManagedObject as well. The question is how it gets mapped to the component's deployment descriptors.
A different problem of this configuration is that it's component oriented. Unlike in AS5 where we have a mapping from the deployment to a component. Since ProfileService does not know which deployment contains which component we won't be able to push a deployment descriptor into the deployers.
In general there are two different use cases of configuration:
1) overriding existing deployment descriptors (a sort of component-ref)
- 1.1) which could also include saying not to deploy a component
2) defining new components without a deployment (e.g. DataSources)
Additionally we should support value transformation, given the use case of ServiceBindingManager (ports-default, ports01). There was also a discussion about declaring thread-pools in there, which would need to create a component and then a for the specified service.
In the end i see the main difficulty in getting all the different meta data, deployers and container implementation integrated. We have this issue with ProfileService in AS5 to a certain extend already, so we should think of a better way to handle this integration.
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4261458#4261458
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4261458
16 years, 5 months
[jBPM Development] - JBPM Rollback exception
by dmanchale
Can anyone please help me out solving this error...??? am using jbpm4 and trying to insert the values into the data base. but its getting rolled back saying the instance is not of expected entity type.
2009-10-21 11:48:47,133 WARN [com.arjuna.ats.arjuna.logging.arjLoggerI18N] (http-127.0.0.1-8080-1) [com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator_2] TwoPhaseCoordinator.beforeCompletion - failed for com.arjuna.ats.internal.jta.resources.arjunacore.SynchronizationImple@124d310
org.hibernate.HibernateException: instance not of expected entity type: org.jbpm.pvm.internal.type.variable.UnpersistableVariable is not a: org.jbpm.pvm.internal.type.Variable
at org.hibernate.persister.entity.AbstractEntityPersister.getSubclassEntityPersister(AbstractEntityPersister.java:3663)
at org.hibernate.impl.SessionImpl.getEntityPersister(SessionImpl.java:1374)
at org.hibernate.engine.ForeignKeys.isTransient(ForeignKeys.java:203)
at org.hibernate.event.def.AbstractSaveEventListener.getEntityState(AbstractSaveEventListener.java:535)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.performSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:103)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:93)
at org.hibernate.impl.SessionImpl.fireSaveOrUpdate(SessionImpl.java:534)
at org.hibernate.impl.SessionImpl.saveOrUpdate(SessionImpl.java:526)
at org.hibernate.engine.CascadingAction$5.cascade(CascadingAction.java:241)
at org.hibernate.engine.Cascade.cascadeToOne(Cascade.java:291)
at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:239)
at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
at org.hibernate.engine.Cascade.cascadeCollectionElements(Cascade.java:319)
at org.hibernate.engine.Cascade.cascadeCollection(Cascade.java:265)
at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:242)
at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
at org.hibernate.engine.Cascade.cascade(Cascade.java:153)
at org.hibernate.event.def.AbstractFlushingEventListener.cascadeOnFlush(AbstractFlushingEventListener.java:154)
at org.hibernate.event.def.AbstractFlushingEventListener.prepareEntityFlushes(AbstractFlushingEventListener.java:145)
at org.hibernate.event.def.AbstractFlushingEventListener.flushEverythingToExecutions(AbstractFlushingEventListener.java:88)
at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:49)
at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1027)
at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:365)
at org.hibernate.transaction.CacheSynchronization.beforeCompletion(CacheSynchronization.java:88)
at com.arjuna.ats.internal.jta.resources.arjunacore.SynchronizationImple.beforeCompletion(SynchronizationImple.java:101)
at com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator.beforeCompletion(TwoPhaseCoordinator.java:263)
at com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator.end(TwoPhaseCoordinator.java:86)
at com.arjuna.ats.arjuna.AtomicAction.commit(AtomicAction.java:177)
at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.commitAndDisassociate(TransactionImple.java:1414)
at com.arjuna.ats.internal.jta.transaction.arjunacore.BaseTransaction.commit(BaseTransaction.java:135)
at com.arjuna.ats.jbossatx.BaseTransactionManagerDelegate.commit(BaseTransactionManagerDelegate.java:75)
at org.jboss.tm.usertx.client.ServerVMClientUserTransaction.commit(ServerVMClientUserTransaction.java:162)
at org.jbpm.enterprise.internal.jta.JtaTransactionInterceptor.executeCmdInNewJtaTx(JtaTransactionInterceptor.java:123)
at org.jbpm.enterprise.internal.jta.JtaTransactionInterceptor.execute(JtaTransactionInterceptor.java:70)
at org.jbpm.pvm.internal.svc.ExecutionServiceImpl.startProcessInstanceByKey(ExecutionServiceImpl.java:69)
at com.hp.adm.ADCService.InvokeADCProcess(ADCService.java:36)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.jboss.wsf.container.jboss50.invocation.InvocationHandlerJSE.invoke(InvocationHandlerJSE.java:99)
at org.jboss.ws.core.server.ServiceEndpointInvoker.invoke(ServiceEndpointInvoker.java:219)
at org.jboss.wsf.stack.jbws.RequestHandlerImpl.processRequest(RequestHandlerImpl.java:498)
at org.jboss.wsf.stack.jbws.RequestHandlerImpl.handleRequest(RequestHandlerImpl.java:295)
at org.jboss.wsf.stack.jbws.RequestHandlerImpl.doPost(RequestHandlerImpl.java:205)
at org.jboss.wsf.stack.jbws.RequestHandlerImpl.handleHttpRequest(RequestHandlerImpl.java:131)
at org.jboss.wsf.common.servlet.AbstractEndpointServlet.service(AbstractEndpointServlet.java:109)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:235)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:190)
at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:92)
at org.jboss.web.tomcat.security.SecurityContextEstablishmentValve.process(SecurityContextEstablishmentValve.java:126)
at org.jboss.web.tomcat.security.SecurityContextEstablishmentValve.invoke(SecurityContextEstablishmentValve.java:70)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at org.jboss.web.tomcat.service.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:158)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:330)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:828)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:601)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
at java.lang.Thread.run(Thread.java:619)
2009-10-21 11:48:47,414 DEBUG [org.jboss.ws.core.jaxws.handler.MessageContextJAXWS] (http-127.0.0.1-8080-1) Begin response processing
2009-10-21 11:48:47,414 DEBUG [org.jboss.ws.core.soap.MessageContextAssociation] (http-127.0.0.1-8080-1) popMessageContext: org.jboss.ws.core.jaxws.handler.SOAPMessageContextJAXWS@ab7b2 (Thread http-127.0.0.1-8080-1)
2009-10-21 11:48:47,414 DEBUG [org.jboss.ws.core.soap.MessageContextAssociation] (http-127.0.0.1-8080-1) pushMessageContext: org.jboss.ws.core.jaxws.handler.SOAPMessageContextJAXWS@1b249ae (Thread http-127.0.0.1-8080-1)
2009-10-21 11:48:47,446 ERROR [org.jboss.ws.core.jaxws.SOAPFaultHelperJAXWS] (http-127.0.0.1-8080-1) SOAP request exception
org.jbpm.api.JbpmException: transaction has been rolled back
at org.jbpm.enterprise.internal.jta.JtaTransactionInterceptor.executeCmdInNewJtaTx(JtaTransactionInterceptor.java:151)
at org.jbpm.enterprise.internal.jta.JtaTransactionInterceptor.execute(JtaTransactionInterceptor.java:70)
at org.jbpm.pvm.internal.svc.ExecutionServiceImpl.startProcessInstanceByKey(ExecutionServiceImpl.java:69)
at com.hp.adm.ADCService.InvokeADCProcess(ADCService.java:36)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.jboss.wsf.container.jboss50.invocation.InvocationHandlerJSE.invoke(InvocationHandlerJSE.java:99)
at org.jboss.ws.core.server.ServiceEndpointInvoker.invoke(ServiceEndpointInvoker.java:219)
at org.jboss.wsf.stack.jbws.RequestHandlerImpl.processRequest(RequestHandlerImpl.java:498)
at org.jboss.wsf.stack.jbws.RequestHandlerImpl.handleRequest(RequestHandlerImpl.java:295)
at org.jboss.wsf.stack.jbws.RequestHandlerImpl.doPost(RequestHandlerImpl.java:205)
at org.jboss.wsf.stack.jbws.RequestHandlerImpl.handleHttpRequest(RequestHandlerImpl.java:131)
at org.jboss.wsf.common.servlet.AbstractEndpointServlet.service(AbstractEndpointServlet.java:109)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:235)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:190)
at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:92)
at org.jboss.web.tomcat.security.SecurityContextEstablishmentValve.process(SecurityContextEstablishmentValve.java:126)
at org.jboss.web.tomcat.security.SecurityContextEstablishmentValve.invoke(SecurityContextEstablishmentValve.java:70)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at org.jboss.web.tomcat.service.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:158)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:330)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:828)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:601)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
at java.lang.Thread.run(Thread.java:619)
Caused by: javax.transaction.RollbackException: [com.arjuna.ats.internal.jta.transaction.arjunacore.commitwhenaborted] [com.arjuna.ats.internal.jta.transaction.arjunacore.commitwhenaborted] Could not commit transaction.
at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.commitAndDisassociate(TransactionImple.java:1426)
at com.arjuna.ats.internal.jta.transaction.arjunacore.BaseTransaction.commit(BaseTransaction.java:135)
at com.arjuna.ats.jbossatx.BaseTransactionManagerDelegate.commit(BaseTransactionManagerDelegate.java:75)
at org.jboss.tm.usertx.client.ServerVMClientUserTransaction.commit(ServerVMClientUserTransaction.java:162)
at org.jbpm.enterprise.internal.jta.JtaTransactionInterceptor.executeCmdInNewJtaTx(JtaTransactionInterceptor.java:123)
... 35 more
Caused by: org.hibernate.HibernateException: instance not of expected entity type: org.jbpm.pvm.internal.type.variable.UnpersistableVariable is not a: org.jbpm.pvm.internal.type.Variable
at org.hibernate.persister.entity.AbstractEntityPersister.getSubclassEntityPersister(AbstractEntityPersister.java:3663)
at org.hibernate.impl.SessionImpl.getEntityPersister(SessionImpl.java:1374)
at org.hibernate.engine.ForeignKeys.isTransient(ForeignKeys.java:203)
at org.hibernate.event.def.AbstractSaveEventListener.getEntityState(AbstractSaveEventListener.java:535)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.performSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:103)
at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:93)
at org.hibernate.impl.SessionImpl.fireSaveOrUpdate(SessionImpl.java:534)
at org.hibernate.impl.SessionImpl.saveOrUpdate(SessionImpl.java:526)
at org.hibernate.engine.CascadingAction$5.cascade(CascadingAction.java:241)
at org.hibernate.engine.Cascade.cascadeToOne(Cascade.java:291)
at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:239)
at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
at org.hibernate.engine.Cascade.cascadeCollectionElements(Cascade.java:319)
at org.hibernate.engine.Cascade.cascadeCollection(Cascade.java:265)
at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:242)
at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
at org.hibernate.engine.Cascade.cascade(Cascade.java:153)
at org.hibernate.event.def.AbstractFlushingEventListener.cascadeOnFlush(AbstractFlushingEventListener.java:154)
at org.hibernate.event.def.AbstractFlushingEventListener.prepareEntityFlushes(AbstractFlushingEventListener.java:145)
at org.hibernate.event.def.AbstractFlushingEventListener.flushEverythingToExecutions(AbstractFlushingEventListener.java:88)
at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:49)
at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1027)
at org.hibernate.impl.SessionImpl.managedFlush(SessionImpl.java:365)
at org.hibernate.transaction.CacheSynchronization.beforeCompletion(CacheSynchronization.java:88)
at com.arjuna.ats.internal.jta.resources.arjunacore.SynchronizationImple.beforeCompletion(SynchronizationImple.java:101)
at com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator.beforeCompletion(TwoPhaseCoordinator.java:263)
at com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator.end(TwoPhaseCoordinator.java:86)
at com.arjuna.ats.arjuna.AtomicAction.commit(AtomicAction.java:177)
at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.commitAndDisassociate(TransactionImple.java:1414)
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4261423#4261423
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4261423
16 years, 5 months