[Design the new POJO MicroContainer] - Re: ClassPool for JBoss Reflection
by kabir.khan@jboss.com
"flavia.rainone(a)jboss.com" wrote :
| On AS5, I see that the JBoss5ClassPoolFactory is the default factory used if there is no class pool defined.
| At Branch5_x. I see that the classpool factory is defined as JBossClDelegatingClassPoolFactory. So, is JBoss5CPF ever used?
JBoss5CPF is the old class pool factory that was used before the new XXXXDelegatingClassPools.
"flavia.rainone(a)jboss.com" wrote :
| Another question, I didn't get what is TempClassPool for (except for the convert references part) and when is it used.
Do you mean this:
| protected boolean convertReferences(CtClass clazz, ClassAdvisor clazzAdvisor) throws Exception
| {
| boolean converted = false;
| String ref = null;
| try
| {
| AOPClassPool pool = AOPClassPool.createAOPClassPool(clazz.getClassPool(), AOPClassPoolRepository.getInstance());
|
It is something I've always assumed was there for a reason and taken for granted since it has been there since before my time. However, all that seems to do is to delegate to the parent classpool so maybe it can be removed and clazz.getClassPool() can be used?
"flavia.rainone(a)jboss.com" wrote :
| Before creating this project... Will be there a need for a StandaloneClassPool, Kabir? I don't think so, but I would like to confirm. If the class pools are tied in to JBoss, I'll create a jboss-classpool project, so we can make clear that it is jboss as-related only.
|
It looks like StandaloneClassPool(Factory) is used when run standalone, i.e. in the testsuite. But that can maybe live in AOP?
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4242888#4242888
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4242888
16 years, 9 months
[Design of JBoss jBPM] - Re: current activity of execution
by tom.baeyens@jboss.com
for the record: i wasn't spanking you. (at least not this time:-) i added that to the docs because you pointed out a hole in the docs. thanks !
anonymous wrote : But still, this doesn't lead to a problem with the getActivityName, or? If I am in a composite, the root execution may be in the scope/composite state, and the child in the "real" state.
exactly. the parent execution will have as execution state Execution.STATE_INACTIVE_CONCURRENT_ROOT and it should still point to the scope/composite activity. the leaves point to the real activity.
the difference with before is that each activity that has variables or timers declared on it, will also create a child token. the parent execution will be in state STATE_INACTIVE_SCOPE and the (single) child will be in state STATE_ACTIVE_ROOT
in that case the parent execution will be in state
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4242883#4242883
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4242883
16 years, 9 months
[Design the new POJO MicroContainer] - Wrong check in DeployersImpl.checkControllerContext()
by kabir.khan@jboss.com
This check looks wrong to me
| protected final void checkControllerContext(
| ControllerContext context,
| Map<String, Throwable> contextsInError,
| Map<String, Set<MissingDependency>> contextsMissingDependencies,
| ControllerStateModel states)
| {
| ,,,
| for (DependencyItem item : dependsInfo.getUnresolvedDependencies(nextState))
| {
| if (item.isResolved() == false)
| {
| ...
| //Wrong?
| ControllerState requiredState = item.getWhenRequired();
| String requiredStateString = requiredState.getStateString();
| if (actualState == null || states.isAfterState(requiredState, actualState))
| {
| MissingDependency missing = new MissingDependency(name, dependency, requiredStateString, actualStateString);
| dependencies.add(missing);
| }
| }
| }
| }
| contextsMissingDependencies.put(name, dependencies);
| }
| }
|
Should we not be using the following instead
| ControllerState dependentState = item.getWhenDependentState();
| String dependentStateString = dependentState.getStateString();
| if (actualState == null || states.isAfterState(dependentState, actualState))
|
View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4242865#4242865
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4242865
16 years, 9 months