Re: [rules-dev] Spring support for drools-api
Geoffrey De Smet wrote:
With kind regards,
Geoffrey De Smet
Mark Proctor schreef:
>> I'd also maybe consider dropping the Spring prefix, as it's in a
>> package called spring?
>> => org.drools.spring.KnowledgeAgentFactoryBean
> My worry here is it might be a duplicate of the same name used in the
> future - although it'll be in a different package namespace, it's
> still not good practice. Anyone else have any opinions on this?
Good point, prefixing it with Spring can't hurt :)
I'm just wondering about
KnowledgeBuilderFactory and
KnowledgeBaseFactory. While it makes sense to put the
KnowledgeAgentFactory into spring, does it make sense for those other
factories? What are they gonna do other than return KnowledgeBuilder or
a KnowledgeBase, only possible advantage is that it would allow spring
to inject the KnowledgeBuilderConfiguration and
KnowledgeBaseConfiguration. And ideas?
http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-api/src/main/j...
http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-api/src/main/j...
http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-api/src/main/j...
http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/drools-api/src/main/j...
This is typically how those two factories are used:
KnowledgeBuilder kbuilder = KnowledgeBuilderFactory.newKnowledgeBuilder();
kbuilder.addResource( new URL( "file://myrules.drl" ),
KnowledgeType.DRL);
KnowledgeBase kbase = KnowledgeBaseFactory.newKnowledgeBase();
If we use spring to automate the adding of resources, that's pretty much
what the agent is doing anyway, so wouldn't that be pointless?
Mark
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev