Cody,
This look EXCELLENT.
I have one question/potential suggestion so far regarding:
*.subjectHTMLFromClassPath("subject.html.vm") *
*.templateHTMLFromClassPath("template.html.vm") *
and related methods.
Have you considered creating an abstraction here that alows for pluggable
template resolvers? Otherwise you have this "explosion" of methods in the
interface that may end up causing maintenance woes. However, if you replaced
this with something like:
*.template(new HtmlFromClassPath("template.html.vm"))*
*.subject(new HtmlFromClassPath("subject.html.vm"))** *
People would be empowered to implement a simple interface with limitless
extension possibilities.
Thoughts?
~Lincoln
On Mon, Feb 7, 2011 at 1:57 PM, Dan Allen <dan.j.allen(a)gmail.com> wrote:
Seam devs,
Cody is looking for some feedback on the mail module [1] before he drafts a
reference guide and puts the API on ice.
Seam mail is important because, let's face it, the Java Mail API needs a
makeover. Thankfully, the CDI programming model offers the necessary hooks
to create a modernized mail API capable of deep integration with the Java EE
platform (specifically the Java Mail API and container-managed sessions).
Seam Mail offers a fluent API that makes sending e-mail in Java a painless
experience. But an e-mail is nothing without the content. That's why Seam
Mail offers several templating options, such as Velocity, as well as an
extensible template SPI, to allow you to select your templating solution of
choice. With Seam Mail, you'll be sending e-mail from your application in no
time.
Is this how you imagined it would be?
Basic:
@Inject
private Instance<MailMessage> mailMessage;
@Inject
private Session session;
mailMessage.get()
.from("Seam Framework", "seam(a)jboss.org")
.to("John Smith", "john.smith(a)acme.com")
.subject("Text Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.textBody(text)
.send(session);
Velocity:
@Inject
private Instance<VelocityMailMessage> velocityMailMessage;
@Inject
private Session session;
velocityMailMessage.get().from("Seam Framework",
"seam(a)jboss.org")
.to(person.getName(), person.getEmail())
.subject("HTML Message from Seam Mail - " +
java.util.UUID.randomUUID().toString())
.templateHTMLFromClassPath("template.html.vm")
.put("version", "Seam 3")
.importance(MessagePriority.HIGH)
.addAttachment(new URL("
http://www.seamframework.org/themes/sfwkorg/img/seam_icon_large.png"),
"seamLogo.png", ContentDisposition.INLINE);
.send(session);
We look forward to your feedback.
-Dan
[1]
http://github.com/seam/mail
http://seamframework.org/Seam3/Mail
--
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597
http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev