In the Good Old Days, say late 2008, when the spec was a draft for WebBeans, it said "If any class-level interceptor binding type is specified in XML, the interceptor binding annotations appearing on the implementation class are ignored. The class-level interceptor bindings for the Web Bean include all interceptor bindings declared using XML, together with all interceptor bindings of all stereotypes declared by the Web Bean. Otherwise, if no class-level interceptor binding types are specified in XML, the interceptor binding annotations that appear on the implementation class are used. The class-level interceptor bindings for the Web Bean include all interceptor bindings declared by annotating the implementation class, together with all interceptor bindings of all stereotypes declared by the Web Bean. If any method-level interceptor binding type is specified in XML, the interceptor binding annotations appearing on that method are ignored. The method-level interceptor bindings for that method include only the interceptor bindings declared using XML. Otherwise, if no method-level interceptor binding types are specified in XML, the interceptor binding annotations that appear on that method are used. The method-level interceptor bindings for that method include all the interceptor bindings declared by annotating the method." On Tue, Apr 6, 2010 at 7:56 AM, Stuart Douglas <stuart(a)baileyroberts.com.au&gt; wrote: I can't see any way to get information about the actual Bean that an interceptor is bound to. For example say I have a class: @Security("#{true}") class SomeClass { ... } Another bean with the same class is wired up with XML: <t:SomeClass> <se:Security>#{false}</se:Security> .... </t:SomeClass> I cannot see any way for a security interceptor to know which Bean it is intercepting, and therefore figure out which annotation to use. Is there something I am missing here? Stuart _______________________________________________ seam-dev mailing list seam-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/seam-dev -- --- Nik _______________________________________________ seam-dev mailing list seam-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/seam-dev

I think that the easiest way to address this would be to allow the interceptor to inject the Bean and AnnotatedType object for the intercepted object. e.g. @Inject @InterceptedMetadata Bean bean; @Inject @InterceptedMetadata AnnotatedType type; In theory the AnnotatedType could be null, but in practice custom beans don't support interceptors, so this should be fine. This allows the interceptor to read the annotation information from the AnnotatedType. We could also allow beans to inject this information as well, but I think that this can be implemented as a portable extension without any spec changes. Stuart ________________________________________ From: Pete Muir [pmuir(a)redhat.com] Sent: Friday, 9 April 2010 9:24 PM To: Nicklas Karlsson Cc: Stuart Douglas; seam-dev(a)lists.jboss.org Subject: Re: [seam-dev] Retrieving the Bean object for an interceptor No, I think you are right Stuart. Sounds like something the MR should address. On 6 Apr 2010, at 07:38, Nicklas Karlsson wrote: > In the Good Old Days, say late 2008, when the spec was a draft for WebBeans, it said > > "If any class-level interceptor binding type is specified in XML, the interceptor binding annotations appearing on the implementation > class are ignored. The class-level interceptor bindings for the Web Bean include all interceptor bindings declared > using XML, together with all interceptor bindings of all stereotypes declared by the Web Bean. > > Otherwise, if no class-level interceptor binding types are specified in XML, the interceptor binding annotations that appear > on the implementation class are used. The class-level interceptor bindings for the Web Bean include all interceptor bindings > declared by annotating the implementation class, together with all interceptor bindings of all stereotypes declared by > the Web Bean. > > If any method-level interceptor binding type is specified in XML, the interceptor binding annotations appearing on that > method are ignored. The method-level interceptor bindings for that method include only the interceptor bindings declared > using XML. > > Otherwise, if no method-level interceptor binding types are specified in XML, the interceptor binding annotations that appear > on that method are used. The method-level interceptor bindings for that method include all the interceptor bindings > declared by annotating the method." > > > > On Tue, Apr 6, 2010 at 7:56 AM, Stuart Douglas <stuart(a)baileyroberts.com.au&gt; wrote: > I can't see any way to get information about the actual Bean that an interceptor is bound to. > > For example say I have a class: > > @Security("#{true}") > class SomeClass > { > ... > } > > Another bean with the same class is wired up with XML: > > <t:SomeClass> > <se:Security>#{false}</se:Security> > .... > </t:SomeClass> > > I cannot see any way for a security interceptor to know which Bean it is intercepting, and therefore figure out which annotation to use. Is there something I am missing here? > > Stuart > _______________________________________________ > seam-dev mailing list > seam-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/seam-dev > > > > -- > --- > Nik > _______________________________________________ > seam-dev mailing list > seam-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/seam-dev

On Wed, Apr 14, 2010 at 6:47 PM, Stuart Douglas <stuart(a)baileyroberts.com.au&gt; wrote: What do you mean by 'The approach taken by decorators'? Just that in a decorator, you inject the bean instance. In this case, we are injecting the bean metadata.

- Is InvocationContext.getTarget() guaranteed to return the instance of the bean or can it return a proxy? If it can return a proxy this technique is not going to work.

I have attempted to add a temporary fix for this issue to weld-extensions to allow interceptors to get at the AnnotatedType of the object being intercepted. The extension wraps the InjectionTarget of Beans that need this functionality, and the inject method of the InjectionTarget stores a mapping from the instance to the AnnotatedType in a WeakHashMap. I have a few questions: - Is InvocationContext.getTarget() guaranteed to return the instance of the bean or can it return a proxy? If it can return a proxy this technique is not going to work.

- Can I add a dependency on google collections to weld-extensions? Currently it stores the references in a syncronized WeakHashMap, but really what I need is a Concurrent Weak Identity hashmap. Hopefully this is just a temporary workaround that can be removed after the next release of the spec, but currently I can't see any other way to accomplish this. Stuart ________________________________________ From: Pete Muir [pmuir(a)redhat.com] Sent: Friday, 9 April 2010 9:24 PM To: Nicklas Karlsson Cc: Stuart Douglas; seam-dev(a)lists.jboss.org Subject: Re: [seam-dev] Retrieving the Bean object for an interceptor No, I think you are right Stuart. Sounds like something the MR should address. On 6 Apr 2010, at 07:38, Nicklas Karlsson wrote: > In the Good Old Days, say late 2008, when the spec was a draft for WebBeans, it said > > "If any class-level interceptor binding type is specified in XML, the interceptor binding annotations appearing on the implementation > class are ignored. The class-level interceptor bindings for the Web Bean include all interceptor bindings declared > using XML, together with all interceptor bindings of all stereotypes declared by the Web Bean. > > Otherwise, if no class-level interceptor binding types are specified in XML, the interceptor binding annotations that appear > on the implementation class are used. The class-level interceptor bindings for the Web Bean include all interceptor bindings > declared by annotating the implementation class, together with all interceptor bindings of all stereotypes declared by > the Web Bean. > > If any method-level interceptor binding type is specified in XML, the interceptor binding annotations appearing on that > method are ignored. The method-level interceptor bindings for that method include only the interceptor bindings declared > using XML. > > Otherwise, if no method-level interceptor binding types are specified in XML, the interceptor binding annotations that appear > on that method are used. The method-level interceptor bindings for that method include all the interceptor bindings > declared by annotating the method." > > > > On Tue, Apr 6, 2010 at 7:56 AM, Stuart Douglas&lt;stuart(a)baileyroberts.com.au&gt; wrote: > I can't see any way to get information about the actual Bean that an interceptor is bound to. > > For example say I have a class: > > @Security("#{true}") > class SomeClass > { > ... > } > > Another bean with the same class is wired up with XML: > > <t:SomeClass> > <se:Security>#{false}</se:Security> > .... > </t:SomeClass> > > I cannot see any way for a security interceptor to know which Bean it is intercepting, and therefore figure out which annotation to use. Is there something I am missing here? > > Stuart > _______________________________________________ > seam-dev mailing list > seam-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/seam-dev > > > > -- > --- > Nik > _______________________________________________ > seam-dev mailing list > seam-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/seam-dev > _______________________________________________ seam-dev mailing list seam-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/seam-dev

On Thu, Apr 22, 2010 at 12:38 AM, Marius Bogoevici <marius.bogoevici(a)gmail.com&gt; wrote: > On 10-04-21 10:36 PM, Stuart Douglas wrote: > >> I have attempted to add a temporary fix for this issue to weld-extensions to allow interceptors to get at the AnnotatedType of the object being intercepted. >> >> The extension wraps the InjectionTarget of Beans that need this functionality, and the inject method of the InjectionTarget stores a mapping from the instance to the AnnotatedType in a WeakHashMap. >> >> I have a few questions: >> >> - Is InvocationContext.getTarget() guaranteed to return the instance of the bean or can it return a proxy? If it can return a proxy this technique is not going to work. >> >> > The Interceptor specification says just that "getTarget() returns the > associated target instance", so that would normally mean "the original > intercepted instance". The introduction of decorators made things more > complicated, and in the current implementation (1.0.1), getTarget() will > return the decorator proxy if the bean has both interceptors and > decorators. > Then that is a bug, since it is contrary to the specified behavior of getTarget().

> However, once we move to subclassing (1.0.2), the call will > return the single instrumented instance, which is essentially a subclass > of the bean class. It would be necessary to retrieve the original bean > class from that. But I can see a few options for doing that, one being a > mixin interface with methods that can retrieve information about the > original type of the target object. > Hrm. That's a problem I had not thought of with the subclassing approach. The assumption in EJB is that getTarget() returns an unintercepted/undecorated reference. Urm.

I have attempted to add a temporary fix for this issue to weld-extensions to allow interceptors to get at the AnnotatedType of the object being intercepted. The extension wraps the InjectionTarget of Beans that need this functionality, and the inject method of the InjectionTarget stores a mapping from the instance to the AnnotatedType in a WeakHashMap. I have a few questions: - Is InvocationContext.getTarget() guaranteed to return the instance of the bean or can it return a proxy? If it can return a proxy this technique is not going to work. - Can I add a dependency on google collections to weld-extensions? Currently it stores the references in a syncronized WeakHashMap, but really what I need is a Concurrent Weak Identity hashmap.