Anyway we can do a code style global fix? Its just a right click on the top directory in Intellij.

We did agree to reformat all of the 4.x code after the GA release, using the Sun style. But we haven't done that (obviously). If someone has a nice script that can do it in one go, then we should look at doing this. Mark. On 19 Apr 2007, at 05:50, Kevin Conner wrote: > Bill Burke wrote: >> Anyway we can do a code style global fix? Its just a right click >> on the >> top directory in Intellij. > > As it is in eclipse but I would be willing to bet that our formatting > rules are different to yours ;-) > > In all seriousness we have had this conversation before. The > outcome of > the conversation was to leave any formatting as is, i.e. to *not* > reformat the code unless you are actually replacing it. We did > agree on > some rules for formatting but I can't find the email atm. > > IIRC some of the rules include, spaces instead of tabs, four spaces > instead of three (which some code uses), curly brackets on new > lines for > most scenarios. > > The maven build system for 5 will enforce a coding style, among other > things, as well as setting up the appropriate eclipse formatting > for the > workspace. No idea what would be required to do this for Intellij > but > we should look into this at the same time. > > I'm sure this conversation will resurrect itself at that point > and, no > doubt, at many more. > > Kev > > -- > JBoss, a Division of Red Hat > Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod > Street, Windsor, Berkshire, > SI4 1TE, United Kingdom. > Registered in UK and Wales under Company Registration No. 3798903 > Directors: Michael Cunningham (USA), Charlie Peters (USA) and David > Owens (Ireland) > _______________________________________________ > esb-dev mailing list > esb-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/esb-dev ---- Mark Little mlittle(a)redhat.com JBoss, a Division of Red Hat Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in UK and Wales under Company Registration No. 3798903 Directors: Michael Cunningham (USA), Charlie Peters (USA) and David Owens (Ireland) _______________________________________________ esb-dev mailing list esb-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/esb-dev

Mark Little wrote: > We did agree to reformat all of the 4.x code after the GA release, using > the Sun style. But we haven't done that (obviously). If someone has a > nice script that can do it in one go, then we should look at doing this. > It was the Sun style plus some amendments from what I remember :-). Please *do not* reformat the whole codebase until we have sorted everything out. Kev

I thought it w as the "Mark Little" style we were going to be using ;-) ... open curly brace on a new line etc Mark Little wrote: > We did agree to reformat all of the 4.x code after the GA release, > using the Sun style. But we haven't done that (obviously). If > someone has a nice script that can do it in one go, then we should > look at doing this. > > Mark. > > > On 19 Apr 2007, at 05:50, Kevin Conner wrote: > >> Bill Burke wrote: >>> Anyway we can do a code style global fix? Its just a right >>> click on the >>> top directory in Intellij. >> >> As it is in eclipse but I would be willing to bet that our >> formatting >> rules are different to yours ;-) >> >> In all seriousness we have had this conversation before. The >> outcome of >> the conversation was to leave any formatting as is, i.e. to *not* >> reformat the code unless you are actually replacing it. We did >> agree on >> some rules for formatting but I can't find the email atm. >> >> IIRC some of the rules include, spaces instead of tabs, four spaces >> instead of three (which some code uses), curly brackets on new >> lines for >> most scenarios. >> >> The maven build system for 5 will enforce a coding style, among >> other >> things, as well as setting up the appropriate eclipse formatting >> for the >> workspace. No idea what would be required to do this for >> Intellij but >> we should look into this at the same time. >> >> I'm sure this conversation will resurrect itself at that point >> and, no >> doubt, at many more. >> >> Kev >> >> -- >> JBoss, a Division of Red Hat >> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod >> Street, Windsor, Berkshire, >> SI4 1TE, United Kingdom. >> Registered in UK and Wales under Company Registration No. 3798903 >> Directors: Michael Cunningham (USA), Charlie Peters (USA) and David >> Owens (Ireland) >> _______________________________________________ >> esb-dev mailing list >> esb-dev(a)lists.jboss.org <mailto:esb-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/esb-dev > > ---- > > Mark Little > mlittle(a)redhat.com <mailto:mlittle@redhat.com> > > JBoss, a Division of Red Hat > Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 > Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. > Registered in UK and Wales under Company Registration No. 3798903 > Directors: Michael Cunningham (USA), Charlie Peters (USA) and > David Owens (Ireland) > > > > > --------------------------------------------------------------------- > --- > > _______________________________________________ > esb-dev mailing list > esb-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/esb-dev > -- Red Hat: Registered Address: Red Hat Ltd, Brian O' Donnell and Partners, 62 Merrion Square, Dublin 2, Ireland. Registered in the Companies Registration Office, Parnell House, 14 Parnell Square, Dublin 1, Ireland, at No. 304873 Directors: Charlie Peters (USA), Michael Cunningham (USA). David Owens, Brendan Lane

Bill Burke wrote: > Anyway we can do a code style global fix? Its just a right click on the > top directory in Intellij. As it is in eclipse but I would be willing to bet that our formatting rules are different to yours ;-)

In all seriousness we have had this conversation before. The outcome of the conversation was to leave any formatting as is, i.e. to *not* reformat the code unless you are actually replacing it. We did agree on some rules for formatting but I can't find the email atm.