November 2007 - jboss-dev-forums - Jboss List Archives

[Design the new POJO MicroContainer] - Re: MainDeployerImpl.deploy and checkComplete

by adrian＠jboss.org

Actually, thinking about it the signatures should really be: | void deploy(Deployment... deployment) throws DeploymentException | void undeploy(Deployment... deployment) throws DeploymentException | So you can deploy multiple deployment together in a thread safe and atomic way. This will make the implementation a bit more complicated, buit it will be more useful when you need to deploy mutiple deployments that are related. This happens a lot in the JBossAS testsuite. e.g. | getDeploySetup(MyTestCase.class, "queues-service.xml, test.ear"); | The ... means it will also work for a single deployment as well. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105536#4105536 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105536

18 years, 4 months

1
0
0 / 0

[Design of EJB 3.0] - Re: EJBTHREE-1114 - Cache passivation test and generics agai

by ALRubinger

"adrian(a)jboss.org" wrote : 1) The changes for the Pool/Cache registry broke the test Yes, missed this as the test was also broken before these changes were made. "adrian(a)jboss.org" wrote : 3) The use of generics in the new Pool/Cache registry was/is wrong/stupid Agreed. In addition to the changes you'd made to enable programmatic use of the Registry/Factories, I further cleaned this up in Revision 67175. Thanks for pointing it out. S, ALR View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105531#4105531 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105531

18 years, 4 months

1
0
0 / 0

[Design of EJB 3.0] - Status of annotation based configuration

by scott.stark＠jboss.org

I'm seeing an NPE currently due to a lookup of an annotation not returning a value in the ejb3 container: | 07:44:30,645 ERROR [AbstractKernelController] Error installing to Start: name=jboss.j2ee:ear=appclient_dep_compat14_50.ear,jar=appclient_dep_compat14_50_ejb.jar,name=TestBean,service=EJB3 state=Create | java.lang.NullPointerException | at org.jboss.ejb3.EJBContainer.initializePool(EJBContainer.java:804) | at org.jboss.ejb3.EJBContainer.start(EJBContainer.java:740) | at org.jboss.ejb3.session.SessionContainer.start(SessionContainer.java:208) | at org.jboss.ejb3.stateless.StatelessContainer.start(StatelessContainer.java:124) | at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) | at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) | at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) | ... | | protected void initializePool() throws Exception | { | org.jboss.annotation.ejb.Pool poolAnnotation = getAnnotation(org.jboss.annotation.ejb.Pool.class); | String registeredPoolName = poolAnnotation.value(); // line 804 | int maxSize = poolAnnotation.maxSize(); | long timeout = poolAnnotation.timeout(); | Ejb3Deployer deployer = deployment.getDeployer(); | PoolFactoryRegistry registry = deployer.getPoolFactoryRegistry(); | PoolFactory factory = registry.getPoolFactory(registeredPoolName); | pool = factory.createPool(); | pool.initialize(this, maxSize, timeout); | ... | What are we expecting to do with this type of code? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105529#4105529 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105529

18 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: MainDeployerImpl.deploy and checkComplete

by alesj

Regarding the single deployment process api. Is adding proper locks (similar to what we do in AbstractController) the way to go, or should just the relevant methods be re-written to support single deployment in correct way with regard to topLevelDeployments, allDeployments, ... collections in MainDeployerImpl? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105528#4105528 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105528

18 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: MainDeployerImpl.deploy and checkComplete

by adrian＠jboss.org

"alesj" wrote : So, MainDeployerImpl.deploy was always meant to be all or nothing? | Why are then your tests (MockClassLoaderDependenciesUnitTestCase) not relying on this? :-) | I got this half-check notion from their failure. ;-) That's the problem with writing tests against a incomplete and not properly implemented api. The compiler should have an @Incomplete annotation to go with @Deprecated to warn you that you are probably writing against an api that will change! ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105524#4105524 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105524

18 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: MainDeployerImpl.deploy and checkComplete

by alesj

So, MainDeployerImpl.deploy was always meant to be all or nothing? Why are then your tests (MockClassLoaderDependenciesUnitTestCase) not relying on this? :-) I got this half-check notion from their failure. ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105518#4105518 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105518

18 years, 4 months

1
0
0 / 0

[Design of JBoss Web Services] - Re: Integrating ws spi into jboss-javaee

by scott.stark＠jboss.org

"heiko.braun(a)jboss.com" wrote : We are talking about the STAX and the JAX-WS API, right? | The later will ship with jbossws 2.0.2 that's going to be released anytime soon. AS 5 currently uses a snapshot. If you give me access to the jboss-jaxs-api repo, I'll fix the existing API and update JBossWS to use the jboss-jaxs one instead of the codehaus lib. Yes. You already have access since this is part of the jbossas repository: https://svn.jboss.org/repos/jbossas/projects/javaee/trunk/jboss-jaxs-api/ View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105516#4105516 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105516

18 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: MainDeployerImpl.deploy and checkComplete

by adrian＠jboss.org

"alesj" wrote : With the full impl of JBMICROCONT-187 (which is done :-)), this needs changing in MainDeployerImpl.deploy: | | | public void deploy(Deployment deployment) throws DeploymentException | | { | | addDeployment(deployment); | | process(); | | // FIXME don't check contexts | | checkComplete(deployment); | | } | | | | Since it's completely legit to have not yet fully installed contexts - depending beans, OSGi deployments, ... | | Adding 'checkStructureComplete(Deployment)' in DeployerClient --> only checking if deployment is in error or missing deployer? No that's not the purpose of the single deployment api. It is a short hand way of doing: | deployerClient.addDeployment(deployment); | deployerClient.process(); | deployerClient.checkComplete(); | Except in a thread safe way. In fact the code should be: | public void deploy(Deployment deployment) throws DeploymentException | { | addDeployment(deployment); | process(deployment); | try | { | checkComplete(deployment); | } | catch (DeploymentException e) | { | // Didn't work, roll it back | removeDeployment(deployment); | process(deployment); | } | } | Where process(deployment) only processes the passed deployment, not other deployments that may have been added on other threads. But more importantly, it should really be an atomic operation. i.e. the deployment is either fully working or it is not deployed at all. If you want to add a less strict convience api that is fine, but it is a 5% use case not the normal 95% use case of this method. It's not related to this issue. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105514#4105514 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105514

18 years, 4 months

1
0
0 / 0

[Design of Management Features on JBoss] - Re: Using xinclude in config files

by snacker

Thanks, I will try that! View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105511#4105511 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105511

18 years, 4 months

1
0
0 / 0

[Design the new POJO MicroContainer] - MainDeployerImpl.deploy and checkComplete

by alesj

With the full impl of JBMICROCONT-187 (which is done :-)), this needs changing in MainDeployerImpl.deploy: | public void deploy(Deployment deployment) throws DeploymentException | { | addDeployment(deployment); | process(); | // FIXME don't check contexts | checkComplete(deployment); | } | Since it's completely legit to have not yet fully installed contexts - depending beans, OSGi deployments, ... Adding 'checkStructureComplete(Deployment)' in DeployerClient --> only checking if deployment is in error or missing deployer? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4105509#4105509 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4105509

18 years, 4 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums November 2007