[Design of JBoss jBPM] - Re: undoStart
by camunda
Hi Tom,
good points... The Use case is the following:
If I open one task (for me in Swing, but is is the same in Webapps too) I call the task, so that no other user starts the task concurrently.
If now a user just closes the Form (which can be handled easly in Swing, maybe in JSF too) I undo the start, so that the Task is again in the pool.
So my intention was really only to have it back in the actor pool and set the start date to null.
In our apps, we never change variables between start and end of a task. But If we would do so, and the users closes the Form, maybe a real Undo like you proposed is the better choice, yes.
Is that Undo ready in jbpm 3.2? Then I can switch my Command to that logic and we remove the undoStart method again, no problem.
Or we remove the method and introduce a setter for date, then I can move the logic to the Special command and explain the intetntion there...
EWhat do you think?
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4018782#4018782
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4018782
19 years, 1 month
[Design of JBoss jBPM] - undoStart
by tom.baeyens@jboss.com
Bernd,
could you explain a bit more the undoStart method ?
public void undoStart() {
| actorId = null;
| start = null;
| }
|
especially i'm a bit concerned about the following aspects:
* you set the actorId directly instead of using the setActorId(...,...) method which adds a log record and fires the assign event. is that on purpose ?
* should the swimlane be updated as well ?
* undo might be handled more generically by reversely playing the logs and generating compensating transactions for the updates that were logged. i didn't get to implementing this yet. but this might be something that competes with such an approach.
which use case are you trying to cover with this method ?
wouldn't just using the setters on actorId and start be a better approach as that wouldn't give our users the impression that this undo reverts back a lot of other things as well (e.g. variable updates that have been done between the start and the undoStart).
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4018777#4018777
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4018777
19 years, 1 month
[Design of JBoss ESB] - jBPM in JBossESB
by estebanschifman
There are plenty of ways to combine jBPM and JbossESB capabilities. A few have been explored, and a preliminary version some classes has been added to the trunk in order to facilitate interoperation between both products. Unit tests and a quickstart to show a two way end to end simple interaction are under construction and will soon be commited as well.
AbstractCommandVehicle: yet another 'standard' way of packaging a command, it's arguments and return values. It has a toCommandMessage() method that renders an ESB Message containing the command information, paired with a constructor that takes a Message. It could also used without packaging/extracting it from an esb message, just with setters and getters.
JbpmCommandVehicle: specializes it for interaction with Jbpm. It is intended to work in conjunction with the JbpmCommandInterpreter class, that can be used as an action in the ESB. A few jBPM commands have been implemented, and we would hope more will be included as the community feeds ideas to complete what is now a very small subset of
all possible interactions with jBPM.
If we do things properly it should be possible to standardize on this format for all interactions originated in ESB aware classes and jBPM, including responses to these requests. I am a beginner with only superficial knowledge of the jBPM internals and intricacies, consequently it is very important that contributors with deeper jBPM exposure provide their feedback to point out mistakes, suggest better ways of tackling this matter, and contribute some code . We will appreciate ideas on some base (may be abstract) classes that implement org.jbpm.graph.def.ActionHandler, and that can make it easier to interact with the ESB from the jBPM world.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4018776#4018776
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4018776
19 years, 1 month