January 2009 - jboss-dev-forums - Jboss List Archives

[Design of POJO Server] - Security Deployer assuming VFSDeploymentUnit

by anil.saldhana＠jboss.com

Thomas has raised a JIRA issue https://jira.jboss.org/jira/browse/JBAS-6425 I am opening this thread to see if I can get some second opinion from Ales, Adrian and Scott on this. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205310#4205310 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205310

17 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Those terrible error messages

by david.lloyd＠jboss.com

In any case, let me know if I shouldn't commit this, otherwise I will... today. :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205308#4205308 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205308

17 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Those terrible error messages

by david.lloyd＠jboss.com

"trustin" wrote : An off topic - I'd suggest you to replace '\n' with something more platform independent. | | For instance, Formatter got '%n'. I think we can't use System.getProperty() though due to the security issue as you already know. Perhaps there was something in JBoss Common? ;-) I believe that the logging framework should be taking care of this. Anyway we use '\n' very, very pervasively and I'm not going to try to fix every usage of it. :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205306#4205306 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205306

17 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Those terrible error messages

by david.lloyd＠jboss.com

"alesj" wrote : Sure, go ahead. | But this is not the only place this is done. | Search Deployers code for similar error msg aka 'alien language'. ;-) | | You must fix them both or none. :-) Ales, Ales, Ales. :-) OK, I found some stuff in jboss-deployers-client-spi which I imagine is it. Here's that patch: | Index: deployers-client-spi/src/main/java/org/jboss/deployers/client/spi/IncompleteDeployments.java | =================================================================== | --- deployers-client-spi/src/main/java/org/jboss/deployers/client/spi/IncompleteDeployments.java | +++ deployers-client-spi/src/main/java/org/jboss/deployers/client/spi/IncompleteDeployments.java | @@ -30,6 +30,7 @@ | import java.util.Set; | import java.util.TreeMap; | import java.util.TreeSet; | +import java.util.Iterator; | | /** | * IncompleteDeployments. | @@ -261,19 +262,18 @@ | // Display all the missing dependencies | if (contextsMissingDependencies.isEmpty() == false) | { | - buffer.append("\n*** CONTEXTS MISSING DEPENDENCIES: Name -> Dependency{Required State:Actual State}\n\n"); | + buffer.append("\nDEPLOYMENTS MISSING DEPENDENCIES:\n"); | for (Map.Entry<String, Set<MissingDependency>> entry : contextsMissingDependencies.entrySet()) | { | String name = entry.getKey(); | - buffer.append(name).append("\n"); | + buffer.append(String.format(" Deployment \"%s\" is missing the following dependencies:\n", name)); | for (MissingDependency dependency : entry.getValue()) | { | - buffer.append(" -> ").append(dependency.getDependency()); | - buffer.append('{').append(dependency.getRequiredState()); | - buffer.append(':').append(dependency.getActualState()).append("}"); | - buffer.append("\n"); | + buffer.append(String.format(" Dependency \"%s\" (should be in state \"%s\", but is actually in state \"%s\")\n", | + dependency.getDependency(), | + dependency.getRequiredState(), | + dependency.getActualState())); | } | - buffer.append('\n'); | | // It is not a root cause if it has missing dependencies | rootCauses.remove(name); | @@ -286,22 +286,19 @@ | | if (rootCauses.isEmpty() == false) | { | - buffer.append("\n*** CONTEXTS IN ERROR: Name -> Error\n\n"); | + buffer.append("\nDEPLOYMENTS IN ERROR:\n"); | for (String key : rootCauses.keySet()) | { | - buffer.append(key).append(" -> "); | + buffer.append(String.format(" Deployment \"%s\" is in error due to the following reason(s): ", key)); | Set<String> values = rootCauses.get(key); | - boolean first = true; | - for (String value : values) | - { | - if (first == false) | - buffer.append(" | "); | - else | - first = false; | - | - buffer.append(value); | - } | - buffer.append("\n\n"); | + Iterator<String> it = values.iterator(); | + while (it.hasNext()) | + { | + buffer.append(it.next()); | + if (it.hasNext()) | + buffer.append(", "); | + } | + buffer.append("\n"); | } | } | contextsInErrorInfo = buffer.toString(); | View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205305#4205305 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205305

17 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Those terrible error messages

by trustin

An off topic - I'd suggest you to replace '\n' with something more platform independent. For instance, Formatter got '%n'. I think we can't use System.getProperty() though due to the security issue as you already know. Perhaps there was something in JBoss Common? ;-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205299#4205299 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205299

17 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Those terrible error messages

by alesj

"timfox" wrote : | I was thinking exactly the same thing just the other day while trying to debug while JBM 2.0 wasn't loading in the MC, and struggling with the alien language. | Don't blame MC if JBM doesn't work. :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205292#4205292 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205292

17 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Those terrible error messages

by alesj

"david.lloyd(a)jboss.com" wrote : Should I commit it? Sure, go ahead. But this is not the only place this is done. Search Deployers code for similar error msg aka 'alien language'. ;-) You must fix them both or none. :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205291#4205291 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205291

17 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: Those terrible error messages

by timfox

"david.lloyd(a)jboss.com" wrote : One of the most off-putting things about JBossMC is the confusing, non-human error messages it produces when a deployment fails. | +1. I was thinking exactly the same thing just the other day while trying to debug while JBM 2.0 wasn't loading in the MC, and struggling with the alien language. Anything to humanise it would be winner imho. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205285#4205285 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205285

17 years, 2 months

1
0
0 / 0

[Design the new POJO MicroContainer] - Those terrible error messages

by david.lloyd＠jboss.com

One of the most off-putting things about JBossMC is the confusing, non-human error messages it produces when a deployment fails. Carlo's thread gave me the notion to try and fix this. Here's the patch to AbstractKernelDeployer which humanizes the error message. What do you think? Should I commit it? | Index: kernel/src/main/java/org/jboss/kernel/plugins/deployment/AbstractKernelDeployer.java | =================================================================== | --- kernel/src/main/java/org/jboss/kernel/plugins/deployment/AbstractKernelDeployer.java | +++ kernel/src/main/java/org/jboss/kernel/plugins/deployment/AbstractKernelDeployer.java | @@ -217,22 +217,21 @@ | buffer.append("Incompletely deployed:\n"); | if (errors.size() != 0) | { | - buffer.append("\n*** DEPLOYMENTS IN ERROR: Name -> Error\n"); | + buffer.append("\nDEPLOYMENTS IN ERROR:\n"); | for (ControllerContext ctx : errors) | { | - buffer.append(ctx.getName()).append(" -> ").append(ctx.getError().toString()).append('\n'); | + buffer.append(String.format(" Deployment \"%s\" is in error due to: %s\n", ctx.getName(), ctx.getError())); | } | } | if (incomplete.size() != 0) | { | - buffer.append("\n*** DEPLOYMENTS MISSING DEPENDENCIES: Name -> Dependency{Required State:Actual State}\n"); | + buffer.append("\nDEPLOYMENTS MISSING DEPENDENCIES:\n"); | for (ControllerContext ctx : incomplete) | { | Object name = ctx.getName(); | - buffer.append(name).append(" -> "); | + buffer.append(String.format(" Deployment \"%s\" is missing the following dependencies:\n", name)); | DependencyInfo dependsInfo = ctx.getDependencyInfo(); | Set<DependencyItem> depends = dependsInfo.getIDependOn(null); | - boolean first = true; | for (DependencyItem item : depends) | { | ControllerState dependentState = item.getDependentState(); | @@ -262,29 +261,18 @@ | | if (print) | { | - if (first) | - first = false; | - else | - buffer.append(", "); | - | - buffer.append(iDependOn).append('{').append(dependentState.getStateString()); | - buffer.append(':'); | - if (iDependOn == null) | - { | - buffer.append("** UNRESOLVED " + item.toHumanReadableString() + " **"); | - } | - else | - { | - if (other == null) | - buffer.append("** NOT FOUND **"); | - else | - buffer.append(otherState.getStateString()); | - } | - buffer.append('}'); | + buffer.append(String.format(" Dependency \"%s\" (should be in state \"%s\", but is actually %s)\n", | + iDependOn, | + dependentState.getStateString(), | + iDependOn == null ? | + String.format("unresolved (%s)", | + item.toHumanReadableString()) : | + other == null ? | + "not found" : | + String.format("in state \"%s\"", otherState.getStateString()))); | } | } | } | - buffer.append('\n'); | } | } | throw new IllegalStateException(buffer.toString()); | View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205283#4205283 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205283

17 years, 2 months

1
0
0 / 0

[Design of POJO Server] - Re: Sub-Profiles ProfileService changes

by bstansberry＠jboss.com

"emuckenhuber" wrote : I guess you don't have a need for an VFSDeployment for your use case? well there will be a similar ProfileDeployment. No, I don't need VFSDeployment. My stuff 1) creates a ProfileMetaData from injected values, 2) asks and injected factory to create a Profile 3) calls ProfileService.register 4) calls ProfileService.activate. I don't care at all about the details of Profile, just need to have one to pass to register(). And 1,2 and 3 will go away once the XML-based approach works, at which point I'll just need to be able to create a ProfileKey to pass to activate(). :) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4205262#4205262 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4205262

17 years, 2 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums January 2009