February 2009 - jboss-dev-forums - Jboss List Archives

[Design of POJO Server] - Re: Regression on VirtualFile.toURL()

by alesj

"jason.greene(a)jboss.com" wrote : Looking at this in more detail, the JPA code is definitely wrong and an ugly hack, no matter the decision on the trailing /: | Exactly. ;-) I've said this to Carlo before - relying on impl details == very bad. :-) As this impl will fail on exploded deployments. The DI::getParent is tricky, as it might not always work - can be null. It depends on what the VFSContext's root is. It's then again an impl detail to know that we actually have a context root that's higher up the hierarchy. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211234#4211234 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211234

17 years, 1 month

1
0
0 / 0

[Design of Messaging on JBoss (Messaging/JBoss)] - Re: DeliveryCount & ACKs

by clebert.suconic＠jboss.com

If we decrement the delivery counter on cancelRefs, we are back to the original issue (The first post on this thread). I have locally done the change, and the issue happened again as I predicted. Another way to fix this would be to make autoCommitAcks = false (as somewhat suggested on JBMESSAGING-1294), and make the JMSWrappers to call Session.commit() when a message is received. I tried that as a quick fix and I could fix the test, however I got a few other issues on the DupsOK. And I also see performance issues with this, as we would make a Commit call on *ever* message received on the AUTO_ACK. Just to make a record about what's the current issue. The parts in bold are the executed parts when the Session is AUTO_ACK. The message is aways acknowledged after listener.onMessage was called on the AUTO_ACK case: | | public void onMessage(final ClientMessage message) | { | | JBossMessage jbm = JBossMessage.createMessage(message, session.getCoreSession()); | | try | { | jbm.doBeforeReceive(); | } | catch (Exception e) | { | log.error("Failed to prepare message for receipt", e); | | return; | } | | if (transactedOrClientAck) | { | try | { | message.acknowledge(); | } | catch (MessagingException e) | { | log.error("Failed to process message", e); | } | } | | try | { | listener.onMessage(jbm); | } | catch (RuntimeException e) | { | //See JMS 1.1 spec, section 4.5.2 | | log.warn("Unhandled exception thrown from onMessage", e); | | if (!transactedOrClientAck) | { | try | { | session.getCoreSession().rollback(); | | session.setRecoverCalled(true); | | } | catch (Exception e2) | { | log.error("Failed to recover session", e2); | } | } | } | | if (!session.isRecoverCalled()) | { | try | { | //We don't want to call this if the consumer was closed from inside onMessage | if (!consumer.isClosed() && !this.transactedOrClientAck) | { | message.acknowledge(); | } | } | catch (MessagingException e) | { | log.error("Failed to process message", e); | } | } | | session.setRecoverCalled(false); | } | | We need to be able to rollback the current message, so the counter are probably set. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211233#4211233 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211233

17 years, 1 month

1
0
0 / 0

[Design of POJO Server] - Re: Regression on VirtualFile.toURL()

by jason.greene＠jboss.com

"alesj" wrote : | But wouldn't that make Carlo's impl fail on exploded jar? Yes it would most definitely break on exploded jars. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211231#4211231 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211231

17 years, 1 month

1
0
0 / 0

[Design of POJO Server] - Re: Regression on VirtualFile.toURL()

by jason.greene＠jboss.com

Looking at this in more detail, the JPA code is definitely wrong and an ugly hack, no matter the decision on the trailing /: | URL url = di.getFile("").toURL(); | return new URL(url, jar); | It should instead be calling getParent().getFile(jar); View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211228#4211228 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211228

17 years, 1 month

1
0
0 / 0

[Design of POJO Server] - Re: Regression on VirtualFile.toURL()

by alesj

"jason.greene(a)jboss.com" wrote : Although I can't blame it since it is making a call to DI.getFile(). | This should actually be getVirtualFile. To be even stricter, they should call DI::getRoot. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211227#4211227 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211227

17 years, 1 month

1
0
0 / 0

[Design of POJO Server] - Re: Regression on VirtualFile.toURL()

by alesj

OK, I'll fix this appropriately tomorrow. Dirs end with '/', everything else doesn't. OK? But wouldn't that make Carlo's impl fail on exploded jar? View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211225#4211225 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211225

17 years, 1 month

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: JBAS-6518 - spaces in paths

by alesj

"adrian(a)jboss.org" wrote : | Maybe you know what magic incantations are required to make behave the same as JBossAS? :-) Apart from forcedCopy and cache settings in jbossas's vfs.xml I wouldn't know any more magic incantations. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211223#4211223 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211223

17 years, 1 month

1
0
0 / 0

[Design of POJO Server] - Re: Regression on VirtualFile.toURL()

by adrian＠jboss.org

"alesj" wrote : | All I'm saying is what does the spec say (if it says anything at all). | http://www.ietf.org/rfc/rfc2396.txt anonymous wrote : | 5.2. Resolving Relative References to Absolute Form | | ..blah.. | | 6) If this step is reached, then we are resolving a relative-path | reference. The relative path needs to be merged with the base | URI's path. Although there are many ways to do this, we will | describe a simple method using a separate string buffer. | | a) All but the last segment of the base URI's path component is | copied to the buffer. In other words, any characters after the | last (right-most) slash character, if any, are excluded. | So: /a/b/c + d = /a/b/d /a/b/c/ + d = /a/b/c/d and hence the change in behaviour of the relative url resolution. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211219#4211219 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211219

17 years, 1 month

1
0
0 / 0

[Design of POJO Server] - Re: Regression on VirtualFile.toURL()

by jason.greene＠jboss.com

The URL spec doesn't care what the path represents. It only cares whether or not it is a directory, and that is determined by the use of /. So, if VFS returns a url with a slash at the end, it's a directory. The problem is that the JPA code assumes it's getting a file and not a directory. Although I can't blame it since it is making a call to DI.getFile(). The main problem with the VFS returning a jar url as a directory, is that it introduces ambiguity with a directory having the same name. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211214#4211214 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211214

17 years, 1 month

1
0
0 / 0

[Design the new POJO MicroContainer] - Re: JBAS-6518 - spaces in paths

by adrian＠jboss.org

"alesj" wrote : "adrian(a)jboss.org" wrote : | | (which already had 15 failures????!!!!!). | | | I guess this are from testing the temps, | where I create some new directories. | It doesn't fail for me on winz, but I do see it on my Linux box. | Yep, more broken path manipulation. I've portablized it. :-) View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4211210#4211210 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4211210

17 years, 1 month

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-dev-forums February 2009