Re: [rules-dev] Guvnor 5.2.0.M1.x : Maven config fix

Hi Sayhi, Thanks for noticing this issue and creating a patch. Unfortunately I cannot accept and apply this patch because: - By changing the build resources to only include src/main/resources/**/*.gwt.xml, it breaks the backend which needs other resources out of src/main/resources.

src/main/java, it clutters the deployed jars and dirties the build (those things are in source jars already).

- It's stale when compared to master on https://github.com/droolsjbpm/guvnor -- drools-factconstraints has been removed some time already on master -- droolsjbpm-ide-common is ne - The changes are obfuscated with style changes that do not follow our guidelines. -- See README https://github.com/droolsjbpm/droolsjbpm-build-bootstrap --- More specifically about indentation I believe a much better way to deal with the gwt:run problem is to fix this issue: https://issues.jboss.org/browse/GUVNOR-1196 But that's stuck on the fact that I don't know if and how intellij/eclipse can deal with hosted mode in that structure. Any experiments and data to answer that question will help that issue forward. -- With kind regards, Geoffrey De Smet Op 24-02-11 02:17, Sayhi Aymen schreef: Here is the patch. I hope it helps ! 2011/2/23 Mauricio Salatino <salaboy(a)gmail.com&gt; > Sounds really cool.. if you can help to get maven working better for the > project I think that the dev team will highly appreciate that. > Greetings. > > On Wed, Feb 23, 2011 at 1:36 PM, Sayhi Aymen <sayhi.aymen(a)gmail.com&gt;wrote: > >> >> Hi everybody, >> >> I checked Drools 5.2.0.M1.x sources yesterday in order to look with more >> insight to *Guvnor *internals. >> >> I built the whole project with *Maven* and that was ok. >> >> But when I tried to run *Guvnor *with *Maven *(mvn gwt:run) I was >> surprised to see that the *Maven *config do not allow that, I get a lot >> of errors ! >> >> Thankfully I fixed that (after a hard night) and I want to contribute >> with that *Maven *config fix. >> >> Are you interested ? >> >> By the way, I've already been *Maven *maintainer of an open source >> project on sourceforge, *Gilead<http://noon.gilead.free.fr/gilead/index.php?page=thanks> >> *. And I can help you in the future for anything related to *Maven*. >> >> -- >> Best Regards >> Aymen SAYHI >> >> >> >> _______________________________________________ >> rules-dev mailing list >> rules-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/rules-dev >> >> > > > -- > - CTO @ http://www.plugtree.com > - MyJourney @ http://salaboy.wordpress.com > - Co-Founder @ http://www.jbug.com.ar > > - Salatino "Salaboy" Mauricio - > -- Best Regards Aymen SAYHI _______________________________________________ rules-dev mailing listrules-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/rules-dev _______________________________________________ rules-dev mailing list rules-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-dev