10:59 a.m.
In case anyone is following along (silent list!), I finally ran the debugger
on JBRULES-2932 and found a suspicious bit of syntax that was accepted by
Drools 5.1.1 but which causes Drools 5.2.0-SNAPSHOT to barf.
https://issues.jboss.org/browse/JBRULES-2932?focusedCommentId=12591856#co...
At issue is the following construction:
answer.ID ( > 1 && < 4 ) || == 5
That parenthetical followed by an or-equals looks suspicious to me (dialect
mvel). Although Drools 5.1.1 eats it just fine, should it? I want to tell
my users to write the proper rule syntax; this doesn't look right to me. On
the other hand, if it is proper syntax, I'd rather not change it, as there
are hundreds of rules that use it. :-(
Best,
Laird
--
View this message in context:
http://drools-java-rules-engine.46999.n3.nabble.com/JBRULES-2932-suspicio...
Sent from the Drools - Dev mailing list archive at Nabble.com.
12:22 p.m.
This is correct syntax, although the parens are redundant in this particular
situation.
Technically, this is called a "multi-restriction". Expand it by inserting
the field (answer.ID) in front of each relational operator. It's inherited
from COBOL :-)
-W
On 25 March 2011 16:59, ljnelson <ljnelson(a)gmail.com> wrote:
In case anyone is following along (silent list!), I finally ran the
debugger
on JBRULES-2932 and found a suspicious bit of syntax that was accepted by
Drools 5.1.1 but which causes Drools 5.2.0-SNAPSHOT to barf.
https://issues.jboss.org/browse/JBRULES-2932?focusedCommentId=12591856#co...
At issue is the following construction:
answer.ID ( > 1 && < 4 ) || == 5
That parenthetical followed by an or-equals looks suspicious to me (dialect
mvel). Although Drools 5.1.1 eats it just fine, should it? I want to tell
my users to write the proper rule syntax; this doesn't look right to me.
On
the other hand, if it is proper syntax, I'd rather not change it, as there
are hundreds of rules that use it. :-(
Best,
Laird
--
View this message in context:
http://drools-java-rules-engine.46999.n3.nabble.com/JBRULES-2932-suspicio...
Sent from the Drools - Dev mailing list archive at Nabble.com.
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
12:25 p.m.
On Fri, Mar 25, 2011 at 1:22 PM, Wolfgang Laun <wolfgang.laun(a)gmail.com>wrote:
This is correct syntax, although the parens are redundant in this
particular situation.
Technically, this is called a "multi-restriction". Expand it by inserting
the field (answer.ID) in front of each relational operator. It's inherited
from COBOL :-)
OK, so then this issue is a valid bug? Thanks for your help.
L
1:43 p.m.
Laird,
As Wolfgang mentioned, that is valid syntax (I had no idea about COBOL
though... ehehe).
Anyway, as you know by now, 5.2 is under heavy changes in the parser and
compiler sides. The particular problem you mentioned was fixed yesterday, so
no need to open a JIRA. Feel free to test against the latest HEAD if you
can.
Stay with us during this painful transition because when all is said and
done, I believe users will be happy with the new language. At the core of
the changes is the requirement to have constraints defined as: <field>
<operator> <value>. This is gone in 5.2. Now you can write constraints as
any valid boolean expression, no funky business necessary. Before, we did
not support method calls in expressions, because the () caused
ambiguities... not an issue anymore. Before you had to wrap expression in
evals, and value expressions in ()... not anymore... so, stay tuned... there
is light at the end of the tunnel... :)
Drools compiler is now running all tests green as of last night (although
we still have some ignored tests to check) and today I am trying to make
sure all tests in all core modules run fine.
Edson
2011/3/25 Laird Nelson <ljnelson(a)gmail.com>
On Fri, Mar 25, 2011 at 1:22 PM, Wolfgang Laun
<wolfgang.laun(a)gmail.com>wrote:
> This is correct syntax, although the parens are redundant in this
> particular situation.
>
> Technically, this is called a "multi-restriction". Expand it by inserting
> the field (answer.ID) in front of each relational operator. It's inherited
> from COBOL :-)
>
OK, so then this issue is a valid bug? Thanks for your help.
L
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
--
Edson Tirelli
JBoss Drools Core Development
JBoss by Red Hat @ www.jboss.com
1:51 p.m.
On Fri, Mar 25, 2011 at 2:43 PM, Edson Tirelli <ed.tirelli(a)gmail.com> wrote:
Anyway, as you know by now, 5.2 is under heavy changes in the
parser and
compiler sides. The particular problem you mentioned was fixed yesterday, so
no need to open a JIRA. Feel free to test against the latest HEAD if you
can.
Beautiful; I'll close the bug once I test from the trunk.
Stay with us during this painful transition because when all is
said and
done, I believe users will be happy with the new language. At the core of
the changes is the requirement to have constraints defined as: <field>
<operator> <value>. This is gone in 5.2. Now you can write constraints as
any valid boolean expression, no funky business necessary.
Oh, interesting.
Drools compiler is now running all tests green as of last night
(although we still have some ignored tests to check) and today I am trying
to make sure all tests in all core modules run fine.
Great! Glad to hear it. Push those SNAPSHOTs. :-)
Best,
Laird
2:28 p.m.
On Fri, Mar 25, 2011 at 2:43 PM, Edson Tirelli <ed.tirelli(a)gmail.com> wrote:
Drools compiler is now running all tests green as of last night
(although we still have some ignored tests to check) and today I am trying
to make sure all tests in all core modules run fine.
My apologies if this is one you just haven't gotten to yet, but I was trying
to build from the trunk and got these errors in drools-compiler:
Failed tests:
testBigDecimalWithFromAndEval(org.drools.integrationtests.MiscTest)
testFixModifyBlocks(org.drools.rule.builder.dialect.java.JavaConsequenceBuilderTest)
Tests in error:
testReturnValueException(org.drools.integrationtests.MiscTest)
So I can't test drools-compiler from trunk. Unless I'm just building it
badly.
Best,
Laird
2:37 p.m.
drools-compiler succeeds for me. My guess for these errors are that maybe
you are not using MVEL HEAD? There are several fixes in MVEL that are
required for building drools HEAD. Let me know otherwise...
Edson
2011/3/25 Laird Nelson <ljnelson(a)gmail.com>
On Fri, Mar 25, 2011 at 2:43 PM, Edson Tirelli
<ed.tirelli(a)gmail.com>wrote:
> Drools compiler is now running all tests green as of last night
> (although we still have some ignored tests to check) and today I am trying
> to make sure all tests in all core modules run fine.
>
My apologies if this is one you just haven't gotten to yet, but I was
trying to build from the trunk and got these errors in drools-compiler:
Failed tests:
testBigDecimalWithFromAndEval(org.drools.integrationtests.MiscTest)
testFixModifyBlocks(org.drools.rule.builder.dialect.java.JavaConsequenceBuilderTest)
Tests in error:
testReturnValueException(org.drools.integrationtests.MiscTest)
So I can't test drools-compiler from trunk. Unless I'm just building it
badly.
Best,
Laird
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
--
Edson Tirelli
JBoss Drools Core Development
JBoss by Red Hat @ www.jboss.com
2:39 p.m.
On Fri, Mar 25, 2011 at 3:37 PM, Edson Tirelli <ed.tirelli(a)gmail.com> wrote:
drools-compiler succeeds for me. My guess for these errors are that
maybe you are not using MVEL HEAD? There are several fixes in MVEL that are
required for building drools HEAD. Let me know otherwise...
Using MVEL 2.1-SNAPSHOT, freshly updated by Maven five minutes ago.
Best,
Laird
3:01 p.m.
Ok, I will have to double check that. Can you provide me with stack trace
or list of errors you are getting from these tests?
Thanks,
Edson
2011/3/25 Laird Nelson <ljnelson(a)gmail.com>
On Fri, Mar 25, 2011 at 3:37 PM, Edson Tirelli
<ed.tirelli(a)gmail.com>wrote:
>
> drools-compiler succeeds for me. My guess for these errors are that
> maybe you are not using MVEL HEAD? There are several fixes in MVEL that are
> required for building drools HEAD. Let me know otherwise...
Using MVEL 2.1-SNAPSHOT, freshly updated by Maven five minutes ago.
Best,
Laird
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
--
Edson Tirelli
JBoss Drools Core Development
JBoss by Red Hat @ www.jboss.com
3:08 p.m.
On Fri, Mar 25, 2011 at 4:02 PM, Edson Tirelli-4 [via Drools - Java Rules
Engine] <ml-node+2731966-1074749963-10124(a)n3.nabble.com> wrote:
Ok, I will have to double check that. Can you provide me with
stack
trace or list of errors you are getting from these tests?
Sure thing.
While that's compiling: I want to make sure I'm not inadvertently doing
something stupid. I git cloned the drools repo from Github and ran mvn -U
clean install.
L
--
View this message in context:
http://drools-java-rules-engine.46999.n3.nabble.com/JBRULES-2932-suspicio...
Sent from the Drools - Dev mailing list archive at Nabble.com.
3:13 p.m.
On Fri, Mar 25, 2011 at 4:01 PM, Edson Tirelli <ed.tirelli(a)gmail.com> wrote:
Ok, I will have to double check that. Can you provide me with stack
trace or list of errors you are getting from these tests?
Since attachments are most likely stripped, here's the output (stand back).
I'll list them back to back. I hope--frankly--that somehow this is my
error, but I'm not sure that it is, given that I'm just trying to build
HEAD.
First, this is from org.drools.integrationtests.MiscTest:
-------------------------------------------------------------------------------
Test set: org.drools.integrationtests.MiscTest
-------------------------------------------------------------------------------
Tests run: 191, Failures: 1, Errors: 1, Skipped: 4, Time elapsed: 9.855 sec
<<< FAILURE!
testBigDecimalWithFromAndEval(org.drools.integrationtests.MiscTest) Time
elapsed: 0.026 sec <<< FAILURE!
java.lang.AssertionError: Unable to Analyse Expression
java.math.BigDecimal.TEN:
[Error: Failed to compile: 4 compilation error(s):
- (1,1) unable to resolve method using strict-mode: java.lang.Object.java()
- (1,6) unable to resolve method using strict-mode: java.lang.Object.math()
- (1,11) unable to resolve method using strict-mode:
java.lang.Object.BigDecimal()
- (1,22) unable to resolve method using strict-mode:
java.lang.Object.TEN()]
[Near : {... java.math.BigDecimal.TEN ....}]
^
[Line: 1, Column: 1] : [Rule name='Test Rule']
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.assertTrue(Assert.java:43)
at org.junit.Assert.assertFalse(Assert.java:68)
at
org.drools.integrationtests.MiscTest.testBigDecimalWithFromAndEval(MiscTest.java:1928)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:120)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:103)
at org.apache.maven.surefire.Surefire.run(Surefire.java:169)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350)
at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021)
testReturnValueException(org.drools.integrationtests.MiscTest) Time
elapsed: 0.011 sec <<< ERROR!
[Error: unexpected end of statement]
[Near : {... ( throwException( ) ) ....}]
^
[Line: 1, Column: 22]
at org.mvel2.compiler.AbstractParser.nextToken(AbstractParser.java:1199)
at
org.mvel2.compiler.ExpressionCompiler._compile(ExpressionCompiler.java:132)
at
org.mvel2.compiler.ExpressionCompiler.compile(ExpressionCompiler.java:69)
at org.mvel2.MVEL.analysisCompile(MVEL.java:687)
at org.mvel2.MVEL.analysisCompile(MVEL.java:691)
at
org.drools.rule.builder.PatternBuilder.setInputs(PatternBuilder.java:619)
at org.drools.rule.builder.PatternBuilder.build(PatternBuilder.java:380)
at org.drools.rule.builder.PatternBuilder.build(PatternBuilder.java:268)
at org.drools.rule.builder.PatternBuilder.build(PatternBuilder.java:107)
at
org.drools.rule.builder.GroupElementBuilder.build(GroupElementBuilder.java:65)
at org.drools.rule.builder.RuleBuilder.build(RuleBuilder.java:80)
at org.drools.compiler.PackageBuilder.addRule(PackageBuilder.java:1308)
at
org.drools.compiler.PackageBuilder.addPackage(PackageBuilder.java:659)
at
org.drools.compiler.PackageBuilder.addPackageFromDrl(PackageBuilder.java:298)
at
org.drools.integrationtests.MiscTest.testReturnValueException(MiscTest.java:2868)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:120)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:103)
at org.apache.maven.surefire.Surefire.run(Surefire.java:169)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350)
at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021)
Caused by: java.lang.ArrayIndexOutOfBoundsException: -1
at org.mvel2.util.ParseTools.subsetTrimmed(ParseTools.java:908)
at org.mvel2.util.ParseTools.parseParameterList(ParseTools.java:200)
at
org.mvel2.compiler.PropertyVerifier.getMethod(PropertyVerifier.java:404)
at
org.mvel2.compiler.PropertyVerifier.analyze(PropertyVerifier.java:112)
at
org.mvel2.compiler.ExpressionCompiler.verify(ExpressionCompiler.java:387)
at
org.mvel2.compiler.ExpressionCompiler._compile(ExpressionCompiler.java:281)
at org.mvel2.util.ParseTools.subCompileExpression(ParseTools.java:2108)
at org.mvel2.ast.Substatement.<init>(Substatement.java:36)
at org.mvel2.compiler.AbstractParser.nextToken(AbstractParser.java:1045)
... 40 more
...and this is from
org.drools.rule.builder.dialect.java.JavaConsequenceBuilderTest:
-------------------------------------------------------------------------------
Test set: org.drools.rule.builder.dialect.java.JavaConsequenceBuilderTest
-------------------------------------------------------------------------------
Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.272 sec
<<< FAILURE!
testFixModifyBlocks(org.drools.rule.builder.dialect.java.JavaConsequenceBuilderTest)
Time elapsed: 0.057 sec <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...e){Cheesec2=$cheese;[{org.drools.Cheese__obj__=(c2);org.drools.FactHandle__obj____Handle2__=drools.getFactHandle(__obj__);__obj__.setPrice(10);__obj__.setOldPrice(age);drools.update(__obj____Handle2__);}]}finally{Cheesec3=$c...>
but was:<...e){Cheesec2=$cheese;[]}finally{Cheesec3=$c...>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at
org.drools.rule.builder.dialect.java.JavaConsequenceBuilderTest.assertEqualsIgnoreSpaces(JavaConsequenceBuilderTest.java:676)
at
org.drools.rule.builder.dialect.java.JavaConsequenceBuilderTest.testFixModifyBlocks(JavaConsequenceBuilderTest.java:321)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:120)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:103)
at org.apache.maven.surefire.Surefire.run(Surefire.java:169)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350)
at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021)
Best,
Laird
4991
days inactive
4991
days old
10 comments
4 participants
participants (4)
-
Edson Tirelli -
Laird Nelson -
ljnelson
-
Wolfgang Laun