7:30 a.m.
Hi,
There appears to be a regression in TypeDeclarationDescr in 5.3.x branch,
as illustrated by the below.
Bean2 is shown as having a super-type of "Object" whereas it should be
"Bean1". The fields are correctly listed.
This is causing tests in Guvnor to fail.
Could somebody please take a look?
Thanks,
Mike
package org.drools.ide.common.server.rules;
import java.io.StringReader;
import java.util.List;
import org.drools.compiler.DrlParser;
import org.drools.compiler.DroolsError;
import org.drools.compiler.PackageBuilder;
import org.drools.definition.type.FactField;
import org.drools.lang.descr.PackageDescr;
import org.drools.lang.descr.TypeDeclarationDescr;
import org.junit.Test;
public class RegressionTest {
@Test
public void regression() {
String drl = "package foo \n"
+ "declare Bean1 \n"
+ "age: int \n"
+ "name : String \n"
+ "end \n"
+ "declare Bean2 extends Bean1\n"
+ "cheese : String \n"
+ "end";
PackageBuilder builder = new PackageBuilder();
try {
DrlParser parser = new DrlParser();
PackageDescr pkgDescr = parser.parse( drl );
for ( TypeDeclarationDescr baseType :
pkgDescr.getTypeDeclarations() ) {
String declaredSuperTypeName = baseType.getSuperTypeName();
System.out.println( baseType.getTypeName() + " extends " +
declaredSuperTypeName );
}
builder.addPackageFromDrl( new StringReader( drl ) );
System.out.println("foo.Bean1 fields=");
List<FactField> fieldsBean1 = builder.getPackage().getFactType(
"foo.Bean1" ).getFields();
for ( FactField field : fieldsBean1 ) {
System.out.println( field.getName() );
}
System.out.println("foo.Bean2 fields=");
List<FactField> fieldsBean2 = builder.getPackage().getFactType(
"foo.Bean2" ).getFields();
for ( FactField field : fieldsBean2 ) {
System.out.println( field.getName() );
}
if ( builder.hasErrors() ) {
for ( DroolsError e : builder.getErrors().getErrors() ) {
System.out.println( e.getMessage() );
}
}
} catch ( Exception e ) {
e.printStackTrace();
}
}
}
6:47 a.m.
Davide,
Have you been able to look at yet?
Thanks,
Mike
On 17 February 2012 13:30, Michael Anstis <michael.anstis(a)gmail.com> wrote:
Hi,
There appears to be a regression in TypeDeclarationDescr in 5.3.x branch,
as illustrated by the below.
Bean2 is shown as having a super-type of "Object" whereas it should be
"Bean1". The fields are correctly listed.
This is causing tests in Guvnor to fail.
Could somebody please take a look?
Thanks,
Mike
package org.drools.ide.common.server.rules;
import java.io.StringReader;
import java.util.List;
import org.drools.compiler.DrlParser;
import org.drools.compiler.DroolsError;
import org.drools.compiler.PackageBuilder;
import org.drools.definition.type.FactField;
import org.drools.lang.descr.PackageDescr;
import org.drools.lang.descr.TypeDeclarationDescr;
import org.junit.Test;
public class RegressionTest {
@Test
public void regression() {
String drl = "package foo \n"
+ "declare Bean1 \n"
+ "age: int \n"
+ "name : String \n"
+ "end \n"
+ "declare Bean2 extends Bean1\n"
+ "cheese : String \n"
+ "end";
PackageBuilder builder = new PackageBuilder();
try {
DrlParser parser = new DrlParser();
PackageDescr pkgDescr = parser.parse( drl );
for ( TypeDeclarationDescr baseType :
pkgDescr.getTypeDeclarations() ) {
String declaredSuperTypeName = baseType.getSuperTypeName();
System.out.println( baseType.getTypeName() + " extends " +
declaredSuperTypeName );
}
builder.addPackageFromDrl( new StringReader( drl ) );
System.out.println("foo.Bean1 fields=");
List<FactField> fieldsBean1 =
builder.getPackage().getFactType( "foo.Bean1" ).getFields();
for ( FactField field : fieldsBean1 ) {
System.out.println( field.getName() );
}
System.out.println("foo.Bean2 fields=");
List<FactField> fieldsBean2 =
builder.getPackage().getFactType( "foo.Bean2" ).getFields();
for ( FactField field : fieldsBean2 ) {
System.out.println( field.getName() );
}
if ( builder.hasErrors() ) {
for ( DroolsError e : builder.getErrors().getErrors() ) {
System.out.println( e.getMessage() );
}
}
} catch ( Exception e ) {
e.printStackTrace();
}
}
}
7 a.m.
This now manifests itself as:-
- Broken Gunvor tests
- https://bugzilla.redhat.com/show_bug.cgi?id=796612
- https://bugzilla.redhat.com/show_bug.cgi?id=754093
With kind regards,
Mike
On 17 February 2012 13:30, Michael Anstis <michael.anstis(a)gmail.com> wrote:
Hi,
There appears to be a regression in TypeDeclarationDescr in 5.3.x branch,
as illustrated by the below.
Bean2 is shown as having a super-type of "Object" whereas it should be
"Bean1". The fields are correctly listed.
This is causing tests in Guvnor to fail.
Could somebody please take a look?
Thanks,
Mike
package org.drools.ide.common.server.rules;
import java.io.StringReader;
import java.util.List;
import org.drools.compiler.DrlParser;
import org.drools.compiler.DroolsError;
import org.drools.compiler.PackageBuilder;
import org.drools.definition.type.FactField;
import org.drools.lang.descr.PackageDescr;
import org.drools.lang.descr.TypeDeclarationDescr;
import org.junit.Test;
public class RegressionTest {
@Test
public void regression() {
String drl = "package foo \n"
+ "declare Bean1 \n"
+ "age: int \n"
+ "name : String \n"
+ "end \n"
+ "declare Bean2 extends Bean1\n"
+ "cheese : String \n"
+ "end";
PackageBuilder builder = new PackageBuilder();
try {
DrlParser parser = new DrlParser();
PackageDescr pkgDescr = parser.parse( drl );
for ( TypeDeclarationDescr baseType :
pkgDescr.getTypeDeclarations() ) {
String declaredSuperTypeName = baseType.getSuperTypeName();
System.out.println( baseType.getTypeName() + " extends " +
declaredSuperTypeName );
}
builder.addPackageFromDrl( new StringReader( drl ) );
System.out.println("foo.Bean1 fields=");
List<FactField> fieldsBean1 =
builder.getPackage().getFactType( "foo.Bean1" ).getFields();
for ( FactField field : fieldsBean1 ) {
System.out.println( field.getName() );
}
System.out.println("foo.Bean2 fields=");
List<FactField> fieldsBean2 =
builder.getPackage().getFactType( "foo.Bean2" ).getFields();
for ( FactField field : fieldsBean2 ) {
System.out.println( field.getName() );
}
if ( builder.hasErrors() ) {
for ( DroolsError e : builder.getErrors().getErrors() ) {
System.out.println( e.getMessage() );
}
}
} catch ( Exception e ) {
e.printStackTrace();
}
}
}
6:09 a.m.
New subject: Fwd: 5.3.x regression in TypeDeclarationDescr
JIRAs created:-
https://issues.jboss.org/browse/JBRULES-3417
https://issues.jboss.org/browse/JBRULES-3418
Unit tests added to 5.3.x branch (@Ignore'd failing) and master (not
@Ignore'd and passing).
Thanks,
Mike
---------- Forwarded message ----------
From: Michael Anstis <michael.anstis(a)gmail.com>
Date: 27 February 2012 13:00
Subject: Re: 5.3.x regression in TypeDeclarationDescr
To: drools-dev <rules-dev(a)lists.jboss.org>
This now manifests itself as:-
- Broken Gunvor tests
- https://bugzilla.redhat.com/show_bug.cgi?id=796612
- https://bugzilla.redhat.com/show_bug.cgi?id=754093
With kind regards,
Mike
On 17 February 2012 13:30, Michael Anstis <michael.anstis(a)gmail.com> wrote:
Hi,
There appears to be a regression in TypeDeclarationDescr in 5.3.x branch,
as illustrated by the below.
Bean2 is shown as having a super-type of "Object" whereas it should be
"Bean1". The fields are correctly listed.
This is causing tests in Guvnor to fail.
Could somebody please take a look?
Thanks,
Mike
package org.drools.ide.common.server.rules;
import java.io.StringReader;
import java.util.List;
import org.drools.compiler.DrlParser;
import org.drools.compiler.DroolsError;
import org.drools.compiler.PackageBuilder;
import org.drools.definition.type.FactField;
import org.drools.lang.descr.PackageDescr;
import org.drools.lang.descr.TypeDeclarationDescr;
import org.junit.Test;
public class RegressionTest {
@Test
public void regression() {
String drl = "package foo \n"
+ "declare Bean1 \n"
+ "age: int \n"
+ "name : String \n"
+ "end \n"
+ "declare Bean2 extends Bean1\n"
+ "cheese : String \n"
+ "end";
PackageBuilder builder = new PackageBuilder();
try {
DrlParser parser = new DrlParser();
PackageDescr pkgDescr = parser.parse( drl );
for ( TypeDeclarationDescr baseType :
pkgDescr.getTypeDeclarations() ) {
String declaredSuperTypeName = baseType.getSuperTypeName();
System.out.println( baseType.getTypeName() + " extends " +
declaredSuperTypeName );
}
builder.addPackageFromDrl( new StringReader( drl ) );
System.out.println("foo.Bean1 fields=");
List<FactField> fieldsBean1 =
builder.getPackage().getFactType( "foo.Bean1" ).getFields();
for ( FactField field : fieldsBean1 ) {
System.out.println( field.getName() );
}
System.out.println("foo.Bean2 fields=");
List<FactField> fieldsBean2 =
builder.getPackage().getFactType( "foo.Bean2" ).getFields();
for ( FactField field : fieldsBean2 ) {
System.out.println( field.getName() );
}
if ( builder.hasErrors() ) {
for ( DroolsError e : builder.getErrors().getErrors() ) {
System.out.println( e.getMessage() );
}
}
} catch ( Exception e ) {
e.printStackTrace();
}
}
}
2:34 a.m.
New subject: 5.3.x branch test failures. WAS: Re: 5.3.x regression in TypeDeclarationDescr
Hi Mike,
I believe it is the same regression problem you mentioned that caused
following 2 tests failed on 5.3.x branch?
http://hudson.qa.jboss.com/hudson/job/guvnor-5.3.x/564/
BTW, we started to get those 2 failures around Feb 9, 2012 , if this
info helps to find out whom is to blame ;-). Please check
http://hudson.qa.jboss.com/hudson/job/guvnor-5.3.x/473/. The build 473
was triggered by a upstream change.
Thanks,
Jervis
On 2012/2/17 21:30, Michael Anstis wrote:
Hi,
There appears to be a regression in TypeDeclarationDescr in 5.3.x
branch, as illustrated by the below.
Bean2 is shown as having a super-type of "Object" whereas it should be
"Bean1". The fields are correctly listed.
This is causing tests in Guvnor to fail.
Could somebody please take a look?
Thanks,
Mike
package org.drools.ide.common.server.rules;
import java.io.StringReader;
import java.util.List;
import org.drools.compiler.DrlParser;
import org.drools.compiler.DroolsError;
import org.drools.compiler.PackageBuilder;
import org.drools.definition.type.FactField;
import org.drools.lang.descr.PackageDescr;
import org.drools.lang.descr.TypeDeclarationDescr;
import org.junit.Test;
public class RegressionTest {
@Test
public void regression() {
String drl = "package foo \n"
+ "declare Bean1 \n"
+ "age: int \n"
+ "name : String \n"
+ "end \n"
+ "declare Bean2 extends Bean1\n"
+ "cheese : String \n"
+ "end";
PackageBuilder builder = new PackageBuilder();
try {
DrlParser parser = new DrlParser();
PackageDescr pkgDescr = parser.parse( drl );
for ( TypeDeclarationDescr baseType :
pkgDescr.getTypeDeclarations() ) {
String declaredSuperTypeName =
baseType.getSuperTypeName();
System.out.println( baseType.getTypeName() + " extends
" + declaredSuperTypeName );
}
builder.addPackageFromDrl( new StringReader( drl ) );
System.out.println("foo.Bean1 fields=");
List<FactField> fieldsBean1 =
builder.getPackage().getFactType( "foo.Bean1" ).getFields();
for ( FactField field : fieldsBean1 ) {
System.out.println( field.getName() );
}
System.out.println("foo.Bean2 fields=");
List<FactField> fieldsBean2 =
builder.getPackage().getFactType( "foo.Bean2" ).getFields();
for ( FactField field : fieldsBean2 ) {
System.out.println( field.getName() );
}
if ( builder.hasErrors() ) {
for ( DroolsError e : builder.getErrors().getErrors() ) {
System.out.println( e.getMessage() );
}
}
} catch ( Exception e ) {
e.printStackTrace();
}
}
}
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
4:02 a.m.
New subject: 5.3.x branch test failures. WAS: Re: 5.3.x regression in TypeDeclarationDescr
Yes Jervis you are correct.
This is the current impact of the regression:-
- Broken Gunvor tests
-
org.drools.ide.common.server.rules.SuggestionCompletionLoaderTest.testGeneratedBeansExtendsSimple
-
org.drools.ide.common.server.rules.SuggestionCompletionLoaderTest.testGeneratedBeansExtendsPOJOComplex
- https://bugzilla.redhat.com/show_bug.cgi?id=796612
- https://bugzilla.redhat.com/show_bug.cgi?id=754093
With kind regards,
Mike
On 1 March 2012 08:34, Jervis Liu <jliu(a)redhat.com> wrote:
Hi Mike,
I believe it is the same regression problem you mentioned that caused
following 2 tests failed on 5.3.x branch?
http://hudson.qa.jboss.com/hudson/job/guvnor-5.3.x/564/
BTW, we started to get those 2 failures around Feb 9, 2012 , if this info
helps to find out whom is to blame ;-). Please check
http://hudson.qa.jboss.com/hudson/job/guvnor-5.3.x/473/. The build 473
was triggered by a upstream change.
Thanks,
Jervis
On 2012/2/17 21:30, Michael Anstis wrote:
Hi,
There appears to be a regression in TypeDeclarationDescr in 5.3.x branch,
as illustrated by the below.
Bean2 is shown as having a super-type of "Object" whereas it should be
"Bean1". The fields are correctly listed.
This is causing tests in Guvnor to fail.
Could somebody please take a look?
Thanks,
Mike
package org.drools.ide.common.server.rules;
import java.io.StringReader;
import java.util.List;
import org.drools.compiler.DrlParser;
import org.drools.compiler.DroolsError;
import org.drools.compiler.PackageBuilder;
import org.drools.definition.type.FactField;
import org.drools.lang.descr.PackageDescr;
import org.drools.lang.descr.TypeDeclarationDescr;
import org.junit.Test;
public class RegressionTest {
@Test
public void regression() {
String drl = "package foo \n"
+ "declare Bean1 \n"
+ "age: int \n"
+ "name : String \n"
+ "end \n"
+ "declare Bean2 extends Bean1\n"
+ "cheese : String \n"
+ "end";
PackageBuilder builder = new PackageBuilder();
try {
DrlParser parser = new DrlParser();
PackageDescr pkgDescr = parser.parse( drl );
for ( TypeDeclarationDescr baseType :
pkgDescr.getTypeDeclarations() ) {
String declaredSuperTypeName = baseType.getSuperTypeName();
System.out.println( baseType.getTypeName() + " extends " +
declaredSuperTypeName );
}
builder.addPackageFromDrl( new StringReader( drl ) );
System.out.println("foo.Bean1 fields=");
List<FactField> fieldsBean1 =
builder.getPackage().getFactType( "foo.Bean1" ).getFields();
for ( FactField field : fieldsBean1 ) {
System.out.println( field.getName() );
}
System.out.println("foo.Bean2 fields=");
List<FactField> fieldsBean2 =
builder.getPackage().getFactType( "foo.Bean2" ).getFields();
for ( FactField field : fieldsBean2 ) {
System.out.println( field.getName() );
}
if ( builder.hasErrors() ) {
for ( DroolsError e : builder.getErrors().getErrors() ) {
System.out.println( e.getMessage() );
}
}
} catch ( Exception e ) {
e.printStackTrace();
}
}
}
_______________________________________________
rules-dev mailing
listrules-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/rules-dev
_______________________________________________
rules-dev mailing list
rules-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/rules-dev
4648
days inactive
4669
days old
5 comments
2 participants
participants (2)
-
Jervis Liu -
Michael Anstis