Ales,
what will the proper filter do? Which components will the filter impact
(JBossWeb + Seam or only Seam?) Are any other components impacted?
Thanks,
Scott
On 08/04/2009 03:52 PM, Ales Justin wrote:
[
https://jira.jboss.org/jira/browse/JBPAPP-2365?page=com.atlassian.jira.pl...
]
Ales Justin commented on JBPAPP-2365:
-------------------------------------
Is there still time to instead of just deleting those two lines,
implement proper filter?
I can do that tomorrow, first thing in the morning.
> > Fix Seam hot-deploy issue AS 5.1.0 has
> > --------------------------------------
> >
> > Key: JBPAPP-2365
> > URL:
https://jira.jboss.org/jira/browse/JBPAPP-2365
Pete Muir wrote:
> Scott,
>
> I can't comment on the impact, but Jozef Hartinger from Seam QE can
> help you verify the change actually fixes the bug (he did already by
> a manual edit) in the EAP branch.
>
> Pete
>
> On 4 Aug 2009, at 19:03, Scott Marlow wrote:
>
>> The change mentioned in JBPAPP-2365 has not yet been applied to
>> EAP5. I can do this but I need help in verifying that the change
>> will not cause any harm. I also need help in verifying that the
>> change causes some good. Could someone please explain what the
>> impact of the following change will be? Please add your response to
>> JBPAPP-2365 so others can see your answer.
>>
>> The recommended change is to update conf/bootstrap/profile.xml from
>> (see two lines with "|" in first column):
>>
>> <!-- This just checks metadata locations -->
>> <bean name="MetaDataStructureModificationChecker"
>>
class="org.jboss.deployers.vfs.spi.structure.modified.MetaDataStructureModificationChecker">
>>
>> <constructor>
>> <parameter><inject bean="MainDeployer"
/></parameter>
>> </constructor>
>> <property name="cache"><inject
bean="StructureModCache" /></property>
>> | <property name="filter"><bean
>>
class="org.jboss.system.server.profile.basic.XmlIncludeVirtualFileFilter"
>> /></property>
>> </bean>
>>
>> <!-- We just visit wars, but exclude classes, lib, dev dirs -->
>> <bean name="WebVisitorAttributes"
>>
class="org.jboss.system.server.profile.basic.IncludeExcludeVisitorAttributes">
>>
>> <constructor>
>> <parameter>
>> <set>
>> <value>.war</value>
>> </set>
>> </parameter>
>> <parameter>
>> <set>
>> <value>WEB-INF/classes</value>
>> <value>WEB-INF/lib</value>
>> | <value>WEB-INF/dev</value>
>> </set>
>> </parameter>
>> </constructor>
>> </bean>
>>
>> To:
>>
>> <!-- This just checks metadata locations -->
>> <bean name="MetaDataStructureModificationChecker"
>>
class="org.jboss.deployers.vfs.spi.structure.modified.MetaDataStructureModificationChecker">
>>
>> <constructor>
>> <parameter><inject bean="MainDeployer"
/></parameter>
>> </constructor>
>> <property name="cache"><inject
bean="StructureModCache" /></property>
>> </bean>
>>
>> <!-- We just visit wars, but exclude classes, lib, dev dirs -->
>> <bean name="WebVisitorAttributes"
>>
class="org.jboss.system.server.profile.basic.IncludeExcludeVisitorAttributes">
>>
>> <constructor>
>> <parameter>
>> <set>
>> <value>.war</value>
>> </set>
>> </parameter>
>> <parameter>
>> <set>
>> <value>WEB-INF/classes</value>
>> <value>WEB-INF/lib</value>
>> </set>
>> </parameter>
>> </constructor>
>> </bean>
>>
>> Thanks,
>> Scott
>>
>> On 08/04/2009 01:49 PM, Pete Muir wrote:
>>> See
https://jira.jboss.org/jira/browse/JBPAPP-2365 - Scott is onto it.
>>>
>>> On 4 Aug 2009, at 18:40, Max Rydahl Andersen wrote:
>>>
>>>> Okey - so I guess we need to get this raised as a gigantic red
>>>> flag somewhere towards AS5/EAP
>>>> since otherwise EAP 5 + JBDS outofbox won't have the
>>>> fastturnaround deployment :(
>>>>
>>>> /max
>>>>
>>>> Jaikiran Pai wrote:
>>>>>
>>>>> Pete Muir wrote:
>>>>>
>>>>>> Looks like
https://jira.jboss.org/jira/browse/JBAS-6722 which is
>>>>>> marked fix for 5.2.x
>>>>>>
>>>>>> But JIRA won't display that issue (I'm contacting
jboss.org
>>>>>> support).
>>>>>>
>>>>>>
>>>>> Jason, had opened a helpdesk ticket for this a long time back. Looks
>>>>> like it's still not resolved. Here's how you can see the
contents
>>>>> (workaround)
>>>>>
https://jira.jboss.org/jira/si/jira.issueviews:issue-html/JBAS-6722/JBAS-...
>>>>>
>>>>>
>>>>>
>>>>> -Jaikiran
>>>>>
>>>>>> On 4 Aug 2009, at 15:46, Pete Muir wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> I don't see what JBAS-6782 has to do with hot deployment.
I
>>>>>>> know we
>>>>>>> have previously had problems with hot deployment on JBoss AS
5,
>>>>>>> but
>>>>>>> the ones we saw were supposed to be fixed in AS 5.1
>>>>>>>
>>>>>>> The basic hot-deployment should be tested as part of Seam
2.2.0.GA
>>>>>>> release process. Norman, Ondrej, Jozef - did it get checked?
>>>>>>>
>>>>>>> On 4 Aug 2009, at 15:28, Marek Novotny wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Snjezana Peco píše v Út 04. 08. 2009 v 16:12 +0200:
>>>>>>>>
>>>>>>>>
>>>>>>>>> I have tried incremental hot deployment of Java
components as
>>>>>>>>> described
>>>>>>>>> on
>>>>>>>>>
http://docs.jboss.org/seam/2.2.0.GA/reference/en-US/html/gettingstarted.h...
>>>>>>>>>
>>>>>>>>> It works correctly with JBoss AS 4.2.3, but
doesn't work with
>>>>>>>>> JBoss
>>>>>>>>> AS 5.1.
>>>>>>>>> See
https://jira.jboss.org/jira/browse/JBIDE-4585 for
more
>>>>>>>>> details.
>>>>>>>>>
>>>>>>>>> Is there any way to solve this issue?
>>>>>>>>>
>>>>>>>>>
>>>>>>>> it doesn't work for now -
https://jira.jboss.org/jira/browse/
>>>>>>>> JBAS-6782
>>>>>>>>
>>>>>>>>
>>>>>>>>> Snjeza
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> seam-dev mailing list
>>>>>>>>> seam-dev(a)lists.jboss.org
>>>>>>>>>
https://lists.jboss.org/mailman/listinfo/seam-dev
>>>>>>>>>
>>>>>>>>>
>>>>>>>> --
>>>>>>>> Marek Novotny
>>>>>>>> --
>>>>>>>> JBoss Seam Product Lead
>>>>>>>>
>>>>>>>> Red Hat Czech s.r.o.
>>>>>>>> Purkynova 99
>>>>>>>> 612 45 Brno
>>>>>>>>
>>>>>>>> Email: mnovotny(a)redhat.com
>>>>>>>> Office phone: +420 532 294 287, ext. 82-62 087
>>>>>>>> mobile: +420 608 509 230
>>>>>>>>
>>>>>>>> ------------------------------------------------------
>>>>>>>> Looking to carve out IT costs?
>>>>>>>>
www.europe.redhat.com/promo/carveoutcosts/
>>>>>>>> _______________________________________________
>>>>>>>> seam-dev mailing list
>>>>>>>> seam-dev(a)lists.jboss.org
>>>>>>>>
https://lists.jboss.org/mailman/listinfo/seam-dev
>>>>>>>>
>>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> seam-dev mailing list
>>>>>>> seam-dev(a)lists.jboss.org
>>>>>>>
https://lists.jboss.org/mailman/listinfo/seam-dev
>>>>>>>
>>>>>>>
>>>>>> _______________________________________________
>>>>>> seam-dev mailing list
>>>>>> seam-dev(a)lists.jboss.org
>>>>>>
https://lists.jboss.org/mailman/listinfo/seam-dev
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> seam-dev mailing list
>>>>> seam-dev(a)lists.jboss.org
>>>>>
https://lists.jboss.org/mailman/listinfo/seam-dev
>>>>>
>>>
>>
>