7:35 a.m.
First, let me say that I like the rewrite support in Seam 2.1 (I just
discovered it a couple of days ago). I have one concern and one
suggestion. First, my concern.
The logging level in the filter is too high. Reporting the matching
paths should be a debug-level log, not an info-level log. It's a
simple matter of ratio. The log messages at info level are now being
dominated by this filter. Perhaps it can report a summary when it
matches, but now it is reporting the details about how it is locating
the match.
Second, it appears that this filter does not offer outbound rewriting.
If the link on my page has a URL that would match, it is not being
rewritten. Is this planned? If not, can we plan it?
-Dan
--
Dan Allen
Software consultant | Author of Seam in Action
http://mojavelinux.com
http://mojavelinux.com/seaminaction
NOTE: While I make a strong effort to keep up with my email on a daily
basis, personal or other work matters can sometimes keep me away
from my email. If you contact me, but don't hear back for more than a week,
it is very likely that I am excessively backlogged or the message was
caught in the spam filters. Please don't hesitate to resend a message if
you feel that it did not reach my attention.
7:43 a.m.
On Oct 14, 2008, at 12:35 AM, Dan Allen wrote:
The logging level in the filter is too high.
It's already been fixed, though it's possible I missed some.
Second, it appears that this filter does not offer outbound
rewriting.
If the link on my page has a URL that would match, it is not being
rewritten. Is this planned? If not, can we plan it?
Yes, it does bidirectional rewriting from a single pattern. See the
blog app for an example. If there is a case that isn't working that
you think should work, let me know so I can take a look.
8:04 a.m.
Oops, I should have updated SVN first. I'll test it out, but
otherwise, great news!
-Dan
On Tue, Oct 14, 2008 at 1:43 AM, Norman Richards <orb(a)nostacktrace.com> wrote:
On Oct 14, 2008, at 12:35 AM, Dan Allen wrote:
> The logging level in the filter is too high.
It's already been fixed, though it's possible I missed some.
> Second, it appears that this filter does not offer outbound rewriting.
> If the link on my page has a URL that would match, it is not being
> rewritten. Is this planned? If not, can we plan it?
Yes, it does bidirectional rewriting from a single pattern. See the blog
app for an example. If there is a case that isn't working that you think
should work, let me know so I can take a look.
--
Dan Allen
Software consultant | Author of Seam in Action
http://mojavelinux.com
http://mojavelinux.com/seaminaction
NOTE: While I make a strong effort to keep up with my email on a daily
basis, personal or other work matters can sometimes keep me away
from my email. If you contact me, but don't hear back for more than a week,
it is very likely that I am excessively backlogged or the message was
caught in the spam filters. Please don't hesitate to resend a message if
you feel that it did not reach my attention.
8:19 a.m.
Works perfectly! I must have just been out of date.
-Dan
On Tue, Oct 14, 2008 at 2:04 AM, Dan Allen <dan.j.allen(a)gmail.com> wrote:
Oops, I should have updated SVN first. I'll test it out, but
otherwise, great news!
-Dan
On Tue, Oct 14, 2008 at 1:43 AM, Norman Richards <orb(a)nostacktrace.com> wrote:
>
> On Oct 14, 2008, at 12:35 AM, Dan Allen wrote:
>
>> The logging level in the filter is too high.
>
> It's already been fixed, though it's possible I missed some.
>
>> Second, it appears that this filter does not offer outbound rewriting.
>> If the link on my page has a URL that would match, it is not being
>> rewritten. Is this planned? If not, can we plan it?
>
> Yes, it does bidirectional rewriting from a single pattern. See the blog
> app for an example. If there is a case that isn't working that you think
> should work, let me know so I can take a look.
>
>
>
--
Dan Allen
Software consultant | Author of Seam in Action
http://mojavelinux.com
http://mojavelinux.com/seaminaction
NOTE: While I make a strong effort to keep up with my email on a daily
basis, personal or other work matters can sometimes keep me away
from my email. If you contact me, but don't hear back for more than a week,
it is very likely that I am excessively backlogged or the message was
caught in the spam filters. Please don't hesitate to resend a message if
you feel that it did not reach my attention.
--
Dan Allen
Software consultant | Author of Seam in Action
http://mojavelinux.com
http://mojavelinux.com/seaminaction
NOTE: While I make a strong effort to keep up with my email on a daily
basis, personal or other work matters can sometimes keep me away
from my email. If you contact me, but don't hear back for more than a week,
it is very likely that I am excessively backlogged or the message was
caught in the spam filters. Please don't hesitate to resend a message if
you feel that it did not reach my attention.
9:48 a.m.
On 14 Oct 2008, at 06:35, Dan Allen wrote:
First, let me say that I like the rewrite support in Seam 2.1 (I
just
discovered it a couple of days ago). I have one concern and one
suggestion. First, my concern.
The logging level in the filter is too high. Reporting the matching
paths should be a debug-level log, not an info-level log. It's a
simple matter of ratio. The log messages at info level are now being
dominated by this filter. Perhaps it can report a summary when it
matches, but now it is reporting the details about how it is locating
the match.
Actually, they should probably all be at trace IMO.
Second, it appears that this filter does not offer outbound rewriting.
If the link on my page has a URL that would match, it is not being
rewritten. Is this planned? If not, can we plan it?
-Dan
--
Dan Allen
Software consultant | Author of Seam in Action
http://mojavelinux.com
http://mojavelinux.com/seaminaction
NOTE: While I make a strong effort to keep up with my email on a daily
basis, personal or other work matters can sometimes keep me away
from my email. If you contact me, but don't hear back for more than
a week,
it is very likely that I am excessively backlogged or the message was
caught in the spam filters. Please don't hesitate to resend a
message if
you feel that it did not reach my attention.
_______________________________________________
seam-dev mailing list
seam-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/seam-dev
5673
days inactive
5673
days old
4 comments
3 participants
participants (3)
-
Dan Allen -
Norman Richards -
Pete Muir