what else has an ENC besides a WAR and an EJB?
EJB3 creates its own ENC and pushes/pops it onto a ThreadLocalStack that the ObjectFactory uses. Why can't a WAR do the same exact thing? Does JBossWeb control ENC creation or does Tomcat specific libraries? If JBossWeb, then it should be easy to add something to push/pop a JBossWeb created ENC and share the ObjectFactory implementation EJB3 uses.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3995396#3995396
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3995396
The class loader based ENCFactory really should be dropped for a thread or invocation context keyed implementation. The main issue in switching is getting all of the component calls paths tied into the correct lookup mechanism. We also need a jndi Context wrapper that allows the enc context to be read-only.
This should be a common ENCMap bean that provides the various enc Contexts keyed by a unique component deployment id. The id key is what needs to be made available for the java:comp ObjectFactory via thread local or invocation context key.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3995392#3995392
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3995392
"manik.surtani(a)jboss.com" wrote :
| "bstansberry(a)jboss.com" wrote :
| | A kinder gentler way is to create CacheImpl, and then make TreeCache a trivial subclass. Then mark TreeCache deprecated with a comment it will be removed in 2.1 or 2.2.
|
| Do we really want this? Like you said we don't want people talking to the implementation directly at all, especially since we can't guarantee correct behaviour with the interceptor chains, etc. I'd rather remove this altogether, like you said forcing people to write to the new API.
+1 from me on not doing that. I added the idea in case any 'kinder, gentler' readers were concerned about changing the name. I'm a heartless thug. ;-)
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3995387#3995387
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3995387
"manik.surtani(a)jboss.com" wrote : "bstansberry(a)jboss.com" wrote :
| | If we're exposing the TM directly via the Cache interface, I don't need that. Having the cache stick a ref to its TM in Configuration.runtime would serve the need.
|
| Don't we expose this via the runtime right now?
Yeah, we do. I expressed that badly. Also I double checked -- if the cache uses the TMLookup to find the TM, it then adds the TM to the runtime. So it's always available that way.
So no reason to expose it via the Cache interface.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3995386#3995386
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3995386
On an implementation level, this makes sense. But on an interface level, I prefer individual getters/setters. I see your point mentioned on a different thread:
"genman" wrote :
|
| I think a get/set(boolean) for the NodeSPI is fine. I'm more concerned about the underlying implementation: It's just likely that the set of properties of a node will expand over time. What will inevitably happen is you'll want to add more methods to NodeSPI. The idea is to add some potential for future expansion.
|
| If you think of the Tree as somewhat modeled off of a file system, the need for meta-data comes up time and time again. Maybe Java annotations can serve this role? But really you need something more dynamic.
|
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3995358#3995358
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3995358