"scott.stark(a)jboss.org" wrote : I guess the main argument for having x.merge(...) merge into x is is that if you don't have jboss a metadata instance to merge you have strange code vs just passing in null:
If we merge into self, the argument stands. If we merge into a new object graph and there is no spec you would get:
jboss.merged(merged, null);
As a counter point: the instance merge methods would be more in line with that static ones. Both having the same arguments with a static merge method returning the result and an instance merge method working on this.
For me only the merged view is important, so I don't mind what happens to the original objects.
What happens when we get another view / annotation view?
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4097512#4097512
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4097512
"scott.stark(a)jboss.org" wrote : In terms of having the override associated with the jboss version of the metadata, its not really needed and could be dropped.
So we're going for complete inheritance to parse ejb-jar constructs in jboss xml?
"scott.stark(a)jboss.org" wrote : I do think we do need the merge logic between the spec and jboss classes in the various classes for ease of maintence.
Agreed, we must have some class hierarchy for merging, so we might as well the classes themselves responsible for that.
As soon as we drop override, it should clear up a bit.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4097502#4097502
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4097502
In my example above, identity == userId, which would presumably be unchanged. If they used some system with synthetic primary keys and a uniqueness constraint on the userId, then no problem.
Re: explicit versioning being meant to represent database versioning, true enough, but using a simple increment counter is a pretty common way to do database versioning.
Note that all of my discussion here isn't meant to advocate against keeping a tombstone on the local node; just trying to identify problem areas and see how significant. Seems like this is a pretty small corner case that's preventable by using a synthetic primary key or a non-repeatable db version.
View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4097498#4097498
Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4097498